SADE issueshttps://gitlab.gwdg.de/SADE/SADE/-/issues2021-11-29T12:01:26Zhttps://gitlab.gwdg.de/SADE/SADE/-/issues/131Add sade.textgrid.de to README2021-11-29T12:01:26ZStefan E. Funkfunk@sub.uni-goettingen.deAdd sade.textgrid.de to READMEReferenzinstanz in die Doku? <https://sade.textgrid.de>Referenzinstanz in die Doku? <https://sade.textgrid.de>https://gitlab.gwdg.de/SADE/SADE/-/issues/130Add a few words of generic SADE description2021-11-29T12:00:20ZStefan E. Funkfunk@sub.uni-goettingen.deAdd a few words of generic SADE description# Description
No bug, just a documentation issue. Maybe take text from: https://wiki.de.dariah.eu/display/TextGrid/Publish+Tool+SADE
## I expected the following to happen:
…
## On the contrary, I observed:
…
# How to reproduce the ...# Description
No bug, just a documentation issue. Maybe take text from: https://wiki.de.dariah.eu/display/TextGrid/Publish+Tool+SADE
## I expected the following to happen:
…
## On the contrary, I observed:
…
# How to reproduce the bug
Please describe briefly how you discovered the bug and what a developer has to do to reproduce it.
_Steps:_
* Step 1
* Step 2
* ...
# Severity
How much impact does this bug have on the product or further development?
* [X] Minor
* [ ] Major
* [ ] Critical
* [ ] Blocker
# Platform
* [ ] Unix
* [ ] Windows
* [ ] MacOS
# Program version
Which version of SADE did you use?
# Related tickets
Add related issues if applicable.
/cc [Mathias Göbel](https://gitlab.gwdg.de/mgoebel), [Stefan Hynek](https://gitlab.gwdg.de/hynek), [Michelle Weidling](https://gitlab.gwdg.de/mrodzis)https://gitlab.gwdg.de/SADE/SADE/-/issues/129Follow-up from "Draft: Resolve "switch build/release to single branch "main"""2021-05-10T13:11:10ZStefan Hynekstefan.hynek@uni-goettingen.deFollow-up from "Draft: Resolve "switch build/release to single branch "main"""The following discussion from !94 should be addressed:
- [ ] @mrodzis started a [discussion](https://gitlab.gwdg.de/SADE/SADE/-/merge_requests/94#note_316299):
> Double spaceThe following discussion from !94 should be addressed:
- [ ] @mrodzis started a [discussion](https://gitlab.gwdg.de/SADE/SADE/-/merge_requests/94#note_316299):
> Double spacehttps://gitlab.gwdg.de/SADE/SADE/-/issues/128Move tests from `post-install.xq` to be called from ci after successful deplo...2021-05-10T13:08:36ZStefan Hynekstefan.hynek@uni-goettingen.deMove tests from `post-install.xq` to be called from ci after successful deploymentThe following discussion from !94 should be addressed:
- [ ] @mrodzis started a [discussion](https://gitlab.gwdg.de/SADE/SADE/-/merge_requests/94#note_316300):
> Maybe the tests should be moved to a CI stage then. Otherwise we mig...The following discussion from !94 should be addressed:
- [ ] @mrodzis started a [discussion](https://gitlab.gwdg.de/SADE/SADE/-/merge_requests/94#note_316300):
> Maybe the tests should be moved to a CI stage then. Otherwise we might not notice failing ones.https://gitlab.gwdg.de/SADE/SADE/-/issues/124save data outside app-root2020-08-20T06:05:52ZStefan Hynekstefan.hynek@uni-goettingen.desave data outside app-root# Description
Just leave a short summary what the feature is about.
# Use Cases
If you can, please provide use cases for this feature.
# Classification
Is this feature an enhancement of existing code or a completely new feature?
* [...# Description
Just leave a short summary what the feature is about.
# Use Cases
If you can, please provide use cases for this feature.
# Classification
Is this feature an enhancement of existing code or a completely new feature?
* [ ] enhancement
* [ ] new feature
# Related Tickets
Add all related issues if applicable.
/cc @mgoebel, @hynek, @mrodzisSimon SendlerStefan Hynekstefan.hynek@uni-goettingen.deFlorian BarthSimon Sendlerhttps://gitlab.gwdg.de/SADE/SADE/-/issues/120Evaluate XQStyle2020-02-06T12:40:00ZMichelle WeidlingEvaluate XQStyle[XQStyle](https://github.com/abhinavmishra14/XQStyle) may be a tool worth looking into for code quality checking.[XQStyle](https://github.com/abhinavmishra14/XQStyle) may be a tool worth looking into for code quality checking.https://gitlab.gwdg.de/SADE/SADE/-/issues/119Workflow: Vulnerabilites2020-02-06T12:33:33ZMichelle WeidlingWorkflow: VulnerabilitesWe should discuss about https://bestpractices.coreinfrastructure.org/en/projects/3579 Vulnerabilities. Should they be monitored? Is this applicable to SADE at all?We should discuss about https://bestpractices.coreinfrastructure.org/en/projects/3579 Vulnerabilities. Should they be monitored? Is this applicable to SADE at all?https://gitlab.gwdg.de/SADE/SADE/-/issues/118Workflow: Add a way of regularly adressing new issues2020-02-06T12:31:45ZMichelle WeidlingWorkflow: Add a way of regularly adressing new issues> The project MUST acknowledge a majority of bug reports submitted in the last 2-12 months (inclusive); the response need not include a fix.
Cf. https://bestpractices.coreinfrastructure.org/en/projects/3579 Bug reporting process.> The project MUST acknowledge a majority of bug reports submitted in the last 2-12 months (inclusive); the response need not include a fix.
Cf. https://bestpractices.coreinfrastructure.org/en/projects/3579 Bug reporting process.https://gitlab.gwdg.de/SADE/SADE/-/issues/117Add feedback chanels to SADE website2020-05-04T09:16:48ZMichelle WeidlingAdd feedback chanels to SADE website> The project website MUST provide information on how to: obtain, provide feedback (as bug reports or enhancements), and contribute to the software.
cf. https://bestpractices.coreinfrastructure.org/en/projects/3579 Basic project websit...> The project website MUST provide information on how to: obtain, provide feedback (as bug reports or enhancements), and contribute to the software.
cf. https://bestpractices.coreinfrastructure.org/en/projects/3579 Basic project website content.https://gitlab.gwdg.de/SADE/SADE/-/issues/116proper logging2021-05-07T11:00:18ZStefan Hynekstefan.hynek@uni-goettingen.deproper logging# Description
By now, SADE is logging to system-out. But this information is lost when not saved into log-files.
# Use Cases
* [ ] [ modules/wiki/confluence.xqm ](https://gitlab.gwdg.de/search?utf8=%E2%9C%93&snippets=&scope=&repository...# Description
By now, SADE is logging to system-out. But this information is lost when not saved into log-files.
# Use Cases
* [ ] [ modules/wiki/confluence.xqm ](https://gitlab.gwdg.de/search?utf8=%E2%9C%93&snippets=&scope=&repository_ref=develop&search=util%3Alog&project_id=2055#L83)
* [ ] [post-install.xq ](https://gitlab.gwdg.de/search?utf8=%E2%9C%93&snippets=&scope=&repository_ref=develop&search=util%3Alog&project_id=2055#L83)
* [ ] [post-install.xq ](https://gitlab.gwdg.de/search?utf8=%E2%9C%93&snippets=&scope=&repository_ref=develop&search=util%3Alog&project_id=2055#L106)
* [ ] [post-install.xq ](https://gitlab.gwdg.de/search?utf8=%E2%9C%93&snippets=&scope=&repository_ref=develop&search=util%3Alog&project_id=2055#L121)
* [ ] [post-install.xq ](https://gitlab.gwdg.de/search?utf8=%E2%9C%93&snippets=&scope=&repository_ref=develop&search=util%3Alog&project_id=2055#L128)
# Classification
Is this feature an enhancement of existing code or a completely new feature?
* [ ] enhancement
# Solution
Use instead:
```xquery
util:log($priority as xs:string, , $message as item
()*) as item()
Parameters:
$priority The logging priority: 'error', 'warn', 'debug', 'info', 'trace'
$message* The message to log
```
# Related Tickets
Add all related issues if applicable.
/cc @mgoebel, @hynek, @mrodzishttps://gitlab.gwdg.de/SADE/SADE/-/issues/113Faceted Search: Order mechanisms aren't working2019-12-04T13:19:19ZMichelle WeidlingFaceted Search: Order mechanisms aren't workingOn `search.html` we have to drop down menus that provide different sort options for the search results.
Switching them doesn't yield any result.On `search.html` we have to drop down menus that provide different sort options for the search results.
Switching them doesn't yield any result.https://gitlab.gwdg.de/SADE/SADE/-/issues/112upload fail->deployment fail2019-12-03T14:52:39ZStefan Hynekstefan.hynek@uni-goettingen.deupload fail->deployment fail# what is:
when uploading to the exist repo fails with an error message, e.g.:
```
<?xml version="1.0" ?><exception><path>/db/apps/receiver.xql</path><message>err:XPTY0004 cardinality error: sequence with more than one item is not allowe...# what is:
when uploading to the exist repo fails with an error message, e.g.:
```
<?xml version="1.0" ?><exception><path>/db/apps/receiver.xql</path><message>err:XPTY0004 cardinality error: sequence with more than one item is not allowed here [at line 42, column 68, source: /db/apps/public-repo/modules/scan.xql]
In function:
scanrepo:process(element()*) [203:23:/db/apps/public-repo/modules/scan.xql]
scanrepo:scan() [14:9:/db/apps/public-repo/modules/scan.xql]</message></exception>[cmd] sh exited 0
```
curl exits with 0 and deployment stage is considered passed
# what should be
pipeline should failhttps://gitlab.gwdg.de/SADE/SADE/-/issues/111Naming conventions2019-12-03T12:59:47ZMichelle WeidlingNaming conventionsWe have to talk about naming conventions (cf. xqDoc) and implement them. This should also be mentioned in CONTRIBUTING.md.We have to talk about naming conventions (cf. xqDoc) and implement them. This should also be mentioned in CONTRIBUTING.md.https://gitlab.gwdg.de/SADE/SADE/-/issues/110Generate function docs2020-05-04T09:17:48ZMichelle WeidlingGenerate function docsSince we annotate our functions with xqDoc we could provide the docs as HTML (Java style) as well. Could be done automatically by the CI.Since we annotate our functions with xqDoc we could provide the docs as HTML (Java style) as well. Could be done automatically by the CI.v5.0.0https://gitlab.gwdg.de/SADE/SADE/-/issues/108sorting search hits does not work2019-11-29T17:03:12ZMathias Goebelsorting search hits does not worksorting a list of search results is not possible. The dropdown selection has no effect.
![image](/uploads/7f30f422e530bd3b4fb86b582e08facb/image.png)sorting a list of search results is not possible. The dropdown selection has no effect.
![image](/uploads/7f30f422e530bd3b4fb86b582e08facb/image.png)https://gitlab.gwdg.de/SADE/SADE/-/issues/103Search: handling of facets are not intuitive2019-12-04T11:39:41ZMichelle WeidlingSearch: handling of facets are not intuitiveThe logic of applying and removing filters seems to be irritating: the plus sign should apply the filter, the minus sign should remove the filter, clicking the name should switch between the two; also, "apply all" and "remove all" should...The logic of applying and removing filters seems to be irritating: the plus sign should apply the filter, the minus sign should remove the filter, clicking the name should switch between the two; also, "apply all" and "remove all" should be provided (aka reset filters).
(Original post cf. https://gitlab.gwdg.de/SADE/SADE/merge_requests/76#note_104740)v5.1.0https://gitlab.gwdg.de/SADE/SADE/-/issues/101Search: sort order not functional2019-11-15T12:58:10ZUbbo VeentjerSearch: sort order not functionalthere are select boxes for the sort order in the search results view, but changing the selection triggers no action. this had been implemented with a javascript change listener in the past, may be it got lost?there are select boxes for the sort order in the search results view, but changing the selection triggers no action. this had been implemented with a javascript change listener in the past, may be it got lost?v5.0.0https://gitlab.gwdg.de/SADE/SADE/-/issues/99clean up build2019-12-03T14:14:45ZStefan Hynekstefan.hynek@uni-goettingen.declean up build- [ ] provide shell script build_local.sh
- [ ] rename test dir to local
- [ ] move all ant dependencies from .gitlab-ci.yml into shell scripts
- [ ] rename ant default build target to build
- [ ] add to build.xml:
> !!! The rule is, th...- [ ] provide shell script build_local.sh
- [ ] rename test dir to local
- [ ] move all ant dependencies from .gitlab-ci.yml into shell scripts
- [ ] rename ant default build target to build
- [ ] add to build.xml:
> !!! The rule is, the first line that sets a property wins. !!!
> The construct is usually used to include a file called build.properties.
> This is a convention used so that you can override default values for your local
> build environment, without having to modify build.xml (which may, after all,
> be a shared file, under version control). This means that build.properties
> should probably not be under version control (add it to .gitignore under git).
- [ ] redefine properties according to the aforesaid
- [ ] include generic SADE build.properties
- [ ] use setpermissions (ant v1.10+) for chmod +x bin/*.sh
- [ ] [rename default lucene config files](https://gitlab.gwdg.de/bibliothek-der-neologie/bdn-SADE/merge_requests/98/diffs#30a1c3274ec5e22b665bb9ad5cd8a32624b95440_95_95)
- [ ] use gitlab-ci variables to load build properties according to the branch the build is running on: [example](https://ant.apache.org/manual/Tasks/property.html)https://gitlab.gwdg.de/SADE/SADE/-/issues/97Check publish.html behaviour when item is added twice2019-11-06T11:36:24ZMathias GoebelCheck publish.html behaviour when item is added twicehttps://gitlab.gwdg.de/SADE/SADE/-/issues/96namespace naming conventions2019-10-16T08:51:31ZStefan Hynekstefan.hynek@uni-goettingen.denamespace naming conventionswhile working on exist 5 update I recognized, the http-client module was sometimes bound to the `http`, sometimes to the `httpclient`-namespace. there should be a namespace policy preventing the different naming of one and the same module.while working on exist 5 update I recognized, the http-client module was sometimes bound to the `http`, sometimes to the `httpclient`-namespace. there should be a namespace policy preventing the different naming of one and the same module.