Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
T
technical-reference
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
FE
technical-reference
Commits
862766e5
Verified
Commit
862766e5
authored
2 years ago
by
Ubbo Veentjer
Browse files
Options
Downloads
Patches
Plain Diff
fix(code-quality.md): sample workflow: step 5. belongs to 4
parent
e61a8728
No related branches found
Branches containing commit
No related tags found
Tags containing commit
1 merge request
!77
Resolve "Code Quality"
Pipeline
#296051
passed
2 years ago
Stage: build
Stage: test
Stage: compile
Changes
1
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
chapters/code-quality.md
+3
-3
3 additions, 3 deletions
chapters/code-quality.md
with
3 additions
and
3 deletions
chapters/code-quality.md
+
3
−
3
View file @
862766e5
...
...
@@ -20,14 +20,14 @@ by default. (This step matches the GitLab Flow.)
3.
The branch can be checked out locally, changes can be commited there. After some time the feature
(e.g. a new chapter or text change) is finished and should be merged into the main branch.
4.
Now the draft status of the MR is removed and everybody who should review the text is requested to do so.
5.
GitLab-CE allows to assign one person for reviewing the MR. This means that this
GitLab-CE allows to assign one person for reviewing the MR. This means that this
person has to approve the MR, otherwise the merge cannot commence. Other people relevant for the MR
can be "mentioned" in a comment, so they are notified by email of this MR. The developer should notify the
`MUST`
assignee personally (in case they don't notice the notification by GitLab).
6
.
The
`MUST`
assignee reviews the changes regarding style, understandability, grammar and spelling, etc.
5
.
The
`MUST`
assignee reviews the changes regarding style, understandability, grammar and spelling, etc.
If everything is to their liking, they approve the MR. The people mentionened in the comments are free to review
the changes as well.
7
.
The developer merges their changes into the main branch.
6
.
The developer merges their changes into the main branch.
### Code quality measurement with Gitlab-CI
...
...
This diff is collapsed.
Click to expand it.
Stefan Hynek
@hynek
mentioned in commit
2e4d841d
·
2 years ago
mentioned in commit
2e4d841d
mentioned in commit 2e4d841d09c7c977c6ce26712a53ef45ed579735
Toggle commit list
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment