Skip to content
Snippets Groups Projects
Verified Commit 862766e5 authored by Ubbo Veentjer's avatar Ubbo Veentjer
Browse files

fix(code-quality.md): sample workflow: step 5. belongs to 4

parent e61a8728
No related branches found
No related tags found
1 merge request!77Resolve "Code Quality"
Pipeline #296051 passed
......@@ -20,14 +20,14 @@ by default. (This step matches the GitLab Flow.)
3. The branch can be checked out locally, changes can be commited there. After some time the feature
(e.g. a new chapter or text change) is finished and should be merged into the main branch.
4. Now the draft status of the MR is removed and everybody who should review the text is requested to do so.
5. GitLab-CE allows to assign one person for reviewing the MR. This means that this
GitLab-CE allows to assign one person for reviewing the MR. This means that this
person has to approve the MR, otherwise the merge cannot commence. Other people relevant for the MR
can be "mentioned" in a comment, so they are notified by email of this MR. The developer should notify the `MUST`
assignee personally (in case they don't notice the notification by GitLab).
6. The `MUST` assignee reviews the changes regarding style, understandability, grammar and spelling, etc.
5. The `MUST` assignee reviews the changes regarding style, understandability, grammar and spelling, etc.
If everything is to their liking, they approve the MR. The people mentionened in the comments are free to review
the changes as well.
7. The developer merges their changes into the main branch.
6. The developer merges their changes into the main branch.
### Code quality measurement with Gitlab-CI
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment