SADE merge requestshttps://gitlab.gwdg.de/fontane-notizbuecher/SADE/-/merge_requests2019-08-16T11:49:59Zhttps://gitlab.gwdg.de/fontane-notizbuecher/SADE/-/merge_requests/46Add serialization for italics in Überblickskommentar2019-08-16T11:49:59ZMichelle WeidlingAdd serialization for italics in ÜberblickskommentarCloses #109.Closes #109.Michelle WeidlingMichelle Weidlinghttps://gitlab.gwdg.de/fontane-notizbuecher/SADE/-/merge_requests/47Consider elements when tidying HTML version of ET2019-08-16T13:08:38ZMichelle WeidlingConsider elements when tidying HTML version of ETCloses #110.Closes #110.Michelle WeidlingMichelle Weidlinghttps://gitlab.gwdg.de/fontane-notizbuecher/SADE/-/merge_requests/48Fix bug in highlighted zone2019-08-19T08:16:35ZMichelle WeidlingFix bug in highlighted zoneCloses #111.Closes #111.Michelle WeidlingMichelle Weidlinghttps://gitlab.gwdg.de/fontane-notizbuecher/SADE/-/merge_requests/49Fix #113.2019-08-23T09:38:39ZMichelle WeidlingFix #113.Michelle WeidlingMichelle Weidlinghttps://gitlab.gwdg.de/fontane-notizbuecher/SADE/-/merge_requests/50Closes #114.2019-09-06T06:49:46ZMichelle WeidlingCloses #114.Michelle WeidlingMichelle Weidlinghttps://gitlab.gwdg.de/fontane-notizbuecher/SADE/-/merge_requests/51add an API to test for available images for index data2019-10-10T10:35:37ZMathias Goebeladd an API to test for available images for index dataThis PR adds an API to query for images to an existing index entry and will return an array of URIs or an empty array.This PR adds an API to query for images to an existing index entry and will return an array of URIs or an empty array.Michelle WeidlingMichelle Weidlinghttps://gitlab.gwdg.de/fontane-notizbuecher/SADE/-/merge_requests/52Bugfix/failing tests2019-10-17T14:54:23ZMathias GoebelBugfix/failing testsclean up some test usage wildness and fixes #116 #117clean up some test usage wildness and fixes #116 #117Mathias GoebelMichelle WeidlingMathias Goebelhttps://gitlab.gwdg.de/fontane-notizbuecher/SADE/-/merge_requests/53refined xpath for “mentions”, closes #1192019-10-18T22:03:15ZMathias Goebelrefined xpath for “mentions”, closes #119…and also remove unused (old) functions…and also remove unused (old) functionsMathias GoebelMathias Goebelhttps://gitlab.gwdg.de/fontane-notizbuecher/SADE/-/merge_requests/54Feature/#121 index fontanes works in title2019-11-06T08:21:44ZMichelle WeidlingFeature/#121 index fontanes works in titleImplementiert eine Referenz auf den Personenregistereintrag "Fontane" bei den Werken Theodor Fontanes.
Closes #121.Implementiert eine Referenz auf den Personenregistereintrag "Fontane" bei den Werken Theodor Fontanes.
Closes #121.Michelle WeidlingMichelle Weidlinghttps://gitlab.gwdg.de/fontane-notizbuecher/SADE/-/merge_requests/55Closes #130, minor formatting2019-11-12T12:56:45ZMichelle WeidlingCloses #130, minor formattingSometimes in the index of literary sources ("Literaturverzeichnis") cases like these occur were we have a general bibliographic entry and two volumes belonging to it:
```xml
<bibl xmlns="http://www.tei-c.org/ns/1.0" xml:id="Varnhagen_18...Sometimes in the index of literary sources ("Literaturverzeichnis") cases like these occur were we have a general bibliographic entry and two volumes belonging to it:
```xml
<bibl xmlns="http://www.tei-c.org/ns/1.0" xml:id="Varnhagen_1836">
<choice>
<abbr>Varnhagen 1836</abbr>
<expan>Varnhagen von Ense, Karl August: Galerie von Bildnissen aus Rahel's Umgang und Briefwechsel. 2 Bände. Leipzig: Reichenbach 1836.</expan>
</choice>
<idno type="SWB" xml:base="http://swb.bsz-bw.de/DB=2.1/PRS=rdf/PPNSET?PPN=">028276094</idno>
<linkGrp targFunc="active passive">
<link corresp="http://bibframe.org/vocab/hasInstance" target="wrk:Varnhagen_Galerie_Werk #Varnhagen_1836"/>
</linkGrp>
<bibl xml:id="Varnhagen_1836_I">
<choice>
<abbr>Varnhagen 1836 I</abbr>
<expan>Varnhagen von Ense, Karl August: Galerie von Bildnissen aus Rahel's Umgang und Briefwechsel. Erster Theil. Leipzig: Reichenbach 1836.</expan>
</choice>
<idno type="URN" xml:base="http://nbn-resolving.de/urn/resolver.pl?urn=">urn:nbn:de:bvb:12-bsb10067589-4</idno>
<ptr type="fulltext" target="http://opacplus.bsb-muenchen.de/title/BV001166103/ft/bsb10067589?page=1"/>
<linkGrp targFunc="active passive"/>
</bibl>
<bibl xml:id="Varnhagen_1836_II">
<choice>
<abbr>Varnhagen 1836 II</abbr>
<expan>Varnhagen von Ense, Karl August: Galerie von Bildnissen aus Rahel's Umgang und Briefwechsel. Zweiter Theil. Leipzig: Reichenbach 1836.</expan>
</choice>
<idno type="URN" xml:base="http://nbn-resolving.de/urn/resolver.pl?urn=">urn:nbn:de:bvb:12-bsb10067590-2</idno>
<ptr type="fulltext" target="http://opacplus.bsb-muenchen.de/title/BV001166104/ft/bsb10067590?page=1"/>
<linkGrp targFunc="active passive"/>
</bibl>
</bibl>
```
Up until now this isn't considered and causes `ueberblickskommentar.xqm` to try to do string operations like `replace` on all descending `tei:abbr` which leads to the error
> It is a type error if, during the static analysis phase, an expression is found to have a static type that is not appropriate for the context in which the expression occurs, or during the dynamic evaluation phase, the dynamic type of a value does not match a required type as specified by the matching rules in 2.5.4 SequenceType Matching. Invalid cardinality for parameter $vp0. Expected zero or one, got 3.
This MR solves this issue (closes #130).Mathias GoebelMathias Goebelhttps://gitlab.gwdg.de/fontane-notizbuecher/SADE/-/merge_requests/56using a deep-equal to filter for distinct notes. would be better to prevent...2019-11-18T07:32:23ZMathias Goebelusing a deep-equal to filter for distinct notes. would be better to prevent...using a deep-equal to filter for distinct notes. would be better to prevent double preparation, closes #127using a deep-equal to filter for distinct notes. would be better to prevent double preparation, closes #127Michelle WeidlingMichelle Weidlinghttps://gitlab.gwdg.de/fontane-notizbuecher/SADE/-/merge_requests/59Add translation of tei:surface/@n2019-11-21T14:21:07ZMichelle WeidlingAdd translation of tei:surface/@nAdds a translation of tei:surface/@n in the index views to achieve a consistens German labeling.
Closes #125.Adds a translation of tei:surface/@n in the index views to achieve a consistens German labeling.
Closes #125.Mathias GoebelMathias Goebelhttps://gitlab.gwdg.de/fontane-notizbuecher/SADE/-/merge_requests/61remove test on caching, closes #1322019-11-21T14:54:56ZMathias Goebelremove test on caching, closes #132since the caching function is not in use currently, we remove the test that takes a long time to prepare a ~37mb file with 373k lines.since the caching function is not in use currently, we remove the test that takes a long time to prepare a ~37mb file with 373k lines.Michelle WeidlingMichelle Weidlinghttps://gitlab.gwdg.de/fontane-notizbuecher/SADE/-/merge_requests/60Commentary for sketches encompassing two pages2019-11-21T15:01:36ZMichelle WeidlingCommentary for sketches encompassing two pagesAter merging this MR editorial commentaries that refer two double sided sketches are displayed both on the left and the right page of the sketch.
Closes #123.Ater merging this MR editorial commentaries that refer two double sided sketches are displayed both on the left and the right page of the sketch.
Closes #123.Mathias GoebelMathias Goebelhttps://gitlab.gwdg.de/fontane-notizbuecher/SADE/-/merge_requests/58Implement entities in work index2019-11-29T11:46:19ZMichelle WeidlingImplement entities in work indexImplement entities in work index (closes #124), general formatting.
I'm not that happy about the fact that some code now has duplicates (`ixp:prepare-work` and `ixp:prepare-minified-work`) but I tried to make it as generic as possible.Implement entities in work index (closes #124), general formatting.
I'm not that happy about the fact that some code now has duplicates (`ixp:prepare-work` and `ixp:prepare-minified-work`) but I tried to make it as generic as possible.Michelle WeidlingMichelle Weidlinghttps://gitlab.gwdg.de/fontane-notizbuecher/SADE/-/merge_requests/57Bugfix/#131 multi volume reference2019-12-19T08:32:33ZMichelle WeidlingBugfix/#131 multi volume referenceThis MR fixes the index issue that occurs when there are works with several books belongin to them.
This doesn't seem to affect the edited text at all.
Closes #131.This MR fixes the index issue that occurs when there are works with several books belongin to them.
This doesn't seem to affect the edited text at all.
Closes #131.Mathias GoebelMathias Goebelhttps://gitlab.gwdg.de/fontane-notizbuecher/SADE/-/merge_requests/62Feature/#107 requirements et2019-12-19T08:37:11ZMichelle WeidlingFeature/#107 requirements etThis MR implements all the requirements that haven't been met yet for the edited text.
Closes #107.This MR implements all the requirements that haven't been met yet for the edited text.
Closes #107.Mathias GoebelMathias Goebelhttps://gitlab.gwdg.de/fontane-notizbuecher/SADE/-/merge_requests/64fix parser for index list for person in work index2020-01-06T14:09:37ZMathias Goebelfix parser for index list for person in work indexa index entry nested in a different index type, e.g. a (fictional) person listed in the index of works, the list name was not pared correctly.
this MR closes #134a index entry nested in a different index type, e.g. a (fictional) person listed in the index of works, the list name was not pared correctly.
this MR closes #134Michelle WeidlingMichelle Weidlinghttps://gitlab.gwdg.de/fontane-notizbuecher/SADE/-/merge_requests/63fix return for empty array2020-01-10T15:02:45ZMathias Goebelfix return for empty arraythis function is enabled for queries larger than one character. this MR sets the correct return (empty array) if a single char is given.
closes #135this function is enabled for queries larger than one character. this MR sets the correct return (empty array) if a single char is given.
closes #135Mathias GoebelMichelle WeidlingMathias Goebelhttps://gitlab.gwdg.de/fontane-notizbuecher/SADE/-/merge_requests/66Fixes bug in tei:line processing, adds fictional places (closes #140)2020-05-08T08:23:56ZMichelle WeidlingFixes bug in tei:line processing, adds fictional places (closes #140)Adds a missing feature, displaying fictional places, for the print serialization of the indices.
Also there was a curious bug I cannot explain, cf. https://gitlab.gwdg.de/fontane-notizbuecher/SADE/-/commit/f842e8e0d2f164d800900f74991e...Adds a missing feature, displaying fictional places, for the print serialization of the indices.
Also there was a curious bug I cannot explain, cf. https://gitlab.gwdg.de/fontane-notizbuecher/SADE/-/commit/f842e8e0d2f164d800900f74991e6e37f4dce7f5#note_144194. In case there are better solutions for this problem I'd be happy to have them.Mathias GoebelMathias Goebel