diff --git a/core/tests/test_student_reviewer_viewset.py b/core/tests/test_student_reviewer_viewset.py index ffbdac9daf21f021598eb6beb1f1260f70cb166c..b351f8661821d7d99cbc8c0fbfaa69c9772ff723 100644 --- a/core/tests/test_student_reviewer_viewset.py +++ b/core/tests/test_student_reviewer_viewset.py @@ -93,10 +93,10 @@ class StudentPageTests(APITestCase): self.assertEqual(3, len(self.rev_response.data)) @override_config(EXERCISE_MODE=True) - def test_tutor_can_only_see_students_when_in_exercise_mode(self): + def test_tutor_can_only_see_group_members_when_in_exercise_mode(self): force_authenticate(self.request, user=self.tutor) response = self.view(self.request) - self.assertEqual(3, len(response.data)) + self.assertEqual(2, len(response.data)) def test_submissions_score_is_included(self): res_with_sub = None diff --git a/core/views/common_views.py b/core/views/common_views.py index 324d3350d48f91cdf5ec0136f021b8239ec3ae34..ad6318b1560491b7fca9424b7d29c5bd590cc1ab 100644 --- a/core/views/common_views.py +++ b/core/views/common_views.py @@ -82,7 +82,10 @@ class StudentReviewerApiViewSet(viewsets.ReadOnlyModelViewSet): return queryset elif self.request.user.is_tutor() and config.EXERCISE_MODE: - return queryset + return queryset.filter( + user__exercise_groups__in=self.request.user.exercise_groups.all() + ) + else: return []