Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
grady
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Jan Maximilian Michal
grady
Merge requests
!139
Quick fix for validation problem
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Quick fix for validation problem
quick-fix
into
master
Overview
0
Commits
1
Pipelines
1
Changes
2
Merged
robinwilliam.hundt
requested to merge
quick-fix
into
master
6 years ago
Overview
0
Commits
1
Pipelines
1
Changes
2
Expand
0
0
Merge request reports
Viewing commit
49c457e6
Show latest version
2 files
+
2
−
2
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
Files
2
Search (e.g. *.vue) (Ctrl+P)
49c457e6
Quick fix for validation problem
· 49c457e6
robinwilliam.hundt
authored
6 years ago
frontend/src/store/modules/submission-notes.ts
+
1
−
1
Options
@@ -147,7 +147,7 @@ async function submitFeedback ({ state }: BareActionContext<SubmissionNotesState
if
(
Object
.
keys
(
state
.
updatedFeedback
.
feedbackLines
||
{}).
length
>
0
)
{
feedback
.
feedbackLines
=
state
.
updatedFeedback
.
feedbackLines
}
else
if
(
feedback
.
score
!
<
SubmissionNotes
.
submissionType
.
fullScore
!
)
{
}
else
if
(
feedback
.
score
!
<
SubmissionNotes
.
submissionType
.
fullScore
!
&&
!
state
.
hasOrigFeedback
)
{
throw
new
Error
(
'
You need to add or change a comment when setting a non full score.
'
)
}
// delete those comments that have been marked for deletion
Loading