Skip to content
Snippets Groups Projects

Resolve "Changing feedback that a reviewer worken on is forbidden after set to final"

All threads resolved!
@@ -121,7 +121,7 @@ class FeedbackSerializer(DynamicFieldsModelSerializer):
submission = validated_data.pop('of_submission')
feedback_lines = validated_data.pop('feedback_lines', [])
labels = validated_data.pop('labels', [])
user = UserAccount.objects.get(username=str(self.context['request'].user))
user = self.context['request'].user
feedback = Feedback.objects.create(of_submission=submission,
**validated_data)
if user.role == UserAccount.REVIEWER:
@@ -145,7 +145,7 @@ class FeedbackSerializer(DynamicFieldsModelSerializer):
@transaction.atomic
def update(self, feedback, validated_data):
user = UserAccount.objects.get(username=str(self.context['request'].user))
user = self.context['request'].user
if user.role == UserAccount.REVIEWER:
feedback.final_by_reviewer = self.context['request'].data['is_final']
Loading