From 39c681491501be494d3aef14d22e537eb0712538 Mon Sep 17 00:00:00 2001
From: Arsenij Ustjanzew <Arsenij.Ustjanzew@mpi-bn.mpg.de>
Date: Thu, 22 Oct 2020 09:23:06 +0200
Subject: [PATCH] changes for CRAN resubmission
---
DESCRIPTION | 6 +++---
cran-comments.md | 8 ++++++++
vignettes/i2dash-intro.Rmd | 6 +++---
3 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/DESCRIPTION b/DESCRIPTION
index 94c41e0..138e08c 100644
--- a/DESCRIPTION
+++ b/DESCRIPTION
@@ -1,16 +1,16 @@
Package: i2dash
Type: Package
Title: Iterative and Interactive Dashboards
-Version: 0.2.1
+Version: 0.2.2
Authors@R: c(
- person(given = "Arsenij", family = "Ustjanzew", email = "arsenij.ustjanzew@mpi-bn.mpg.de", role = c("aut", "cre", "cph")),
+ person(given = "Arsenij", family = "Ustjanzew", email = "arsenij.ustjanzew@gmail.com", role = c("aut", "cre", "cph"), comment = c(ORCID = "0000-0002-1014-4521")),
person(given = "Jens", family = "Preussner", email = "jens.preussner@mpi-bn.mpg.de", role = c("aut", "cph"), comment = c(ORCID = "0000-0003-1927-3458")),
person(given = "Mario", family = "Looso", email = "mario.looso@mpi-bn.mpg.de", role = c("aut", "cph"), comment = c(ORCID = "0000-0003-1495-9530")))
Description: Create customized, web-based dashboards for data presentation, exploration and sharing. 'i2dash' integrates easily into existing data analysis pipelines and can organize scientific findings thematically across different pages and layouts.
License: MIT + file LICENSE
Encoding: UTF-8
LazyData: true
-RoxygenNote: 7.0.2
+RoxygenNote: 7.1.1
VignetteBuilder: knitr
Imports:
magrittr,
diff --git a/cran-comments.md b/cran-comments.md
index 8e354c1..666cedd 100644
--- a/cran-comments.md
+++ b/cran-comments.md
@@ -1,3 +1,11 @@
+## 6th resubmission
+
+This is the sixth resubmission. In this version, we have:
+
+* Changed the function '.create_page_name()' so it does not give the NOTE for return without ().
+* Changed the email adress of the maintainer Arsenij Ustjanzewdue to change of employment.
+* Changed URLs in vignette from http to https
+
## 5th resubmission
This is the fifth resubmission. In this version, we have:
diff --git a/vignettes/i2dash-intro.Rmd b/vignettes/i2dash-intro.Rmd
index 54407d9..b554d10 100644
--- a/vignettes/i2dash-intro.Rmd
+++ b/vignettes/i2dash-intro.Rmd
@@ -45,7 +45,7 @@ library(magrittr)
# Introduction and scope
-Scientific communication and data visualization are important aspects to illustrate complex concepts and results from data analyses. [R Markdown](https://rmarkdown.rstudio.com) enables weaving together narrative text and code into rich and reproducible documents, that can also run interactive widgets from [R Shiny](http://shiny.rstudio.com/).
+Scientific communication and data visualization are important aspects to illustrate complex concepts and results from data analyses. [R Markdown](https://rmarkdown.rstudio.com) enables weaving together narrative text and code into rich and reproducible documents, that can also run interactive widgets from [R Shiny](https://shiny.rstudio.com/).
R Studio's [Flexdashboard](https://rmarkdown.rstudio.com/flexdashboard/) introduces dashboards to publish a group of related data visualizations, tables, images and narrative text in row and column-based layouts. Both, R Markdown and R Studio's Flexdashboard require authors to manually create Markdown documents and assemble content at the right position in the file.
The R package i2dash provides classes and functionality to programatically create customized, web-based flexdashboards for data presentation, exploration and sharing. Dashboard content is organised in so-called **components** and can be added iteratively to the dashboard, *i.e.* as data or visualizations become available along the analysis pipeline. Components are reusable and can be distributed across different dashboard **pages** to organize scientific findings thematically. Ultimately, i2dash enables xxx and therefore integrates well into existing data analysis pipelines.
@@ -146,7 +146,7 @@ dashboard %<>%
## Adding content
-Content can be added to pages using **components**. A component can be a R object itself (*e.g.* a widget from [htmwlwidgets](http://gallery.htmlwidgets.org/)), a file path (*e.g.* to a markdown or image file) or a function that can be called to generate content. We'll use the `add_component` function to explore several options and fill `page1` iteratively with three R objects:
+Content can be added to pages using **components**. A component can be a R object itself (*e.g.* a widget from [htmwlwidgets](https://gallery.htmlwidgets.org/)), a file path (*e.g.* to a markdown or image file) or a function that can be called to generate content. We'll use the `add_component` function to explore several options and fill `page1` iteratively with three R objects:
```{r, eval=TRUE}
library(leaflet)
@@ -296,7 +296,7 @@ Lets assume we have an experimental factor called year:
year <- factor(c(2014, 2014, 2015, 2017, 2019, 2019), levels = c(2014:2021))
```
-To assign each level a color from the [sequential greens](http://colorbrewer2.org/#type=sequential&scheme=BuGn&n=9) palette from the `r BiocStyle::CRANpkg("RColorBrewer")` package, we create a character vector with the colors and assign the levels as names.
+To assign each level a color from the [sequential greens](https://colorbrewer2.org/) palette from the `r BiocStyle::CRANpkg("RColorBrewer")` package, we create a character vector with the colors and assign the levels as names.
```{r, eval = FALSE}
colors <- RColorBrewer::brewer.pal(8, "BuGn")
--
GitLab