From 07ffb8b70ca10192988b1ee2b537bbe902cd8f3a Mon Sep 17 00:00:00 2001
From: iamashwin99 <ashwin-kumar.karnad@mpsd.mpg.de>
Date: Tue, 6 Jun 2023 11:16:21 +0200
Subject: [PATCH] update tests
---
mpsd-software-environment.py | 2 +-
tests.py | 7 ++++++-
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/mpsd-software-environment.py b/mpsd-software-environment.py
index 18fc9ef..c738ac1 100755
--- a/mpsd-software-environment.py
+++ b/mpsd-software-environment.py
@@ -91,7 +91,7 @@ def read_metadata_from_logfile(logfile: Union[str, Path]) -> dict:
}
-def set_up_logging(loglevel="warning", filename=None):
+def set_up_logging(loglevel="warning", filename='gol.log'):
"""Set up logging.
This function sets up the logging configuration for the script.
diff --git a/tests.py b/tests.py
index 9af04be..0e59d03 100644
--- a/tests.py
+++ b/tests.py
@@ -316,13 +316,18 @@ def test_install_environment_zlib():
assert "zlib" in lines
def test_metadata_logging(tmp_path):
- mod.set_up_logging("WARNING", tmp_path/"test-metadata.log")
+ """Test that metadata is logged and read correctly."""
+ # Test that the metadata is logged correctly
+ mod.set_up_logging(loglevel="debug", filename=tmp_path/"test-metadata.log")
key = "important_key"
value = "important_value"
mod.log_metadata(key,value)
expected_log = f"{mod.config_vars['metadata_tag_open']}{key}:{value}{mod.config_vars['metadata_tag_close']}"
with open(tmp_path/"test-metadata.log", "r") as f:
assert expected_log in f.read()
+ # Test that the metadata is read correctly
+ read_dict = mod.read_metadata_from_logfile(tmp_path/"test-metadata.log")
+ assert read_dict[key] == value
def test_interface(tmp_path):
"""Test other things (not implemented yet)."""
--
GitLab