From 305d717cacc53c1226e71a835734d7715dedfabf Mon Sep 17 00:00:00 2001 From: iamashwin99 <ashwin-kumar.karnad@mpsd.mpg.de> Date: Sun, 17 Dec 2023 22:53:41 +0100 Subject: [PATCH] Fix package_sets condition in install_environment function --- .test/23c/spack-environments | 1 + src/mpsd_software_manager/cmds/install.py | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) create mode 160000 .test/23c/spack-environments diff --git a/.test/23c/spack-environments b/.test/23c/spack-environments new file mode 160000 index 0000000..4429e66 --- /dev/null +++ b/.test/23c/spack-environments @@ -0,0 +1 @@ +Subproject commit 4429e6640f2d1460dd5ea88c517dea484825afd0 diff --git a/src/mpsd_software_manager/cmds/install.py b/src/mpsd_software_manager/cmds/install.py index 5dc588d..9ff6c09 100644 --- a/src/mpsd_software_manager/cmds/install.py +++ b/src/mpsd_software_manager/cmds/install.py @@ -64,9 +64,10 @@ def install_environment( # run the prepare_environment function available_package_sets = prepare_environment(mpsd_release, root_dir) # Ensure that the requested package_sets are available in the release - if package_sets == "ALL": + if package_sets == ["ALL"]: package_sets = available_package_sets elif package_sets == "NONE": + # TODO: This if case is never reached, because of new argparse logic. Remove it. # No package_sets requested, so we only create the env and print the # list of available package_sets logging.warning( -- GitLab