From 464b60e18e55c9630a2ac5c4869b5ce439afc6b3 Mon Sep 17 00:00:00 2001
From: iamashwin99 <ashwin-kumar.karnad@mpsd.mpg.de>
Date: Tue, 6 Jun 2023 12:03:35 +0200
Subject: [PATCH] breakdown the line to allow for char lim
---
mpsd-software-environment.py | 2 +-
tests.py | 16 +++++++++-------
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/mpsd-software-environment.py b/mpsd-software-environment.py
index c738ac1..fb6d6b1 100755
--- a/mpsd-software-environment.py
+++ b/mpsd-software-environment.py
@@ -91,7 +91,7 @@ def read_metadata_from_logfile(logfile: Union[str, Path]) -> dict:
}
-def set_up_logging(loglevel="warning", filename='gol.log'):
+def set_up_logging(loglevel="warning", filename="gol.log"):
"""Set up logging.
This function sets up the logging configuration for the script.
diff --git a/tests.py b/tests.py
index 0e59d03..d440fd3 100644
--- a/tests.py
+++ b/tests.py
@@ -1,14 +1,12 @@
"""Tests for mpsd-software-environment.py."""
import importlib
-import logging
import os
import shutil
import subprocess
from pathlib import Path
import pytest
-import logging
mod = importlib.import_module("mpsd-software-environment")
@@ -315,20 +313,24 @@ def test_install_environment_zlib():
lines = f.read()
assert "zlib" in lines
+
def test_metadata_logging(tmp_path):
"""Test that metadata is logged and read correctly."""
# Test that the metadata is logged correctly
- mod.set_up_logging(loglevel="debug", filename=tmp_path/"test-metadata.log")
+ mod.set_up_logging(loglevel="debug", filename=tmp_path / "test-metadata.log")
key = "important_key"
value = "important_value"
- mod.log_metadata(key,value)
- expected_log = f"{mod.config_vars['metadata_tag_open']}{key}:{value}{mod.config_vars['metadata_tag_close']}"
- with open(tmp_path/"test-metadata.log", "r") as f:
+ mod.log_metadata(key, value)
+ open_tag = mod.config_vars["metadata_tag_open"]
+ close_tag = mod.config_vars["metadata_tag_close"]
+ expected_log = f"{open_tag}{key}:{value}{close_tag}"
+ with open(tmp_path / "test-metadata.log", "r") as f:
assert expected_log in f.read()
# Test that the metadata is read correctly
- read_dict = mod.read_metadata_from_logfile(tmp_path/"test-metadata.log")
+ read_dict = mod.read_metadata_from_logfile(tmp_path / "test-metadata.log")
assert read_dict[key] == value
+
def test_interface(tmp_path):
"""Test other things (not implemented yet)."""
pass
--
GitLab