Suggestions to MR 29

  • conform to uniform variable naming
    • use path instead of file when referring to file path
    • setup_log_cmd is a misleading name. rename it to record_top_level_command
  • installer log names as dev-23a_cascadelake_2023-06-07T17:37:51_Apex_install.log to keep this file at the top of ls
  • 2023-06-07T16-51-11 format for the date to avoid :
  • split create_log_file_names into one function for the installer_log and one for build_log
  • top level log file (install.log) should point to script-log file in dev-23a/logs
  • rename top level log file from install.log to script_execution_summary.log