Suggestions to MR 29
- conform to uniform variable naming
- use
pathinstead offilewhen referring to file path -
setup_log_cmdis a misleading name. rename it torecord_top_level_command
- use
- installer log names as
dev-23a_cascadelake_2023-06-07T17:37:51_Apex_install.logto keep this file at the top of ls - 2023-06-07T16-51-11 format for the date to avoid
: - split
create_log_file_namesinto one function for theinstaller_logand one forbuild_log - top level log file (
install.log) should point to script-log file indev-23a/logs - rename top level log file from
install.logtoscript_execution_summary.log