diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 6962295af4e0e6e080dc41b027cf22a732ab6bd4..1a9b2ed1c7d5e022b904da25f1f032a72d9bd0c2 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -16,6 +16,11 @@ Please See the [releases tab](https://github.com/openedx/xblock-lti-consumer/rel Unreleased ~~~~~~~~~~ +8.0.1 - 2023-02-03 +------------------ +* This releases fixes the PII sharing consent dialog for inline launches to no longer refer to a nonexistent + "Cancel" button. + 8.0.0 - 2023-01-31 ------------------ * Update to work with bleachk>=6.0.0 and make that an explicit requirement in diff --git a/lti_consumer/__init__.py b/lti_consumer/__init__.py index 2ac31ca97338b4f41a3816e1fd4974378d1492c8..4926ee88ee0e88dd8c64641cd47e1715caf023dd 100644 --- a/lti_consumer/__init__.py +++ b/lti_consumer/__init__.py @@ -4,4 +4,4 @@ Runtime will load the XBlock class from here. from .apps import LTIConsumerApp from .lti_xblock import LtiConsumerXBlock -__version__ = '8.0.0' +__version__ = '8.0.1' diff --git a/lti_consumer/static/js/xblock_lti_consumer.js b/lti_consumer/static/js/xblock_lti_consumer.js index 05fa539202d4968406ae7cf8d746db1da0ef71dd..22db13eed3d93bc24afca9109dd27c401b32fad8 100644 --- a/lti_consumer/static/js/xblock_lti_consumer.js +++ b/lti_consumer/static/js/xblock_lti_consumer.js @@ -154,15 +154,21 @@ function LtiConsumerXBlock(runtime, element) { function renderPIIConsentPromptIfRequired(onSuccess, showCancelButton=true) { if (askToSendUsername && askToSendEmail) { - msg = gettext("Click OK to have your username and e-mail address sent to a 3rd party application.\n\nClick Cancel to return to this page without sending your information."); + msg = "Click OK to have your username and e-mail address sent to a 3rd party application."; } else if (askToSendUsername) { - msg = gettext("Click OK to have your username sent to a 3rd party application.\n\nClick Cancel to return to this page without sending your information."); + msg = "Click OK to have your username sent to a 3rd party application."; } else if (askToSendEmail) { - msg = gettext("Click OK to have your e-mail address sent to a 3rd party application.\n\nClick Cancel to return to this page without sending your information."); + msg = "Click OK to have your e-mail address sent to a 3rd party application."; } else { onSuccess("OK"); return; } + + if (showCancelButton) { + msg += "\n\nClick Cancel to return to this page without sending your information."; + } + + msg = gettext(msg); $.when(confirmDialog(msg, $(this), showCancelButton)).then(onSuccess); }