From cb8e68745786e728ba19d8bfd4e0d6d79ca406f1 Mon Sep 17 00:00:00 2001
From: stvn <stvn@mit.edu>
Date: Mon, 9 Aug 2021 17:51:43 -0700
Subject: [PATCH] style(pylint): remove superfluous pylint: disable directives
---
lti_consumer/models.py | 8 ++++----
lti_consumer/tests/unit/plugin/test_views_lti_ags.py | 3 +--
lti_consumer/tests/unit/plugin/test_views_lti_nrps.py | 1 -
3 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/lti_consumer/models.py b/lti_consumer/models.py
index 92e9701..3bde1ff 100644
--- a/lti_consumer/models.py
+++ b/lti_consumer/models.py
@@ -332,19 +332,19 @@ class LtiConfiguration(models.Model):
@property
def pii_share_username(self):
- return self.lti_config.get('pii_share_username', False) # pylint: disable=no-member
+ return self.lti_config.get('pii_share_username', False)
@pii_share_username.setter
def pii_share_username(self, value):
- self.lti_config['pii_share_username'] = value # pylint: disable=unsupported-assignment-operation
+ self.lti_config['pii_share_username'] = value
@property
def pii_share_email(self):
- return self.lti_config.get('pii_share_email', False) # pylint: disable=no-member
+ return self.lti_config.get('pii_share_email', False)
@pii_share_email.setter
def pii_share_email(self, value):
- self.lti_config['pii_share_email'] = value # pylint: disable=unsupported-assignment-operation
+ self.lti_config['pii_share_email'] = value
def __str__(self):
return f"[{self.config_store}] {self.version} - {self.location}"
diff --git a/lti_consumer/tests/unit/plugin/test_views_lti_ags.py b/lti_consumer/tests/unit/plugin/test_views_lti_ags.py
index cff1caf..085816b 100644
--- a/lti_consumer/tests/unit/plugin/test_views_lti_ags.py
+++ b/lti_consumer/tests/unit/plugin/test_views_lti_ags.py
@@ -88,7 +88,6 @@ class LtiAgsLineItemViewSetTestCase(APITransactionTestCase):
"iss": "https://example.com",
"scopes": scopes,
})
- # pylint: disable=no-member
self.client.credentials(
HTTP_AUTHORIZATION=f"Bearer {token}"
)
@@ -123,7 +122,7 @@ class LtiAgsViewSetTokenTests(LtiAgsLineItemViewSetTestCase):
"""
Test the LTI AGS list view when there's an invalid token.
"""
- self.client.credentials(HTTP_AUTHORIZATION=authorization) # pylint: disable=no-member
+ self.client.credentials(HTTP_AUTHORIZATION=authorization)
response = self.client.get(self.lineitem_endpoint)
self.assertEqual(response.status_code, 403)
diff --git a/lti_consumer/tests/unit/plugin/test_views_lti_nrps.py b/lti_consumer/tests/unit/plugin/test_views_lti_nrps.py
index 6b13c91..a5cb827 100644
--- a/lti_consumer/tests/unit/plugin/test_views_lti_nrps.py
+++ b/lti_consumer/tests/unit/plugin/test_views_lti_nrps.py
@@ -181,7 +181,6 @@ class LtiNrpsTestCase(APITransactionTestCase):
"iss": "https://example.com",
"scopes": scopes,
})
- # pylint: disable=no-member
self.client.credentials(
HTTP_AUTHORIZATION="Bearer {}".format(token)
)
--
GitLab