remove IP address magic strings
The README.md says to insert the host IP address as a magic string in multiple files (it actually recommends sed
which really shows how much this got out of hand). .env
already defines ${E_APP_BASE_URL}
so should be a good place to define the strings once.
Definiton of Done:
-
define IP address in .env
-
substitute variable in all relevant files (maybe need to create mechanism) -
test -
write documentation -
announce to everyone who is currently running it with the magic strings
Hints:
- occurences of the magic string:
./conf/xnat.sql
./conf/keycloak.sql
./.env
./conf-tpl/xnat.sql.tpl