sshoc-marketplace-frontend issueshttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues2022-04-13T07:07:36Zhttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/106edit steps of workflows saved as draft2022-04-13T07:07:36ZLaure Barbotedit steps of workflows saved as draft# π Bug Report
when creating a workflow and its steps, and saving as draft the whole thing, there is a problem to re-access and edit the steps.
## π€ Expected Behavior
If I access a workflow from "my draft items" and want to edit step...# π Bug Report
when creating a workflow and its steps, and saving as draft the whole thing, there is a problem to re-access and edit the steps.
## π€ Expected Behavior
If I access a workflow from "my draft items" and want to edit steps before submitting the workflow to moderation or publishing it, the "edit" button is not clickable
## π― Current Behavior
the edit button on the screen below doesn't "answer"
![image](/uploads/9652bb381e14088d0845d716072912e9/image.png)
## π§ How to reproduce
<!--- Please provide directions how the issue can be reproduced. -->
1. create a workflow
2. create a step
3. save as draft
4. access the workflow from "my draft items"
5. go to workflow steps page
6. click on "edit" step
---
notify @klaus.illmayer @edward.gray @matej.durcoNow or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/88sort actor and concept combobox values alphabetically2022-10-27T11:13:37ZMatej Durcosort actor and concept combobox values alphabeticallyCurrently with a longer vocabulary, user in edit form has to know what to start typing to get a suggestions.
There has to be a way to see full list of vocabularies
- in minimal case (vocabulary specific) link to https://vocabs.sshopenclo...Currently with a longer vocabulary, user in edit form has to know what to start typing to get a suggestions.
There has to be a way to see full list of vocabularies
- in minimal case (vocabulary specific) link to https://vocabs.sshopencloud.eu/vocabularies/en/ (or whatever they are published, e.g. TaDiRAH in https://vocabs.dariah.eu/tadirah/en/)
- or some listing of the whole vocabulary as listed by the API.
Ideas how to implement?
(notify: @klaus.illmayer , @lbarbot @matej.durcoNow or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/79Draft items are not editable2021-10-15T14:06:19ZKlaus IllmayerDraft items are not editable# π Bug Report
Creating a new item and saving it as draft. When later on editing this draft item again on "My account"=>"My draft items"=>"Edit" it will give a "page not found". In the console it says "404 Not Found" for https://sshoc-m...# π Bug Report
Creating a new item and saving it as draft. When later on editing this draft item again on "My account"=>"My draft items"=>"Edit" it will give a "page not found". In the console it says "404 Not Found" for https://sshoc-marketplace.acdh-dev.oeaw.ac.at/workflow/[persistentId]/edit/draft
Additionally, I have one example (a draft only with a title and a description) where in the "My draft items" next to the title of the draft item there are brackets without a content: `Test Statuses ()`. I'm not sure what is creating these brackets, I didn't enter them (maybe the field version?).
And a last one: If in "My draft items" you don't click on "Edit" but on the title of the draft item, you will see the detail view of this item without an "Edit"-button but with an "History"-button. When clicking on this history button you run into an infinite wheel animation.
## π€ Expected Behavior
I like to edit my draft and see the edit forms.
I don't want brackets without content next to the title of my draft item.
I like to see the history of the draft item.
## π― Current Behavior
I can't edit my draft.
I see brackets without content next ot the title of my draft item in the "My draft items"-list.
I don't see a history but instead an infinite wheel animation.
---Curation module implementedStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/55Unwanted logout if looking into an item in the history2021-07-02T07:43:24ZKlaus IllmayerUnwanted logout if looking into an item in the history# π Bug Report
After logging in via EOSC AAI (being a contributor) and going to the [EMM item](https://sshoc-marketplace.acdh-dev.oeaw.ac.at/tool-or-service/wDDeLu) that Laure created and that was approved by Administrator, I'm able to ...# π Bug Report
After logging in via EOSC AAI (being a contributor) and going to the [EMM item](https://sshoc-marketplace.acdh-dev.oeaw.ac.at/tool-or-service/wDDeLu) that Laure created and that was approved by Administrator, I'm able to have a look at the "history" where I see some older versions of the item. The current one has an "Edit" link, the others doesn't but you can click on the title of one of the others and if you do so, it works some seconds and will then give you the error message "Failed to fetch tool" and it logs you out. You end in the login window and you need to login once again.
## π€ Expected Behavior
If it is not possible for me to see an older version of an item, there should be no link to this item.
If I click on an item where I don't have a permission, I like to see an error message only about this fact.
## π― Current Behavior
You are not aware that you don't have the permission to see an older version of an item.
You are logged out of the MP after you click on an item where you don't have an access permission .
The error "Failed to fetch tool" doesn't give you the correct information, that you don't have the permission.
---Curation module implementedStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/52display related items2021-09-03T12:23:32ZLaure Barbotdisplay related items# π Bug Report
<!--- Please provide a general summary of the issue. --> in the 4 items created today, it seems that the related items part of the detail item view is not displayed. Any idea why?
## π€ Expected Behavior
<!--- Tell us w...# π Bug Report
<!--- Please provide a general summary of the issue. --> in the 4 items created today, it seems that the related items part of the detail item view is not displayed. Any idea why?
## π€ Expected Behavior
<!--- Tell us what should happen. --> if a related item is added via the edit form, it should be displayed in both (?) items linked.
## π― Current Behavior
<!--- Tell us what happens instead of the expected behavior. --> the item created - example: https://sshoc-marketplace.acdh-dev.oeaw.ac.at/training-material/UZGTCS doesn't include the related items box linking, in this case with https://sshoc-marketplace.acdh-dev.oeaw.ac.at/tool-or-service/wDDeLu
<!--- If you are seeing an error, please include the full error message. -->
---Curation module implementedKlaus IllmayerStefan ProbstKlaus Illmayerhttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/46save as a draft2021-03-17T12:59:34ZLaure Barbotsave as a draft# π Bug Report
<!--- Please provide a general summary of the issue. --> when clicking on "save as draft" on the create a tool page, the item seems suggested/submitted
## π€ Expected Behavior
<!--- Tell us what should happen. --> "save...# π Bug Report
<!--- Please provide a general summary of the issue. --> when clicking on "save as draft" on the create a tool page, the item seems suggested/submitted
## π€ Expected Behavior
<!--- Tell us what should happen. --> "save as draft" should save the content already filled in the form, but not submit the item
## π― Current Behavior
<!--- Tell us what happens instead of the expected behavior. --> when I click "save as draft" I end up with a "validation" page saying something like, "thanks for submission, a moderator will now check your suggestion..."
<!--- If you are seeing an error, please include the full error message. -->
---Curation module implementedStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/136Saving a draft with externalId as a draft gives 5002022-12-05T17:02:45ZKlaus IllmayerSaving a draft with externalId as a draft gives 500# π Bug Report
Creating a draft item having an externalId and then again saving it as a draft gives a 500 error, when doing this in the frontend.
## π€ Expected Behavior
No 500 error, item should be saved again as a draft.
## π― Curren...# π Bug Report
Creating a draft item having an externalId and then again saving it as a draft gives a 500 error, when doing this in the frontend.
## π€ Expected Behavior
No 500 error, item should be saved again as a draft.
## π― Current Behavior
It gives a 500 error ```could not execute statement; SQL [n/a]; constraint [item_external_ids_identifier_service_code_identifier_item_i_key]; nested exception is org.hibernate.exception.ConstraintViolationException: could not execute statement```.
## π§ How to reproduce
(does only create a 500 when doing this on GUI)
1. Login
2. Create a new item, e.g. a tool
3. Enter a title, a description and an externalId, e.g. `Id service` "Wikidata" and `Identifier` "1234"
4. Save as draft
5. You will get a green successfully saved message and you stay in the edit form, now again "Save as draft" (you do not need to change anything)
6. You will get a "500 - Internal Server Error"
## Observations
It seems, that we have an issue here that concerns frontend as well as backend. If trying to reproduce the issue without frontend and using only API calls, it works as expected and don't give a 500. Therefore I looked into the calls that frontend creates and I see a difference, that also leads in the API calls to an error: When saving it the second time as a draft, I would call in the API (assuming `fNCigV` as the persistentId) `PUT /api/tools-services/fNCigV?draft=true` (that's the way that does not inflicts a 500 error) but the frontend calls `PUT /api/tools-services/fNCigV?persistentId=fNCigV&draft=true` and this prodcues a 500 error. I don't know, why frontend adds the parameter `persistentId=fNCigV` and I don't know, what backend does with this additional parameter (it is not documented in Swagger, I can only assume, that it tries to do something like a merge, as the mentioned error in the current behavior section is connected to the sql-error
```
DETAIL: Key (identifier_service_code, identifier, item_id)=(Wikidata, 1234, 48697) already exists.
STATEMENT: insert into item_external_ids (identifier, identifier_service_code, item_id, id) values ($1, $2, $3, $4)
```
Adding @stefan.probst for frontend, @tparkola for backend (what do you think, does it also sound like a backend error and should we create a dedicated issue?) and @lbarbot for reporting the error.
---Stefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/130workflow and steps submission2022-11-16T19:29:41ZLaure Barbotworkflow and steps submissionwhen creating a workflow and its steps and saving/submitted them, it creates as many workflow entries in the list of draft items, contributed items or moderation queue, as the number of versions created during the workflow creation proce...when creating a workflow and its steps and saving/submitted them, it creates as many workflow entries in the list of draft items, contributed items or moderation queue, as the number of versions created during the workflow creation process.
In other words, if a contributor creates a workflow and two steps, save as draft, they will see 4 times the workflow entry in the "my draft items" screen.
The same happens when the workflow is submitted, and re-accessed by the contributor from the "my contributed item" screen or seen by the moderator from "items to moderate" screen.
Example below form the "my contributed items" screen for a workflow with two steps (only submitted once):
![image](/uploads/d38d2f553b0e321748373676dc73bcba/image.png)
also notify @klaus.illmayer @matej.durcoStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/129preview workflow - bug2022-11-16T19:07:41ZLaure Barbotpreview workflow - bugwhen creating a workflow and its steps and saving or submitting it, the preview mode does not allow users to see the steps, but only the workflow.
- if the workflow and its steps are saved as draft and a contributor accesses the workflo...when creating a workflow and its steps and saving or submitting it, the preview mode does not allow users to see the steps, but only the workflow.
- if the workflow and its steps are saved as draft and a contributor accesses the workflow again via "my draft items", the preview only shows the workflow and the steps are missing.
- if the workflow and its steps are submitted, the moderator only sees the workflow and steps are missing while clicking on the label of the workflow from the "items to moderate" screen.
Experienced by some users today during the sprint and reproduced on stage. Example: https://sshoc-marketplace-stage.acdh-dev.oeaw.ac.at/workflow/lEuWKY/version/48679
notify also @klaus.illmayer @edward.grayStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/128vanishing values in concept-based fields2022-11-18T14:50:30ZLaure Barbotvanishing values in concept-based fieldswhile creating or enriching an exiting item via the edit form, there is a bug with some of the fields. It seems restricted to the concept-based fields.
I've managed to reproduce at least one case encountered today during the sprint, but...while creating or enriching an exiting item via the edit form, there is a bug with some of the fields. It seems restricted to the concept-based fields.
I've managed to reproduce at least one case encountered today during the sprint, but it might be that there are other cases I did not identify.
If a concept is chosen for a concept-based field (ex: "public" for intended audience), and some of the property lines above intended audience in the form are then deleted, the concept "public" disappears/vanishes from the field. Nevertheless it is still present and it doesn't prevent users to submit/save the item. Even when trying to select "public again, the concept continues to vanish if clicking somewhere else on the page.
looks very similar to https://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/83
notify also @klaus.illmayer @edward.grayStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/120Messing up properties in the new tool form2022-11-18T14:50:01ZKlaus IllmayerMessing up properties in the new tool form# π Bug Report
Under specific circumstances it is not possible to choose from a drop down list (= vocabulary driven property) when trying to create a new tool/service. This happens only when from the prefilled property list some propert...# π Bug Report
Under specific circumstances it is not possible to choose from a drop down list (= vocabulary driven property) when trying to create a new tool/service. This happens only when from the prefilled property list some properties are deleted.
## π€ Expected Behavior
Choosing from a property drop down list should work.
## π― Current Behavior
The drop down list shows values, but it is not possible to choose one resp. you choose one, it shows up in the drop down input field but disappears if you go to the next field.
There is no error visible, also not in the console (tried it out on stage and on develop)
## π§ How to reproduce
1. Login on MP
2. Create Tool or service
3. Scroll down to property type "Intended audience"
4. Delete the two property types above the "Intended audience": delete first "Tool Family" and then "Mode of use"
5. Click into "Intended audience" and choose a value e.g. "Public"
6. Go to the next property field "See also", now the value in "Intended audience" disappears
This is the simplest way to reproduce it, but it must have to do with some general problem when using the "delete", e.g., the problem does not show up when only deleting "Mode of use". I discovered the problem when I was supporting entering a new tool. We deleted the properties where we didn't found a value and suddenly it was not possible to choose values from some of the property types. As there is no warning/error, it is very irritating and may result in people not entering data anymore.
---Stefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/118Item giving 500 on Smartphone but not on PC2022-09-15T11:31:19ZKlaus IllmayerItem giving 500 on Smartphone but not on PC# π Bug Report
Go on startpage of marketplace (production), search for `helpdesk`, click in autocomplete on the `DARIAH-DE Helpdesk (CLARIAH-DE, Text+)` entry. This entry now shows up in the search results list. Click on it to see the d...# π Bug Report
Go on startpage of marketplace (production), search for `helpdesk`, click in autocomplete on the `DARIAH-DE Helpdesk (CLARIAH-DE, Text+)` entry. This entry now shows up in the search results list. Click on it to see the details. If you do this on a PC (I use the one at work, a Desktop PC, Linux, Firefox browser) you will see the detail page. If you do the same on a Smartphone (I have Android 10 and use the Firefox browser) you will not see the detail page but instead the screen is showing `500 - ref is not defined`.
## π€ Expected Behavior
Not only PC but also Smartphone should show the detail page.
## π― Current Behavior
PC does show the detail page but Smartphone not.
## π§ How to reproduce
See Bug Report description.
This bug was reported to us and I can reproduce it.
In the logfiles I see a warning coming most probably from Solr saying `Original query false: DARIAH-DE Helpdesk (CLARIAH-DE, Text+)
@stefan.probst Can you have a look if this is an issue by frontend? If not, we move it to backend.
---Stefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/116bug - my draft items - sorting by last modification2022-07-22T14:16:49ZLaure Barbotbug - my draft items - sorting by last modificationSorting by last modification doesn't seem to work well in the "my draft items" section. Items should be sorted the other way around!
![image](/uploads/35ec131b6ed661dfc6af642764829cf6/image.png)
(but ok on the "my contributed items" p...Sorting by last modification doesn't seem to work well in the "my draft items" section. Items should be sorted the other way around!
![image](/uploads/35ec131b6ed661dfc6af642764829cf6/image.png)
(but ok on the "my contributed items" page)Stefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/113Moderation items list does not update after approvement2022-07-22T09:21:38ZKlaus IllmayerModeration items list does not update after approvementIf in moderation list you have the possibility to "Approve" or "Reject" an item.
If clicking on "Approve" I would expect that the item automatically vanishes from the list. But after seeing "Successfully approved Training material" in t...If in moderation list you have the possibility to "Approve" or "Reject" an item.
If clicking on "Approve" I would expect that the item automatically vanishes from the list. But after seeing "Successfully approved Training material" in the left corner (which also stays if you don't perform another action) the approved item still shows up in the list. Only after doing an action (e.g. click somewhere) it is updated (when the automatic refresh happens) or by manually refreshing the page.
(Tested it on `stage`)Stefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/112Change of user role does not show up immediately2022-07-22T09:22:36ZKlaus IllmayerChange of user role does not show up immediatelyWhen going as administrator into the user list and changing the role of a user this will not be shown immediately. I need to refresh the search. As an example: I search for myself in the users list, see my entry as an result and see the ...When going as administrator into the user list and changing the role of a user this will not be shown immediately. I need to refresh the search. As an example: I search for myself in the users list, see my entry as an result and see the "Role" select box. There I change from "moderator" to "contributor": I click on "contributor", it shows the green "Successfully updated user role" but in the select box it again shows "moderator" (it should show "contributor" as I switched the role). Either I click once again into the role select box to see the change or I refresh the page, to see the correct state of the select box.Stefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/110links are not rendered in search results2022-06-16T19:23:55ZAlexander KΓΆniglinks are not rendered in search resultsAs can be seen in this screenshot, while links are rendered perfectly fine in the item view, they look weird in the search result view.
![image](/uploads/ceda800cfd9790db8465e29047221e81/image.png)As can be seen in this screenshot, while links are rendered perfectly fine in the item view, they look weird in the search result view.
![image](/uploads/ceda800cfd9790db8465e29047221e81/image.png)https://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/108OpenGraph metadata of landing pages should be item specific2022-04-30T19:30:38ZCarsten ThielOpenGraph metadata of landing pages should be item specificThe metadata in the `<meta>` properties `og:title` and `og:description` should match the regular `title` and `description`.
These are used by e.g. Slack previews (https://medium.com/slack-developer-blog/everything-you-ever-wanted-to-kno...The metadata in the `<meta>` properties `og:title` and `og:description` should match the regular `title` and `description`.
These are used by e.g. Slack previews (https://medium.com/slack-developer-blog/everything-you-ever-wanted-to-know-about-unfurling-but-were-afraid-to-ask-or-how-to-make-your-e64b4bb9254). ![Screenshot_2022-04-28_at_10.11.14](/uploads/b5b8e5f3e08d9711f1a4fc11aba962bf/Screenshot_2022-04-28_at_10.11.14.png)https://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/65Show keywords on search result page2021-07-02T07:40:01ZKlaus IllmayerShow keywords on search result pageGo to the search result page of the stage-instance: the keywords are not shown in a proper way (you only see the separator `,`)Go to the search result page of the stage-instance: the keywords are not shown in a proper way (you only see the separator `,`)Stefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/59autosuggest crashes when suggestion includes line break2021-08-05T14:42:41ZStefan Probstautosuggest crashes when suggestion includes line breakcurrently, some items have line breaks in their `label` (see https://gitlab.gwdg.de/sshoc/data-ingestion/-/issues/57), which is also returned from the autocomplete endpoint.
the combobox popup currently crashes in that case, because we ...currently, some items have line breaks in their `label` (see https://gitlab.gwdg.de/sshoc/data-ingestion/-/issues/57), which is also returned from the autocomplete endpoint.
the combobox popup currently crashes in that case, because we cannot use the `label` value as valid `data-key` attributehttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/54search button homepage2021-03-19T14:22:14ZLaure Barbotsearch button homepagethe search button on the homepage of the development instance is now displaying "submit" and not "search" anymore.the search button on the homepage of the development instance is now displaying "submit" and not "search" anymore.Stefan ProbstStefan Probst