sshoc-marketplace-frontend issueshttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues2022-01-13T08:41:34Zhttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/74don't create multiple items via "save as draft"2022-01-13T08:41:34ZStefan Probstdon't create multiple items via "save as draft"in a "Create new item" form, we currently create multiple new items when a user clicks "Save as draft" multiple times, because each click will dispatch a POST request.
this needs to be changed so that only the first "Save as draft" clic...in a "Create new item" form, we currently create multiple new items when a user clicks "Save as draft" multiple times, because each click will dispatch a POST request.
this needs to be changed so that only the first "Save as draft" click dispatches as POST request, and subsequent clicks on "Save as draft" dispatch a PUT request with the id received from the initial POST.Final ReleaseStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/73Implement option to create candidate concepts2022-02-03T13:13:45ZMatej DurcoImplement option to create candidate conceptsSilent creation of previously inexistent concept in the edit-field of concept-based vocabulary
One implementation option is an "inserting autocomplete":
I.e. if the user enters a term in a concept-based field that does not exist in the ...Silent creation of previously inexistent concept in the edit-field of concept-based vocabulary
One implementation option is an "inserting autocomplete":
I.e. if the user enters a term in a concept-based field that does not exist in the vocabulary, this could be added "silently", or maybe after asking the user, if she really wants to add one.
It should be in any case added with "candidate" flag.
However this does not harmonize with the combobox-widget for concept-selection.
Therefore alternatively, offer a link/button: [Suggest concept], analogously to [add Actor] could be provided.Final ReleaseStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/68edit forms - recommended fields per item type2022-01-13T10:32:12ZLaure Barbotedit forms - recommended fields per item type(apologies if there is already an issue covering this topic somewhere else. I couldn't find it).
A few months ago, we've decided during a T7.2 telco to add/display some properties by default in the edit forms, depending on the type of i...(apologies if there is already an issue covering this topic somewhere else. I couldn't find it).
A few months ago, we've decided during a T7.2 telco to add/display some properties by default in the edit forms, depending on the type of item a user would like to create. The idea is that when clicking on "create a publication", all metadata fields that are mandatory and recommended for publications would be already present in the edit form, but with empty values.
Mandatory and recommended fields are given by the Editorial Guidelines - at the moment accessible [here](https://docs.google.com/document/d/12VmhR9W4mN7AaOlrZGG2YxCCCsZDbHkuoXjfqfDG4PA/edit#) and very soon displayed on the "contribute" pages. They are also listed here: https://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/blob/main/config/forms.json
notify @edward.gray @klaus.illmayer @matej.durcoFinal ReleaseStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/50[forms] display error message when actor role field is empty2022-01-13T10:32:49ZLaure Barbot[forms] display error message when actor role field is empty# π Bug Report
<!--- Please provide a general summary of the issue. --> when adding an actor, if no actor role is chosen, the submit button is not available, which seems to indicate that an actor role is mandatory, but additional indica...# π Bug Report
<!--- Please provide a general summary of the issue. --> when adding an actor, if no actor role is chosen, the submit button is not available, which seems to indicate that an actor role is mandatory, but additional indications could clarify this.
## π€ Expected Behavior
<!--- Tell us what should happen. --> either have a "actor role is required" message or have by default a "contributor" role added
## π― Current Behavior
<!--- Tell us what happens instead of the expected behavior. --> no role is selected and no indication is given to the user that the actor role should be specified (except by the inactive "submit" button)
<!--- If you are seeing an error, please include the full error message. -->
---Final ReleaseStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/126map entitiy properties to schema.org things2022-11-18T14:58:49ZStefan Probstmap entitiy properties to schema.org thingswe should have a mapping of marketplace entities (and their properties) to schema.org. we can then include jsonld metadata on the item detail pages.
i have started with MPDataset, help apprectiated:
| Dataset | [dataset](https://schema...we should have a mapping of marketplace entities (and their properties) to schema.org. we can then include jsonld metadata on the item detail pages.
i have started with MPDataset, help apprectiated:
| Dataset | [dataset](https://schema.org/Dataset) |
| ------- | -------- |
| label | headline |
| description | abstract |
| description | description |
| accessibleAt | url |
| ??? | includedInDataCatalog |
| properties: keyword | about |
| licenses: label | license |
| version | version |
| contributor: actor.name | contributor |
| dateCreated | dateCreated |
| dateLastUpdated | dateModified |
| properties: language | inLanguage |Now or neverAlexander KΓΆnigAlexander KΓΆnighttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/106edit steps of workflows saved as draft2022-04-13T07:07:36ZLaure Barbotedit steps of workflows saved as draft# π Bug Report
when creating a workflow and its steps, and saving as draft the whole thing, there is a problem to re-access and edit the steps.
## π€ Expected Behavior
If I access a workflow from "my draft items" and want to edit step...# π Bug Report
when creating a workflow and its steps, and saving as draft the whole thing, there is a problem to re-access and edit the steps.
## π€ Expected Behavior
If I access a workflow from "my draft items" and want to edit steps before submitting the workflow to moderation or publishing it, the "edit" button is not clickable
## π― Current Behavior
the edit button on the screen below doesn't "answer"
![image](/uploads/9652bb381e14088d0845d716072912e9/image.png)
## π§ How to reproduce
<!--- Please provide directions how the issue can be reproduced. -->
1. create a workflow
2. create a step
3. save as draft
4. access the workflow from "my draft items"
5. go to workflow steps page
6. click on "edit" step
---
notify @klaus.illmayer @edward.gray @matej.durcoNow or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/105signing in banner - stage instance tests2022-04-08T06:38:05ZLaure Barbotsigning in banner - stage instance tests# π Bug Report
The "sign in" banner doesn't disappear and masks the access to the menu.
## π€ Expected Behavior
Once successfully logged in, the banner should disappear.
## π― Current Behavior
![image](/uploads/2e3e3c3d0485d7a0b129830...# π Bug Report
The "sign in" banner doesn't disappear and masks the access to the menu.
## π€ Expected Behavior
Once successfully logged in, the banner should disappear.
## π― Current Behavior
![image](/uploads/2e3e3c3d0485d7a0b129830b2d6f831c/image.png)
---Now or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/101small changes in the footer2022-03-30T15:21:14ZLaure Barbotsmall changes in the footerTo prepare the post-project phase, would it be possible to make some changes in the footer section currently displaying the EU flag and the following statement: "The SSH Open Marketplace is developed as part of the "Social Sciences and H...To prepare the post-project phase, would it be possible to make some changes in the footer section currently displaying the EU flag and the following statement: "The SSH Open Marketplace is developed as part of the "Social Sciences and Humanities Open Cloud' SSHOC project, European Union"s Horizon 2020 project call H2020-INFRAEOSC-04-2018, grant agreement #823782."?
We would need to add three logos: DARIAH, CLARIN and CESSDA (probably on the right side). And to slightly modify the sentence: "The SSH Open Marketplace has been developed as part of the "Social Sciences and Humanities Open Cloud' SSHOC project, European Union"s Horizon 2020 project call H2020-INFRAEOSC-04-2018, grant agreement #823782. It is maintained and will be further developed by three European Research Infrastructures - DARIAH, CLARIN and CESSDA - and their national partners."
@edward.gray @matej.durco @klaus.illmayer - any comments or alternative suggestions?Now or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/99403 error for contributors on "my draft items" screen2022-04-20T06:47:00ZStefan Probst403 error for contributors on "my draft items" screenwhen submitting a draft item, we need to call `/commit` in addition to the PUT-request-with-request-body, so the stale draft version will be correctly cleaned up by the frontend.when submitting a draft item, we need to call `/commit` in addition to the PUT-request-with-request-body, so the stale draft version will be correctly cleaned up by the frontend.Now or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/98very small change on the successfully submitted page2022-02-02T14:47:06ZLaure Barbotvery small change on the successfully submitted pageCould we change the text that appears for contributors once they have successfully submitted, and replace the "SSHOC Marketplace" by "the SSH Open Marketplace"
Current text: "Successfully submitted! Thanks! Your changes have been succes...Could we change the text that appears for contributors once they have successfully submitted, and replace the "SSHOC Marketplace" by "the SSH Open Marketplace"
Current text: "Successfully submitted! Thanks! Your changes have been successfully submitted and sent to a moderator for review. After approval, the changes will be visible on the SSHOC Marketplace."Now or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/95bug? media video display2022-02-03T13:13:01ZLaure Barbotbug? media video display# π Bug Report
when adding the link of a Youtube video to media - [example AntConc record](https://sshoc-marketplace-stage.acdh-dev.oeaw.ac.at/tool-or-service/0KBK9n) - I got a display error.
## π€ Expected Behavior
Either we display ...# π Bug Report
when adding the link of a Youtube video to media - [example AntConc record](https://sshoc-marketplace-stage.acdh-dev.oeaw.ac.at/tool-or-service/0KBK9n) - I got a display error.
## π€ Expected Behavior
Either we display videos as part of media, or if not possible to fix the bug, we change the guidelines and ask to add video links under `See also`
## π― Current Behavior
With Firefox:
![image](/uploads/b847d14ae5548cdf36a7718065ca96a3/image.png)
With Safari:
![image](/uploads/eb1b295ed388465aa874bc94b25b8b6f/image.png)
With GoogleChrome:
![image](/uploads/d76cb116691a06e4504859428bb0cb2a/image.png)
---
notify also @klaus.illmayer @matej.durco @edward.grayNow or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/91showing actor affiliations in edit forms2022-02-03T13:12:18ZLaure Barbotshowing actor affiliations in edit formsWhile curating actors, we realised that it can be that several actors have the same names and that only the affiliation allows a user to distinguish between these different actors. Example: "CLARIN-D centre" is entered as actor.name but ...While curating actors, we realised that it can be that several actors have the same names and that only the affiliation allows a user to distinguish between these different actors. Example: "CLARIN-D centre" is entered as actor.name but [several CLARIN-D centres exist](https://www.clarin-d.net/en/centres) and only their affiliation is different.
currently in the edit forms, the search is based on the actor.name and we have no possibilities to "preview" the affiliation to choose the right actor. Would it be possible to add the affiliation in the actor search as part of the edit forms?
including @martin.kirnbauer @matej.durco @klaus.illmayer @edward.gray
Although this would be important to fix to improve the curation work on actors. This is low priority in comparison to the other open issues attached to the final release milestone.Now or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/89items visible in the search auto-complete2022-03-25T09:58:05ZLaure Barbotitems visible in the search auto-completea potential issue spotted by one of our testers just after the curation sprint:
"During the process [of editing an item], I changes the name of the tool (system into service). As a consequence, both the draft title and the published tit...a potential issue spotted by one of our testers just after the curation sprint:
"During the process [of editing an item], I changes the name of the tool (system into service). As a consequence, both the draft title and the published title do show up with auto-completion when I search for WPSS now."
![image](/uploads/f900b550e825705b0823316ac5393fa7/image.png)
Is it supposed to work like this (= an suggested item and not approved yet is visible alongside the approved one)? Or is it something that we could/should change?
what do you think @klaus.illmayer @stefan.probst @matej.durco ?Now or neverLaure BarbotLaure Barbothttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/88sort actor and concept combobox values alphabetically2022-10-27T11:13:37ZMatej Durcosort actor and concept combobox values alphabeticallyCurrently with a longer vocabulary, user in edit form has to know what to start typing to get a suggestions.
There has to be a way to see full list of vocabularies
- in minimal case (vocabulary specific) link to https://vocabs.sshopenclo...Currently with a longer vocabulary, user in edit form has to know what to start typing to get a suggestions.
There has to be a way to see full list of vocabularies
- in minimal case (vocabulary specific) link to https://vocabs.sshopencloud.eu/vocabularies/en/ (or whatever they are published, e.g. TaDiRAH in https://vocabs.dariah.eu/tadirah/en/)
- or some listing of the whole vocabulary as listed by the API.
Ideas how to implement?
(notify: @klaus.illmayer , @lbarbot @matej.durcoNow or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/84Highlight changes in fields of suggested items2022-07-22T09:46:35ZKlaus IllmayerHighlight changes in fields of suggested itemsFirst of all: the notion of fields in this issue includes attributes (like the description of an item) as well as dynamic properties.
## Problem description
Contributors suggest a new version of an item. Such suggestions are approved b...First of all: the notion of fields in this issue includes attributes (like the description of an item) as well as dynamic properties.
## Problem description
Contributors suggest a new version of an item. Such suggestions are approved by moderators. For this we have the curation dashboard `Items to moderate` where all suggested versions are collected. By editing and publishing such a suggestion this version becomes the new approved version. Curators scroll through the edit form of the suggested item and look, if this item can be approved.
Now the problem: there is currently no (visual) clue which fields changed compared to the current approved item. Therefore it is not easy for moderators to spot, which fields to look for moderation. It would be very helpful, if there is something like a visual highlighting (like an icon and/or a background color) for all fields that are different to the current approved item. Moderators can then focus on this changes which would simplify the approval workflow.
Current workaround: Open a second browser tab with the current approved item and compare it with the content of the suggested version in the first browser tab. This needs a very focused approach and is by no means error-free.
## Solution discussion
I've had already a discussion with @stefan.probst on this and a further discussion round with @lbarbot and @buddenbohm, summing up the current information.
Frontend solution: Finding a good and easy solution is not that easy if frontend should solve this alone. First of all we do not have an UX/design proposal that we could use. Questions are:
* what is a usability-conform way to show the differences between two fields (color alone - which color? - is not accessibility conform)?
* how to show deleted fields? (more easier: how to highlight added fields)
* to which detail should changes of fields be shown: have a diff of a text field (showing which letters where added/deleted/changed)
* how to process the API results of the items to be compared: there is probably no coherent way to do this automatically, as we do have different field structures based on the difference between attributes/properties, the different data types (a concept is expressed in a very different way as a string field), foreign keys to e.g. actors, sources identified by id
* would that imply a way to revert the value of a field by clicking on a button?
* connected to the last point: should changes by moderators be shown in a different highlighting?
* what should be compared when there are more then one suggestions of an item?
Backend solution: It could be possible that backend does such comparision and delivers a meta-information on changed fields at an suggested item. Disadvantage: coding effort at backend, solves only some questions for frontend.
Curation notebooks solution: The easiest way could be to delegate comparisions between versions of an item to a notebook, which could GET the different versions of an item from the API, do a [diff](https://en.wikipedia.org/wiki/Diff) and show the result. Disadvantage: no integration in the curation dashboard, moderators need to be sensitive and aware about the curation notebook.
## Solution proposal
The mentioned discussions already gave some proposals:
* It is expected that the highlighting of changes is part of the frontend/curation dashboard.
* Comparision should be always based on the current approved item. If there are more suggested versions it is up to curators to decide which to take. The highlighting of a suggested version should always and only be compared against the current approved item (if there is no approved item available, this could be expressed in an information message).
* Highlighting should be very basic, details are not necessary, it is only about telling curators that one field is different to the one of the current approved item (not telling what is different).
* UX/Design proposal is necessary, could @wytrazek create a mockup for this?
There is also another discussion about this issue, where there is a proposal to have the two versions next to it in one screen, allowing moderators to approve/reject changes. It is also mentioned in this disucssion, that this may be the best solution but also the most tricky one to implement. Thus I propose to go with the simplier version (only highlighting changes) and leave it up to the moderators to decide if they approve all changes. If moderators identify revisable changes, then further inquiry should be done manually (giving a workflow document on how to do this: looking for the current approved item in a second tab and comparing it).
I also think that a solution for this issue is not necessary for the release in December but it should be solved until the end of the project when a new curation team takes over.
Summing up:
* @lbarbot @matej.durco @edward.gray @buddenbohm Please give advise about how sophisticated this issue should be solved
* Based on this a mockup should be created, keeping in mind UX/design issues
* Afterwards @stefan.probst can implement the proposals of the mockupNow or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/80welcoming users2021-12-06T10:52:30ZLaure Barbotwelcoming usersTwo things highlighted during the curation sprint and that could be relatively easily improved to "welcome" users:
1. Sign in screen: it is not clear for a new comer what local accounts are used for. Would it be possible to modify the s...Two things highlighted during the curation sprint and that could be relatively easily improved to "welcome" users:
1. Sign in screen: it is not clear for a new comer what local accounts are used for. Would it be possible to modify the short sentence that is already there with something like "Sign in with a local account is used by maintainers to manage the website"
![image](/uploads/304d97e079426cd84812505961738879/image.png)
I would also be in favour of adding at the bottom of the "sign in" block another "or" option with something like "Having trouble with the sign in process, [contact the SSH Open Marketplace team ](/contact)" or something similar.
2. Dashboard screen: would it be possible to add a few welcoming sentences on ["My account" screen](https://sshoc-marketplace-stage.acdh-dev.oeaw.ac.at/account)?
- Proposal for contributors: βDear contributor to the SSH Open Marketplace, welcome to the curation dashboard of the SSH Open Marketplace! You can find here the list of items you have contributed to as well as the list of your draft items. Now that you are logged in, you can create and edit items. Please consult the contributors guidelines (/contribute) if you need to be guided in the process.β
- Proposal for moderators: βDear moderator of the SSH Open Marketplace, welcome to the curation dashboard! As any contributor, you can find here the list of items you have contributed to as well as the list of your draft items. Because of your moderator status, you can also access the list of items to moderate and manage the actors referenced in the Marketplace. Please consult the contribute pages (/contribute) if you need some guidance.β
- Proposal for administrators: βDear administrator of the SSH Open Marketplace, welcome to the curation dashboard! As any contributor, you can find here the list of items you have contributed to as well as the list of your draft items. As any moderator, you can also access the list of items to moderate and manage the actors referenced in the Marketplace. And because of your administrator status, you can also manage sources and users. Please consult the contribute pages (/contribute) if you need some guidance.
@edward.gray what do you think? could you check the wording?
@stefan.probst, what do you think? would it be possible to implement such things?
notify also @buddenbohm @klaus.illmayer @matej.durcoNow or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/78UI for managing concepts2022-03-21T16:37:08ZMatej DurcoUI for managing conceptsRelated to #19.
I am afraid we need some UI components to maintain the vocabularies and (or at least) the concepts.
We will have option to add new concepts as of #73
but the moderators need to see the candidate concepts and approve the...Related to #19.
I am afraid we need some UI components to maintain the vocabularies and (or at least) the concepts.
We will have option to add new concepts as of #73
but the moderators need to see the candidate concepts and approve them, or merge them with existing concepts
(notify: @lbarbot, @klaus.illmayer, @stefan.probst)Now or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/71Some externalIds are not shown in detail page2021-10-27T15:28:25ZKlaus IllmayerSome externalIds are not shown in detail page# π Bug Report
We do have different `externalIds` for actors, e.g. `ORCID` but also `Twitter` and `GitHub` (see `GET api/actor-sources`). The ORCID is shown in the detail page but not Twitter, GitHub and the others.
## π€ Expected Behav...# π Bug Report
We do have different `externalIds` for actors, e.g. `ORCID` but also `Twitter` and `GitHub` (see `GET api/actor-sources`). The ORCID is shown in the detail page but not Twitter, GitHub and the others.
## π€ Expected Behavior
Every `externalId` of an actor/contributor should be shown.
## π― Current Behavior
Only the `ORCID` is currently shown as an icon. See as example on stage the item `training-material/ljss6D`. In `api/training-materials/ljss6D` you will see that the actor `James Baker` does not only have an ORCID but also a Twitter and a GitHub identifier. In the frontend only the ORCID is visible.
## Remarks
I guess this is related to the currently not implemented feature of having `urlTemplates` for the `externalIds`: https://gitlab.gwdg.de/sshoc/sshoc-marketplace/-/issues/80 (could be implemented today). But nevertheless, is there an idea how to show many externalIdentifiers for users? Should there be also an icon and if so, should that icon be part of the `api/actor-sources`-call?
---Now or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/64Choose a concept from a hierarchical vocabulary2022-01-27T13:46:28ZKlaus IllmayerChoose a concept from a hierarchical vocabularyWe do have some vocabularies, that do have a hierarchy, e.g. `discipline`. When adding a concept from such a hierarchy it shows up in the edit forms as a flat list. But for quality of input it would be good to see the hierarchy, otherwis...We do have some vocabularies, that do have a hierarchy, e.g. `discipline`. When adding a concept from such a hierarchy it shows up in the edit forms as a flat list. But for quality of input it would be good to see the hierarchy, otherwise it is only a good guess to find the best concept. If the hierarchy of the vocabulary could be shown in the drop-down-list, it would be easier to either drill down to a narrow concept or use the broader one.
In backend the hierarchy is implemented (have a look at `/api/vocabularies/discipline`) through the relations `narrower` and `broader` - it could be visualised like in the Skosmos view of https://vocabs.dariah.eu/oefos/en/ when clicking on `Hierarchy`, e.g. `6 Humanities` =narrower=> `604 Arts` =narrower=> `6040 Arts` =narrower=> `604029 Theatre studies`. Maybe a js-library could be used for this.
Opinions are welcome: @lbarbot @edward.gray @matej.durcoNow or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/58Multi-select values in dynamic properties2022-04-08T06:41:25ZMatej DurcoMulti-select values in dynamic propertiesmockups propose a multi-select for defining multiple concepts per dynamic property.
Example: if I want to enter 10 "activity" concepts, I have to add 10 new properties and select activity for each one of them.
(notify: @klaus.illmayer,...mockups propose a multi-select for defining multiple concepts per dynamic property.
Example: if I want to enter 10 "activity" concepts, I have to add 10 new properties and select activity for each one of them.
(notify: @klaus.illmayer, @lbarbot )Now or neverStefan ProbstStefan Probst