sshoc-marketplace-frontend issueshttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues2022-02-03T13:13:01Zhttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/95bug? media video display2022-02-03T13:13:01ZLaure Barbotbug? media video display# π Bug Report
when adding the link of a Youtube video to media - [example AntConc record](https://sshoc-marketplace-stage.acdh-dev.oeaw.ac.at/tool-or-service/0KBK9n) - I got a display error.
## π€ Expected Behavior
Either we display ...# π Bug Report
when adding the link of a Youtube video to media - [example AntConc record](https://sshoc-marketplace-stage.acdh-dev.oeaw.ac.at/tool-or-service/0KBK9n) - I got a display error.
## π€ Expected Behavior
Either we display videos as part of media, or if not possible to fix the bug, we change the guidelines and ask to add video links under `See also`
## π― Current Behavior
With Firefox:
![image](/uploads/b847d14ae5548cdf36a7718065ca96a3/image.png)
With Safari:
![image](/uploads/eb1b295ed388465aa874bc94b25b8b6f/image.png)
With GoogleChrome:
![image](/uploads/d76cb116691a06e4504859428bb0cb2a/image.png)
---
notify also @klaus.illmayer @matej.durco @edward.grayNow or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/94[forms] bug - dates for publications and datasets2022-01-14T10:59:08ZLaure Barbot[forms] bug - dates for publications and datasets# π Bug Report
When creating a new publication or dataset, fields `date created` and `date last updated` can be filled in.
![image](/uploads/4ef8cbfff92b37d4e364c3e4fbaf95fc/image.png)
When they are filled in, the submission of the i...# π Bug Report
When creating a new publication or dataset, fields `date created` and `date last updated` can be filled in.
![image](/uploads/4ef8cbfff92b37d4e364c3e4fbaf95fc/image.png)
When they are filled in, the submission of the item fails. If they are empty the submission of the item is possible.
## π€ Expected Behavior
The submission of the item should be possible, when these fields are completed.
## π― Current Behavior
@klaus.illmayer checked the logs yesterday when I was trying to create a new dataset, and here is the report:
`org.springframework.http.converter.HttpMessageNotReadableException: JSON parse error: Cannot deserialize value of type `java.time.ZonedDateTime` from String "2021-05-10": Failed to deserialize java.time.ZonedDateTime: (java.time.format.DateTimeParseException) Text '2021-05-10' could not be parsed at index 10; nested exception is com.fasterxml.jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `java.time.ZonedDateTime` from String "2021-05-10": Failed to deserialize java.time.ZonedDateTime: (java.time.format.DateTimeParseException) Text '2021-05-10' could not be parsed at index 10`
---Curation module implementedStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/93ExternalId doi is missing the url2022-01-13T16:10:23ZKlaus IllmayerExternalId doi is missing the urlLook at this item on development frontend: `/publication/CTJTR4`. It shows on the right side information bar the information `doi` but does not give the url to the DOI. Looking at the API output `/api/publications/CTJTR4` you will see th...Look at this item on development frontend: `/publication/CTJTR4`. It shows on the right side information bar the information `doi` but does not give the url to the DOI. Looking at the API output `/api/publications/CTJTR4` you will see that there is an identifier and there is also an `identifierService` with an `urlTemplate` for the doi.Stefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/92removing "steps" and "create step" from the top menu2022-01-12T22:15:55ZLaure Barbotremoving "steps" and "create step" from the top menuwould it be possible to remove "steps" and "create step" from the top menu?
![image](/uploads/5a379657b4047d31743e0c05054793a2/image.png)would it be possible to remove "steps" and "create step" from the top menu?
![image](/uploads/5a379657b4047d31743e0c05054793a2/image.png)Final ReleaseStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/91showing actor affiliations in edit forms2022-02-03T13:12:18ZLaure Barbotshowing actor affiliations in edit formsWhile curating actors, we realised that it can be that several actors have the same names and that only the affiliation allows a user to distinguish between these different actors. Example: "CLARIN-D centre" is entered as actor.name but ...While curating actors, we realised that it can be that several actors have the same names and that only the affiliation allows a user to distinguish between these different actors. Example: "CLARIN-D centre" is entered as actor.name but [several CLARIN-D centres exist](https://www.clarin-d.net/en/centres) and only their affiliation is different.
currently in the edit forms, the search is based on the actor.name and we have no possibilities to "preview" the affiliation to choose the right actor. Would it be possible to add the affiliation in the actor search as part of the edit forms?
including @martin.kirnbauer @matej.durco @klaus.illmayer @edward.gray
Although this would be important to fix to improve the curation work on actors. This is low priority in comparison to the other open issues attached to the final release milestone.Now or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/90Are contributors/authors sorted by alphabet?2022-01-13T07:04:16ZKlaus IllmayerAre contributors/authors sorted by alphabet?It seems to me that frontend orders actors in the detail page by alphabet. Take as example on the development frontend `/publication/y5hzLA`. In the API call `/api/publications/y5hzLA` and also at the source you see that `Yalemisew M. Ab...It seems to me that frontend orders actors in the detail page by alphabet. Take as example on the development frontend `/publication/y5hzLA`. In the API call `/api/publications/y5hzLA` and also at the source you see that `Yalemisew M. Abgaz` should be the first one (due to the surname) but due to a sorting algorithm on frontend the author becomes the last one. As especially for publications the sort order is important, I think the order should stay the way how it comes from the backend.
Asking @lbarbot @edward.gray if they disagreeStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/89items visible in the search auto-complete2022-03-25T09:58:05ZLaure Barbotitems visible in the search auto-completea potential issue spotted by one of our testers just after the curation sprint:
"During the process [of editing an item], I changes the name of the tool (system into service). As a consequence, both the draft title and the published tit...a potential issue spotted by one of our testers just after the curation sprint:
"During the process [of editing an item], I changes the name of the tool (system into service). As a consequence, both the draft title and the published title do show up with auto-completion when I search for WPSS now."
![image](/uploads/f900b550e825705b0823316ac5393fa7/image.png)
Is it supposed to work like this (= an suggested item and not approved yet is visible alongside the approved one)? Or is it something that we could/should change?
what do you think @klaus.illmayer @stefan.probst @matej.durco ?Now or neverLaure BarbotLaure Barbothttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/88sort actor and concept combobox values alphabetically2022-10-27T11:13:37ZMatej Durcosort actor and concept combobox values alphabeticallyCurrently with a longer vocabulary, user in edit form has to know what to start typing to get a suggestions.
There has to be a way to see full list of vocabularies
- in minimal case (vocabulary specific) link to https://vocabs.sshopenclo...Currently with a longer vocabulary, user in edit form has to know what to start typing to get a suggestions.
There has to be a way to see full list of vocabularies
- in minimal case (vocabulary specific) link to https://vocabs.sshopencloud.eu/vocabularies/en/ (or whatever they are published, e.g. TaDiRAH in https://vocabs.dariah.eu/tadirah/en/)
- or some listing of the whole vocabulary as listed by the API.
Ideas how to implement?
(notify: @klaus.illmayer , @lbarbot @matej.durcoNow or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/87long url display on item detail view2021-11-18T18:29:33ZLaure Barbotlong url display on item detail viewon [this item](https://sshoc-marketplace-stage.acdh-dev.oeaw.ac.at/tool-or-service/BDR3JZ), we have long URLs as part of the metadata details. Is there a way to provide a better display of these long URLs?
notify also @klaus.illmayer @...on [this item](https://sshoc-marketplace-stage.acdh-dev.oeaw.ac.at/tool-or-service/BDR3JZ), we have long URLs as part of the metadata details. Is there a way to provide a better display of these long URLs?
notify also @klaus.illmayer @matej.durcoStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/86responsive?2022-02-02T13:57:01ZLaure Barbotresponsive?Is planned or already discussed somewhere to have a responsive version for mobile devices?
I think it is a must have (but maybe not for the final release if we have to prioritise other things).
notify also @matej.durco @klaus.illmayerIs planned or already discussed somewhere to have a responsive version for mobile devices?
I think it is a must have (but maybe not for the final release if we have to prioritise other things).
notify also @matej.durco @klaus.illmayerStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/85Approve/Reject buttons in moderation item view2022-01-13T08:41:13ZKlaus IllmayerApprove/Reject buttons in moderation item viewWhen moderators approve a suggested version of an item, they go to the curation dashboard `Items to moderate` and edit the chosen suggestion that should be approved.
Currently, there are three buttons: `Cancel`, `Save as draft` and `Pub...When moderators approve a suggested version of an item, they go to the curation dashboard `Items to moderate` and edit the chosen suggestion that should be approved.
Currently, there are three buttons: `Cancel`, `Save as draft` and `Publish`.
* `Publish` could be renamed to `Approve`, making it more clearer what is happening.
* `Save as draft` seems to me unnecessary (it would create a draft of this item in the moderators draft item list)
* `Cancel` returns to the main page, it will not reject the suggested version of the item
`Reject` does not exist but could be helpful to clean up the curation dashboard moderation items overview (and it would prevent that other moderators look into an already ignored version). To add reject function it would be necessary to add a new endpoint in the API by backend (DELETE a version of an item). Currently, the only way to get rid of a suggested item is either to approve another version of an item or to explicitely approve the current approved item (kind of workaround).
@lbarbot @edward.gray @matej.durco What are your opinions on the current state of the buttons and the necessity of a reject button?Final ReleaseStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/84Highlight changes in fields of suggested items2022-07-22T09:46:35ZKlaus IllmayerHighlight changes in fields of suggested itemsFirst of all: the notion of fields in this issue includes attributes (like the description of an item) as well as dynamic properties.
## Problem description
Contributors suggest a new version of an item. Such suggestions are approved b...First of all: the notion of fields in this issue includes attributes (like the description of an item) as well as dynamic properties.
## Problem description
Contributors suggest a new version of an item. Such suggestions are approved by moderators. For this we have the curation dashboard `Items to moderate` where all suggested versions are collected. By editing and publishing such a suggestion this version becomes the new approved version. Curators scroll through the edit form of the suggested item and look, if this item can be approved.
Now the problem: there is currently no (visual) clue which fields changed compared to the current approved item. Therefore it is not easy for moderators to spot, which fields to look for moderation. It would be very helpful, if there is something like a visual highlighting (like an icon and/or a background color) for all fields that are different to the current approved item. Moderators can then focus on this changes which would simplify the approval workflow.
Current workaround: Open a second browser tab with the current approved item and compare it with the content of the suggested version in the first browser tab. This needs a very focused approach and is by no means error-free.
## Solution discussion
I've had already a discussion with @stefan.probst on this and a further discussion round with @lbarbot and @buddenbohm, summing up the current information.
Frontend solution: Finding a good and easy solution is not that easy if frontend should solve this alone. First of all we do not have an UX/design proposal that we could use. Questions are:
* what is a usability-conform way to show the differences between two fields (color alone - which color? - is not accessibility conform)?
* how to show deleted fields? (more easier: how to highlight added fields)
* to which detail should changes of fields be shown: have a diff of a text field (showing which letters where added/deleted/changed)
* how to process the API results of the items to be compared: there is probably no coherent way to do this automatically, as we do have different field structures based on the difference between attributes/properties, the different data types (a concept is expressed in a very different way as a string field), foreign keys to e.g. actors, sources identified by id
* would that imply a way to revert the value of a field by clicking on a button?
* connected to the last point: should changes by moderators be shown in a different highlighting?
* what should be compared when there are more then one suggestions of an item?
Backend solution: It could be possible that backend does such comparision and delivers a meta-information on changed fields at an suggested item. Disadvantage: coding effort at backend, solves only some questions for frontend.
Curation notebooks solution: The easiest way could be to delegate comparisions between versions of an item to a notebook, which could GET the different versions of an item from the API, do a [diff](https://en.wikipedia.org/wiki/Diff) and show the result. Disadvantage: no integration in the curation dashboard, moderators need to be sensitive and aware about the curation notebook.
## Solution proposal
The mentioned discussions already gave some proposals:
* It is expected that the highlighting of changes is part of the frontend/curation dashboard.
* Comparision should be always based on the current approved item. If there are more suggested versions it is up to curators to decide which to take. The highlighting of a suggested version should always and only be compared against the current approved item (if there is no approved item available, this could be expressed in an information message).
* Highlighting should be very basic, details are not necessary, it is only about telling curators that one field is different to the one of the current approved item (not telling what is different).
* UX/Design proposal is necessary, could @wytrazek create a mockup for this?
There is also another discussion about this issue, where there is a proposal to have the two versions next to it in one screen, allowing moderators to approve/reject changes. It is also mentioned in this disucssion, that this may be the best solution but also the most tricky one to implement. Thus I propose to go with the simplier version (only highlighting changes) and leave it up to the moderators to decide if they approve all changes. If moderators identify revisable changes, then further inquiry should be done manually (giving a workflow document on how to do this: looking for the current approved item in a second tab and comparing it).
I also think that a solution for this issue is not necessary for the release in December but it should be solved until the end of the project when a new curation team takes over.
Summing up:
* @lbarbot @matej.durco @edward.gray @buddenbohm Please give advise about how sophisticated this issue should be solved
* Based on this a mockup should be created, keeping in mind UX/design issues
* Afterwards @stefan.probst can implement the proposals of the mockupNow or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/83edit form - vanishing fields2022-11-16T18:54:04ZLaure Barbotedit form - vanishing fieldsspotted during the curation sprint:
while editing items - example /tool-or-service/yxZvbH on stage - some already existing fields appear empty even if they are not. A value can be selected but would vanish if clicking somewhere on the p...spotted during the curation sprint:
while editing items - example /tool-or-service/yxZvbH on stage - some already existing fields appear empty even if they are not. A value can be selected but would vanish if clicking somewhere on the page. This would not prevent the contributor to submit the form.
This bug has been noticed at least for Actors Name and Related Items.
It looks like this closed issue https://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/56
(notify also @edward.gray @buddenbohm @matej.durco @klaus.illmayer )Final ReleaseStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/82List of items to moderate2022-01-13T08:09:18ZLaure BarbotList of items to moderateprobably because of the very close (identical) naming convention between user role "contributor" and actor role "contributor", there is an inconsistency on the "items to moderate" screen that could be easily solved.
Contributors on the ...probably because of the very close (identical) naming convention between user role "contributor" and actor role "contributor", there is an inconsistency on the "items to moderate" screen that could be easily solved.
Contributors on the facets are names of users (=information.contributor) while contributors appearing on the item lists are actors.
![image](/uploads/a7fd05a562d83809d72271ae6d940c03/image.png)
As this is the "items to moderate" section, I think it is more relevant to see user names (information.contributor) than the actors on the item lists. Could this be easily changed @stefan.probst ?
any objection @klaus.illmayer @edward.gray @buddenbohm @matej.durcoStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/81Inconsistent display of (suggested) versions for contributor2022-01-13T08:43:31ZLaure BarbotInconsistent display of (suggested) versions for contributorThis is a complicated issue to describe. @klaus.illmayer @buddenbohm @matej.durco @edward.gray @stefan.probst please rephrase if this is not the most appropriate way to solve the problem.
During the curation sprint, we have noted severa...This is a complicated issue to describe. @klaus.illmayer @buddenbohm @matej.durco @edward.gray @stefan.probst please rephrase if this is not the most appropriate way to solve the problem.
During the curation sprint, we have noted several problems related to the item versions made available to users. The main problem being that because of a confusion between different item versions accessible to contributors, several suggested versions of the same item can be created and pushed in the moderation pipeline, leading to the risk of overwriting changes suggested (via different versions) while approving the last suggested version.
![mod.dash](/uploads/c1ca368872eb9585c493cacd328aac9f/mod.dash.png)
This issue tries to summarise these problems and to suggest a simplified workflow from the contributor point of view.
Problem: too many versions can easily be accessed/created by the same contributor.
- The DRAFT ("save as a draft" button on the edit form) is not retrieved when the same user edits the same item again.
- The last SUGGESTED version/item (?) is not retrieved when the same user edits the same item again (before its approval), while clicking on the "edit" button of the item.
- clicking on the item label in the "contributed items" leads to the preview of the last suggested version but without the "edit/history" buttons
Possible solutions:
1. while editing an item for which a given contributor has already started either a draft or suggested a new version, the latest changes should be retrieved. (Alternatively, warnings messages could be added)
2. Clicking on the item label in the list of items displayed in "my contributed items" should lead to the preview of the latest suggested version and include the "edit/history" buttons.
3. would it be possible to see "suggested" items in the version history?
4. it could be useful for a contributor to see in "my contributed items" not only the suggested items before they are approved (currently once they are approved, they disappear from the list), but all items they worked on.
@stefan.probst what do you think? As discussed with @klaus.illmayer maybe some of these options are not front-end related. Can you comment in case?
Improvement in the curation workflow for moderators - esp. individuate and highlight the changes between versions - is addressed in a separate issue.Final ReleaseStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/80welcoming users2021-12-06T10:52:30ZLaure Barbotwelcoming usersTwo things highlighted during the curation sprint and that could be relatively easily improved to "welcome" users:
1. Sign in screen: it is not clear for a new comer what local accounts are used for. Would it be possible to modify the s...Two things highlighted during the curation sprint and that could be relatively easily improved to "welcome" users:
1. Sign in screen: it is not clear for a new comer what local accounts are used for. Would it be possible to modify the short sentence that is already there with something like "Sign in with a local account is used by maintainers to manage the website"
![image](/uploads/304d97e079426cd84812505961738879/image.png)
I would also be in favour of adding at the bottom of the "sign in" block another "or" option with something like "Having trouble with the sign in process, [contact the SSH Open Marketplace team ](/contact)" or something similar.
2. Dashboard screen: would it be possible to add a few welcoming sentences on ["My account" screen](https://sshoc-marketplace-stage.acdh-dev.oeaw.ac.at/account)?
- Proposal for contributors: βDear contributor to the SSH Open Marketplace, welcome to the curation dashboard of the SSH Open Marketplace! You can find here the list of items you have contributed to as well as the list of your draft items. Now that you are logged in, you can create and edit items. Please consult the contributors guidelines (/contribute) if you need to be guided in the process.β
- Proposal for moderators: βDear moderator of the SSH Open Marketplace, welcome to the curation dashboard! As any contributor, you can find here the list of items you have contributed to as well as the list of your draft items. Because of your moderator status, you can also access the list of items to moderate and manage the actors referenced in the Marketplace. Please consult the contribute pages (/contribute) if you need some guidance.β
- Proposal for administrators: βDear administrator of the SSH Open Marketplace, welcome to the curation dashboard! As any contributor, you can find here the list of items you have contributed to as well as the list of your draft items. As any moderator, you can also access the list of items to moderate and manage the actors referenced in the Marketplace. And because of your administrator status, you can also manage sources and users. Please consult the contribute pages (/contribute) if you need some guidance.
@edward.gray what do you think? could you check the wording?
@stefan.probst, what do you think? would it be possible to implement such things?
notify also @buddenbohm @klaus.illmayer @matej.durcoNow or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/79Draft items are not editable2021-10-15T14:06:19ZKlaus IllmayerDraft items are not editable# π Bug Report
Creating a new item and saving it as draft. When later on editing this draft item again on "My account"=>"My draft items"=>"Edit" it will give a "page not found". In the console it says "404 Not Found" for https://sshoc-m...# π Bug Report
Creating a new item and saving it as draft. When later on editing this draft item again on "My account"=>"My draft items"=>"Edit" it will give a "page not found". In the console it says "404 Not Found" for https://sshoc-marketplace.acdh-dev.oeaw.ac.at/workflow/[persistentId]/edit/draft
Additionally, I have one example (a draft only with a title and a description) where in the "My draft items" next to the title of the draft item there are brackets without a content: `Test Statuses ()`. I'm not sure what is creating these brackets, I didn't enter them (maybe the field version?).
And a last one: If in "My draft items" you don't click on "Edit" but on the title of the draft item, you will see the detail view of this item without an "Edit"-button but with an "History"-button. When clicking on this history button you run into an infinite wheel animation.
## π€ Expected Behavior
I like to edit my draft and see the edit forms.
I don't want brackets without content next to the title of my draft item.
I like to see the history of the draft item.
## π― Current Behavior
I can't edit my draft.
I see brackets without content next ot the title of my draft item in the "My draft items"-list.
I don't see a history but instead an infinite wheel animation.
---Curation module implementedStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/78UI for managing concepts2022-03-21T16:37:08ZMatej DurcoUI for managing conceptsRelated to #19.
I am afraid we need some UI components to maintain the vocabularies and (or at least) the concepts.
We will have option to add new concepts as of #73
but the moderators need to see the candidate concepts and approve the...Related to #19.
I am afraid we need some UI components to maintain the vocabularies and (or at least) the concepts.
We will have option to add new concepts as of #73
but the moderators need to see the candidate concepts and approve them, or merge them with existing concepts
(notify: @lbarbot, @klaus.illmayer, @stefan.probst)Now or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/77failed to fetch users2021-12-06T10:24:01ZLaure Barbotfailed to fetch userswhile working on the stage instance, with a moderator profile (log in with the local account 'Moderator') I got a red banner "failed to fetch users" when I work on the "items to moderate" section of the dashboard. It happens when I tick ...while working on the stage instance, with a moderator profile (log in with the local account 'Moderator') I got a red banner "failed to fetch users" when I work on the "items to moderate" section of the dashboard. It happens when I tick some boxes to select items.Final ReleaseMichaΕ KozakMichaΕ Kozakhttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/76sign-in screen - grey colors on Safari2021-10-01T07:01:42ZLaure Barbotsign-in screen - grey colors on SafariIs it supposed to be displayed with grey colours like in this screenshot (while using Safari 15.0)? I don't have the same screen with Firefox.
![image](/uploads/b8479a35ac663b016aa98be72cd73598/image.png)Is it supposed to be displayed with grey colours like in this screenshot (while using Safari 15.0)? I don't have the same screen with Firefox.
![image](/uploads/b8479a35ac663b016aa98be72cd73598/image.png)Stefan ProbstStefan Probst