sshoc-marketplace-frontend issueshttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues2021-04-16T12:16:53Zhttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/60media2021-04-16T12:16:53ZLaure Barbotmedia# ๐ Bug Report
<!--- Please provide a general summary of the issue. --> while creating [this test workflow](https://sshoc-marketplace.acdh-dev.oeaw.ac.at/workflow/KU3pHg), I have added two media (one Youtube video and one jpg image), bu...# ๐ Bug Report
<!--- Please provide a general summary of the issue. --> while creating [this test workflow](https://sshoc-marketplace.acdh-dev.oeaw.ac.at/workflow/KU3pHg), I have added two media (one Youtube video and one jpg image), but none of them is rendered in the item detail view. (Maybe this is linked to the ongoing backend changes on media, and not a frontend bug)
## ๐ค Expected Behavior
<!--- Tell us what should happen. --> Two media should appear on the [this page](https://sshoc-marketplace.acdh-dev.oeaw.ac.at/workflow/KU3pHg)
## ๐ฏ Current Behavior
<!--- Tell us what happens instead of the expected behavior. --> the media block remains empty
<!--- If you are seeing an error, please include the full error message. -->
---Curation module implementedKlaus IllmayerStefan ProbstKlaus Illmayerhttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/61edit forms, data model & editorial guidelines2021-05-04T15:16:20ZLaure Barbotedit forms, data model & editorial guidelinesa few comments based on the work going on in T7.4 for the [editorial guidelines](https://docs.google.com/document/d/12VmhR9W4mN7AaOlrZGG2YxCCCsZDbHkuoXjfqfDG4PA/edit#) of the Marketplace, that should be added as documentation/static page...a few comments based on the work going on in T7.4 for the [editorial guidelines](https://docs.google.com/document/d/12VmhR9W4mN7AaOlrZGG2YxCCCsZDbHkuoXjfqfDG4PA/edit#) of the Marketplace, that should be added as documentation/static pages for the beta+ version, and also based on my first tests using the edit forms:
1. we are still looking for the best way to structure the guidelines to support contributors and moderators in the creation and review/approbation of the items. One important idea is the need to prioritise attributes/properties depending on the type of items created (i.e. bibliographic metadata are important if you create a publication, maybe less if you create a tool&service), so we came up with this idea of having **recommended fields** depending on the type of items. This is not part of the data model, but it is probably important to have this reflected in the edit forms, especially for the property section.
2. one other example is the need to adapt the 'step' part of the workflows forms, because even if a step could theoretically supports the same metadata than any other object/entity, only 'label', 'description' and 'related items' are actually displayed on the item view. Based on the discussions we had during T7.4 telcos, we feel a need to also have 'see also' displayed for a step - and maybe even 'media'
3. can we isolate the 'thumbnail' property from the other one in the edit forms? This property doesn't belong to any group ans is displayed in a very different way than the others.
4. we need some clarification regarding the properties recording time (cf.[ #78](https://gitlab.gwdg.de/sshoc/sshoc-marketplace/-/issues/78))
5. as 'description' allows markdown, we can add links, which is somehow redundant with the purpose of 'see also'. Is it a problem?
notify @edward.gray @nicolas.larrousse @frank.fischer01 @wytrazek @matej.durco @klaus.illmayer @stefan.probstBeta+https://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/62Create frontend for stage instance2021-07-01T11:48:27ZKlaus IllmayerCreate frontend for stage instanceAs described in the Redmine Issue 19194As described in the Redmine Issue 19194Stefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/63No Delete Button on Dev Instance for Moderators2021-08-05T14:39:05ZEdward GrayNo Delete Button on Dev Instance for Moderators# ๐ Bug Report
While signed in with the Moderator account, I am unable to find the option to delete an entry. is this normal? [here is the entry i tried this on](https://sshoc-marketplace.acdh-dev.oeaw.ac.at/tool-or-service/QeOTEF/versi...# ๐ Bug Report
While signed in with the Moderator account, I am unable to find the option to delete an entry. is this normal? [here is the entry i tried this on](https://sshoc-marketplace.acdh-dev.oeaw.ac.at/tool-or-service/QeOTEF/version/36228)
## ๐ค Expected Behavior
I would expect to find a button to delete an entry.
## ๐ฏ Current Behavior
I am unable to find a delete button.
---Curation module implementedMatej DurcoKlaus IllmayerStefan ProbstMichaล KozakMatej Durcohttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/64Choose a concept from a hierarchical vocabulary2022-01-27T13:46:28ZKlaus IllmayerChoose a concept from a hierarchical vocabularyWe do have some vocabularies, that do have a hierarchy, e.g. `discipline`. When adding a concept from such a hierarchy it shows up in the edit forms as a flat list. But for quality of input it would be good to see the hierarchy, otherwis...We do have some vocabularies, that do have a hierarchy, e.g. `discipline`. When adding a concept from such a hierarchy it shows up in the edit forms as a flat list. But for quality of input it would be good to see the hierarchy, otherwise it is only a good guess to find the best concept. If the hierarchy of the vocabulary could be shown in the drop-down-list, it would be easier to either drill down to a narrow concept or use the broader one.
In backend the hierarchy is implemented (have a look at `/api/vocabularies/discipline`) through the relations `narrower` and `broader` - it could be visualised like in the Skosmos view of https://vocabs.dariah.eu/oefos/en/ when clicking on `Hierarchy`, e.g. `6 Humanities` =narrower=> `604 Arts` =narrower=> `6040 Arts` =narrower=> `604029 Theatre studies`. Maybe a js-library could be used for this.
Opinions are welcome: @lbarbot @edward.gray @matej.durcoNow or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/65Show keywords on search result page2021-07-02T07:40:01ZKlaus IllmayerShow keywords on search result pageGo to the search result page of the stage-instance: the keywords are not shown in a proper way (you only see the separator `,`)Go to the search result page of the stage-instance: the keywords are not shown in a proper way (you only see the separator `,`)Stefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/66Change user role2021-07-02T06:31:35ZKlaus IllmayerChange user roleIt should be possible for Admins to change the user role of a user.It should be possible for Admins to change the user role of a user.Stefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/67Hidden properties are not shown for registered users2021-10-21T12:32:46ZKlaus IllmayerHidden properties are not shown for registered usersA property can be hidden then it will be not shown in the API output for not registered visitors. Registered users will instead get back the hidden properties from the API.
There seems to be another check implemented in the frontend, bec...A property can be hidden then it will be not shown in the API output for not registered visitors. Registered users will instead get back the hidden properties from the API.
There seems to be another check implemented in the frontend, because I'm not able to see the hidden properties in the detail page when I'm logged in.
I'm not 100% sure but I think it makes sense to show the hidden properties to the registered users (it is mostly curational information like that the accessibleAt produces a 404).
@stefan.probst Can you confirm, that you currently filter out the hidden properties?
@lbarbot @edward.gray @matej.durco Do we like to show the hidden properties to registered users like moderators?Michaล KozakMichaล Kozakhttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/68edit forms - recommended fields per item type2022-01-13T10:32:12ZLaure Barbotedit forms - recommended fields per item type(apologies if there is already an issue covering this topic somewhere else. I couldn't find it).
A few months ago, we've decided during a T7.2 telco to add/display some properties by default in the edit forms, depending on the type of i...(apologies if there is already an issue covering this topic somewhere else. I couldn't find it).
A few months ago, we've decided during a T7.2 telco to add/display some properties by default in the edit forms, depending on the type of item a user would like to create. The idea is that when clicking on "create a publication", all metadata fields that are mandatory and recommended for publications would be already present in the edit form, but with empty values.
Mandatory and recommended fields are given by the Editorial Guidelines - at the moment accessible [here](https://docs.google.com/document/d/12VmhR9W4mN7AaOlrZGG2YxCCCsZDbHkuoXjfqfDG4PA/edit#) and very soon displayed on the "contribute" pages. They are also listed here: https://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/blob/main/config/forms.json
notify @edward.gray @klaus.illmayer @matej.durcoFinal ReleaseStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/69Properties working together2021-08-06T07:07:44ZLaure BarbotProperties working togetherSome properties are linked/relate to each others. For example, `terms-of-use`, which is a string property, was designed to be used as a fallback option for `licence` that uses a vocabulary, if a user doesn't find the licence they were lo...Some properties are linked/relate to each others. For example, `terms-of-use`, which is a string property, was designed to be used as a fallback option for `licence` that uses a vocabulary, if a user doesn't find the licence they were looking for in the vocabulary.
Could we think of a more intuitive way to display these related fields? Is the indication of the fallback option in the help text enough?
Any opinion @edward.gray @klaus.illmayer @stefan.probst?https://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/70Source label consistency2021-10-25T14:27:13ZLaure BarbotSource label consistencySource label is an important aspect of our work and contributes to the trust users can have in our data. Source label appears on the item detail view, but also as facet in the search. Every source should be quickly describe in the [About...Source label is an important aspect of our work and contributes to the trust users can have in our data. Source label appears on the item detail view, but also as facet in the search. Every source should be quickly describe in the [About pages](https://sshoc-marketplace-stage.acdh-dev.oeaw.ac.at/about/service) & sources can also be partially [managed/edited via the editorial dashboard](https://sshoc-marketplace-stage.acdh-dev.oeaw.ac.at/account/sources) by Administrators.
A few suggestions to improve the consistency of source labels - gathering topics discussed in different ingest issues such as [#59](https://gitlab.gwdg.de/sshoc/data-ingestion/-/issues/59#note_300703) or [#8](https://gitlab.gwdg.de/sshoc/data-ingestion/-/issues/59#note_300703).
**Naming**
Source labels should be changed on dev and stage instances - or as part of the next ingest - based on the following:
- `TAPoR`
- Zotero - Parthenos should become `SSK Zotero resources`
- SSK should become `Standardization Survival Kit`
- `Humanities Data`
- `Programming Historian` should become `The Programming Historian`
- Switchboard should become `Language Resource Switchboard`
- SSHOC service catalogue `SSHopencloud service catalogue`
- DBLP should become `dblp: DH publications`
- EOSC Marketplace should become `EOSC catalogue`
- `CLARIN resource families` should be `CLARIN Resource Families`
- `DARIAH-CAMPUS`
**Front-end option**
Something suggested by @klaus.illmayer in another thread: "Maybe we should think about a brief description of the sources that can be shown by moving over them in the frontend (or something similar that is UX conform)?" I'm in favour of this and suggest the following texts:
- TAPoR -> `Text Analysis Portal for Research`
- SSK Zotero resources -> `Standardization Survival Kit Zotero library`
- Standardization Survival Kit -> `Standardization Survival Kit research scenarios and steps`
- Humanities Data -> `Humanitiesdata.com`
- The Programming Historian -> `The Programming Historian tutorials`
- Language Resource Switchboard -> `CLARIN Switchboard` @dieter and @alex would you prefer to see something else there?
- SSHopencloud service catalogue -> `services developed or enhanced within the SSHOC project`
- dblp: DH publications -> `DH Conferences abstracts`
- EOSC catalogue -> `EOSC catalogue & Marketplace`
- CLARIN Resource Families -> `language resources of the CLARIN infrastructure` @dieter and @alex - is it ok like this?
- DARIAH-CAMPUS -> `DARIAH learning resources`
@stefan.probst - would it be something that you could implement?
Any comments or suggestions for changes more than welcome!
notify also @matej.durco @edward.grayhttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/71Some externalIds are not shown in detail page2021-10-27T15:28:25ZKlaus IllmayerSome externalIds are not shown in detail page# ๐ Bug Report
We do have different `externalIds` for actors, e.g. `ORCID` but also `Twitter` and `GitHub` (see `GET api/actor-sources`). The ORCID is shown in the detail page but not Twitter, GitHub and the others.
## ๐ค Expected Behav...# ๐ Bug Report
We do have different `externalIds` for actors, e.g. `ORCID` but also `Twitter` and `GitHub` (see `GET api/actor-sources`). The ORCID is shown in the detail page but not Twitter, GitHub and the others.
## ๐ค Expected Behavior
Every `externalId` of an actor/contributor should be shown.
## ๐ฏ Current Behavior
Only the `ORCID` is currently shown as an icon. See as example on stage the item `training-material/ljss6D`. In `api/training-materials/ljss6D` you will see that the actor `James Baker` does not only have an ORCID but also a Twitter and a GitHub identifier. In the frontend only the ORCID is visible.
## Remarks
I guess this is related to the currently not implemented feature of having `urlTemplates` for the `externalIds`: https://gitlab.gwdg.de/sshoc/sshoc-marketplace/-/issues/80 (could be implemented today). But nevertheless, is there an idea how to show many externalIdentifiers for users? Should there be also an icon and if so, should that icon be part of the `api/actor-sources`-call?
---Now or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/72Editing actors from the edit form2021-12-06T10:52:06ZEdward GrayEditing actors from the edit formIssue reformulated based on the curation sprint (oct. 2021):
- access right: existing actors editing should be enabled for contributors via the edit forms.
- Edit forms: while on the edit form adding an actor, or editing an existing re...Issue reformulated based on the curation sprint (oct. 2021):
- access right: existing actors editing should be enabled for contributors via the edit forms.
- Edit forms: while on the edit form adding an actor, or editing an existing record
![image](/uploads/21c23fed3b6b5d93c585d1479406d0cd/image.png)
is there an "easy" way to grant access to the following screen (so far only accessible via the dashboard for moderators and administrators)?
![image](/uploads/bc258c82c25dac7968b56d5ed48de853/image.png)
Does it sound doable @stefan.probst ?
- Dashboard: I don't see the necessity to open the actors entry in the dashboard, because "mass curation" for actors could/should remain only for moderators and administrators.
![image](/uploads/9a7175ef2ac2ca9505a0259ae35a10ac/image.png)
In this situation it means that we don't have a proper curation workflow for actors (suggestion>moderation), but that moderators should be in charge of regularly cleaning the actors database. Any problem with this @edward.gray ? More thoughts needed to link the results of the actors curation notebooks (cf. https://gitlab.gwdg.de/sshoc/curation/-/issues/4 ) to the "actors" screen in the dashboard.
notify also @matej.durco @klaus.illmayer @frank.fischer01Stefan ProbstStefan Probst2022-03-15https://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/73Implement option to create candidate concepts2022-02-03T13:13:45ZMatej DurcoImplement option to create candidate conceptsSilent creation of previously inexistent concept in the edit-field of concept-based vocabulary
One implementation option is an "inserting autocomplete":
I.e. if the user enters a term in a concept-based field that does not exist in the ...Silent creation of previously inexistent concept in the edit-field of concept-based vocabulary
One implementation option is an "inserting autocomplete":
I.e. if the user enters a term in a concept-based field that does not exist in the vocabulary, this could be added "silently", or maybe after asking the user, if she really wants to add one.
It should be in any case added with "candidate" flag.
However this does not harmonize with the combobox-widget for concept-selection.
Therefore alternatively, offer a link/button: [Suggest concept], analogously to [add Actor] could be provided.Final ReleaseStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/74don't create multiple items via "save as draft"2022-01-13T08:41:34ZStefan Probstdon't create multiple items via "save as draft"in a "Create new item" form, we currently create multiple new items when a user clicks "Save as draft" multiple times, because each click will dispatch a POST request.
this needs to be changed so that only the first "Save as draft" clic...in a "Create new item" form, we currently create multiple new items when a user clicks "Save as draft" multiple times, because each click will dispatch a POST request.
this needs to be changed so that only the first "Save as draft" click dispatches as POST request, and subsequent clicks on "Save as draft" dispatch a PUT request with the id received from the initial POST.Final ReleaseStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/75Show concepts to media2021-09-30T15:04:39ZKlaus IllmayerShow concepts to mediaMedia can have dynamic properties (`media[].concept`) but they are currently not shown in the frontend. It would be especially necessary for the license-information. I've made an example on devel, see `api/tools-services/pYTFwz`
I think...Media can have dynamic properties (`media[].concept`) but they are currently not shown in the frontend. It would be especially necessary for the license-information. I've made an example on devel, see `api/tools-services/pYTFwz`
I think we don't have them on the mockups, can we introduce them nevertheless @stefan.probst ? Also adding @lbarbot @edward.gray into the discussionhttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/76sign-in screen - grey colors on Safari2021-10-01T07:01:42ZLaure Barbotsign-in screen - grey colors on SafariIs it supposed to be displayed with grey colours like in this screenshot (while using Safari 15.0)? I don't have the same screen with Firefox.
![image](/uploads/b8479a35ac663b016aa98be72cd73598/image.png)Is it supposed to be displayed with grey colours like in this screenshot (while using Safari 15.0)? I don't have the same screen with Firefox.
![image](/uploads/b8479a35ac663b016aa98be72cd73598/image.png)Stefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/77failed to fetch users2021-12-06T10:24:01ZLaure Barbotfailed to fetch userswhile working on the stage instance, with a moderator profile (log in with the local account 'Moderator') I got a red banner "failed to fetch users" when I work on the "items to moderate" section of the dashboard. It happens when I tick ...while working on the stage instance, with a moderator profile (log in with the local account 'Moderator') I got a red banner "failed to fetch users" when I work on the "items to moderate" section of the dashboard. It happens when I tick some boxes to select items.Final ReleaseMichaล KozakMichaล Kozakhttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/78UI for managing concepts2022-03-21T16:37:08ZMatej DurcoUI for managing conceptsRelated to #19.
I am afraid we need some UI components to maintain the vocabularies and (or at least) the concepts.
We will have option to add new concepts as of #73
but the moderators need to see the candidate concepts and approve the...Related to #19.
I am afraid we need some UI components to maintain the vocabularies and (or at least) the concepts.
We will have option to add new concepts as of #73
but the moderators need to see the candidate concepts and approve them, or merge them with existing concepts
(notify: @lbarbot, @klaus.illmayer, @stefan.probst)Now or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/79Draft items are not editable2021-10-15T14:06:19ZKlaus IllmayerDraft items are not editable# ๐ Bug Report
Creating a new item and saving it as draft. When later on editing this draft item again on "My account"=>"My draft items"=>"Edit" it will give a "page not found". In the console it says "404 Not Found" for https://sshoc-m...# ๐ Bug Report
Creating a new item and saving it as draft. When later on editing this draft item again on "My account"=>"My draft items"=>"Edit" it will give a "page not found". In the console it says "404 Not Found" for https://sshoc-marketplace.acdh-dev.oeaw.ac.at/workflow/[persistentId]/edit/draft
Additionally, I have one example (a draft only with a title and a description) where in the "My draft items" next to the title of the draft item there are brackets without a content: `Test Statuses ()`. I'm not sure what is creating these brackets, I didn't enter them (maybe the field version?).
And a last one: If in "My draft items" you don't click on "Edit" but on the title of the draft item, you will see the detail view of this item without an "Edit"-button but with an "History"-button. When clicking on this history button you run into an infinite wheel animation.
## ๐ค Expected Behavior
I like to edit my draft and see the edit forms.
I don't want brackets without content next to the title of my draft item.
I like to see the history of the draft item.
## ๐ฏ Current Behavior
I can't edit my draft.
I see brackets without content next ot the title of my draft item in the "My draft items"-list.
I don't see a history but instead an infinite wheel animation.
---Curation module implementedStefan ProbstStefan Probst