sshoc-marketplace-frontend issueshttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues2022-11-18T14:32:50Zhttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/125"My contributed items" does not show approved items to contributors2022-11-18T14:32:50ZKlaus Illmayer"My contributed items" does not show approved items to contributorsWhen suggesting an item as a contributor, this item will show up in the "My contributed items"-section in the "My account"-part. But when a moderator is approving this item, the item disappears from the "My contributed items"-section, as...When suggesting an item as a contributor, this item will show up in the "My contributed items"-section in the "My account"-part. But when a moderator is approving this item, the item disappears from the "My contributed items"-section, as the moderator is now the "owner" of the item. For a contributor it could be irritating to lose the connection to a contributed item. Imaging spending a lot of time to suggest a new item and then having no single access point where you can see all your contributed items. At least the label "My contributed items" needs to be reviewed for contributors, if we stay with the current approach.
Opinions? @matej.durco @lbarbot @edward.gray @stefan.probstStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/135"Report an issue" not available in the mobile version2022-12-05T16:43:37ZKlaus Illmayer"Report an issue" not available in the mobile version# 🐛 Bug Report
When going to the detail page of an item you can see in the Desktop version, that there is a `Report an issue` link in the top-right corner (next to "Sign in"). It redirect to the contact page having the category and pers...# 🐛 Bug Report
When going to the detail page of an item you can see in the Desktop version, that there is a `Report an issue` link in the top-right corner (next to "Sign in"). It redirect to the contact page having the category and persistent-id of the item filled out in the message body. Unfortunately, this `Report an issue` link is not visible/accessible in the mobile version of the marketplace.
It would be good to have this link somewhere available for mobile users. Any ideas where to show it @lbarbot @edward.gray ?
## 🤔 Expected Behavior
Having the option to report an issue on an item also in the mobile version.
## 😯 Current Behavior
The `report an issue` link does not show up in the mobile version.
## 🧭 How to reproduce
1. Look for any item
2. Open it on a desktop computer and you will see the `Report an issue` link
3. Open the same item on a mobile phone and you will not find the `Report an issue` link
---Stefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/99403 error for contributors on "my draft items" screen2022-04-20T06:47:00ZStefan Probst403 error for contributors on "my draft items" screenwhen submitting a draft item, we need to call `/commit` in addition to the PUT-request-with-request-body, so the stale draft version will be correctly cleaned up by the frontend.when submitting a draft item, we need to call `/commit` in addition to the PUT-request-with-request-body, so the stale draft version will be correctly cleaned up by the frontend.Now or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/94[forms] bug - dates for publications and datasets2022-01-14T10:59:08ZLaure Barbot[forms] bug - dates for publications and datasets# 🐛 Bug Report
When creating a new publication or dataset, fields `date created` and `date last updated` can be filled in.
![image](/uploads/4ef8cbfff92b37d4e364c3e4fbaf95fc/image.png)
When they are filled in, the submission of the i...# 🐛 Bug Report
When creating a new publication or dataset, fields `date created` and `date last updated` can be filled in.
![image](/uploads/4ef8cbfff92b37d4e364c3e4fbaf95fc/image.png)
When they are filled in, the submission of the item fails. If they are empty the submission of the item is possible.
## 🤔 Expected Behavior
The submission of the item should be possible, when these fields are completed.
## 😯 Current Behavior
@klaus.illmayer checked the logs yesterday when I was trying to create a new dataset, and here is the report:
`org.springframework.http.converter.HttpMessageNotReadableException: JSON parse error: Cannot deserialize value of type `java.time.ZonedDateTime` from String "2021-05-10": Failed to deserialize java.time.ZonedDateTime: (java.time.format.DateTimeParseException) Text '2021-05-10' could not be parsed at index 10; nested exception is com.fasterxml.jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `java.time.ZonedDateTime` from String "2021-05-10": Failed to deserialize java.time.ZonedDateTime: (java.time.format.DateTimeParseException) Text '2021-05-10' could not be parsed at index 10`
---Curation module implementedStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/50[forms] display error message when actor role field is empty2022-01-13T10:32:49ZLaure Barbot[forms] display error message when actor role field is empty# 🐛 Bug Report
<!--- Please provide a general summary of the issue. --> when adding an actor, if no actor role is chosen, the submit button is not available, which seems to indicate that an actor role is mandatory, but additional indica...# 🐛 Bug Report
<!--- Please provide a general summary of the issue. --> when adding an actor, if no actor role is chosen, the submit button is not available, which seems to indicate that an actor role is mandatory, but additional indications could clarify this.
## 🤔 Expected Behavior
<!--- Tell us what should happen. --> either have a "actor role is required" message or have by default a "contributor" role added
## 😯 Current Behavior
<!--- Tell us what happens instead of the expected behavior. --> no role is selected and no indication is given to the user that the actor role should be specified (except by the inactive "submit" button)
<!--- If you are seeing an error, please include the full error message. -->
---Final ReleaseStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/51[forms] training materials date created and last updated missing2021-03-17T15:49:53ZLaure Barbot[forms] training materials date created and last updated missing# 🐛 Bug Report
<!--- Please provide a general summary of the issue. --> should we not have the fields "date last updated" and "date created" displayed as well for training materials? (as it appears for datasets and publications)
## 🤔 E...# 🐛 Bug Report
<!--- Please provide a general summary of the issue. --> should we not have the fields "date last updated" and "date created" displayed as well for training materials? (as it appears for datasets and publications)
## 🤔 Expected Behavior
<!--- Tell us what should happen. -->
## 😯 Current Behavior
<!--- Tell us what happens instead of the expected behavior. -->
<!--- If you are seeing an error, please include the full error message. -->
---Curation module implementedKlaus IllmayerStefan ProbstKlaus Illmayerhttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/49[search page] scroll to top on facet change2021-03-17T14:34:35ZStefan Probst[search page] scroll to top on facet change# 🐛 Bug Report
when facet changes, page should scroll to top, see https://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/23
## 🤔 Expected Behavior
doesn't scroll
## 😯 Current Behavior
see above# 🐛 Bug Report
when facet changes, page should scroll to top, see https://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/23
## 🤔 Expected Behavior
doesn't scroll
## 😯 Current Behavior
see aboveStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/53actors information display2021-05-04T15:21:21ZLaure Barbotactors information display# 🐛 Bug Report
<!--- Please provide a general summary of the issue. --> we are collecting information about actors (IDs, website, email, affiliation) that are not shown in the item view detail, where only the name of an actor is display...# 🐛 Bug Report
<!--- Please provide a general summary of the issue. --> we are collecting information about actors (IDs, website, email, affiliation) that are not shown in the item view detail, where only the name of an actor is displayed and the associated website if any is also clickable from the name.
## 🤔 Expected Behavior
<!--- Tell us what should happen. -->
- Is it planned to implemented this part of the mockups, like it is suggested [here](https://xd.adobe.com/view/5308f6cf-f7db-4c47-5196-f3edfec15023-2539/screen/c914286c-e226-4795-9b57-fe6fbd3a6383) for example?
- could we add a clickable Orcid symbol near the name when we know the Orcid? A bit as it is displayed on [Zenodo for example](https://doi.org/10.5281/zenodo.3547648)?
## 😯 Current Behavior
<!--- Tell us what happens instead of the expected behavior. --> name of an actor is displayed and the associated website if any is also clickable from the name.
<!--- If you are seeing an error, please include the full error message. -->
---Curation module implementedStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/47Add help text to edit form fields2021-10-25T13:18:47ZLaure BarbotAdd help text to edit form fieldsIssue repurposed:
Add help text to edit form fields.Issue repurposed:
Add help text to edit form fields.Curation module implementedKlaus IllmayerStefan ProbstKlaus Illmayerhttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/5Agree on "basic metadata"2020-12-23T09:15:43ZMatej DurcoAgree on "basic metadata"We may promote two/three properties, to appear more prominently in the item view (both in the result-list and in detail view).
Candidates would be:
* `creator/contributor`
* `last updated`
* `activity_type`
(notify: @ymoranv, @sotiris....We may promote two/three properties, to appear more prominently in the item view (both in the result-list and in detail view).
Candidates would be:
* `creator/contributor`
* `last updated`
* `activity_type`
(notify: @ymoranv, @sotiris.karampatakis, @stefan.probst @mkozak, @tparkola, @lbarbot )2020-07-27https://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/48alphabetical order for the list of property types2021-09-03T12:19:02ZLaure Barbotalphabetical order for the list of property types# 🐛 Bug Report
<!--- Please provide a general summary of the issue. --> not a bug and I know that we will also introduce some changes soon in the way we are displaying properties (in the item detail view, so probably also in the edit fo...# 🐛 Bug Report
<!--- Please provide a general summary of the issue. --> not a bug and I know that we will also introduce some changes soon in the way we are displaying properties (in the item detail view, so probably also in the edit forms), but in the meantime would it be possible to order the list of property types available following an alphabetical order?
## 🤔 Expected Behavior
<!--- Tell us what should happen. --> it would be easier to choose a property type if the list was following an alphabetical order
## 😯 Current Behavior
<!--- Tell us what happens instead of the expected behavior. --> when clicking on "+ add property", the list behind "select an option" is randomly ordered which makes difficult for the user to have an overview of the options
<!--- If you are seeing an error, please include the full error message. -->
---Curation module implementedKlaus IllmayerStefan ProbstKlaus Illmayerhttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/85Approve/Reject buttons in moderation item view2022-01-13T08:41:13ZKlaus IllmayerApprove/Reject buttons in moderation item viewWhen moderators approve a suggested version of an item, they go to the curation dashboard `Items to moderate` and edit the chosen suggestion that should be approved.
Currently, there are three buttons: `Cancel`, `Save as draft` and `Pub...When moderators approve a suggested version of an item, they go to the curation dashboard `Items to moderate` and edit the chosen suggestion that should be approved.
Currently, there are three buttons: `Cancel`, `Save as draft` and `Publish`.
* `Publish` could be renamed to `Approve`, making it more clearer what is happening.
* `Save as draft` seems to me unnecessary (it would create a draft of this item in the moderators draft item list)
* `Cancel` returns to the main page, it will not reject the suggested version of the item
`Reject` does not exist but could be helpful to clean up the curation dashboard moderation items overview (and it would prevent that other moderators look into an already ignored version). To add reject function it would be necessary to add a new endpoint in the API by backend (DELETE a version of an item). Currently, the only way to get rid of a suggested item is either to approve another version of an item or to explicitely approve the current approved item (kind of workaround).
@lbarbot @edward.gray @matej.durco What are your opinions on the current state of the buttons and the necessity of a reject button?Final ReleaseStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/90Are contributors/authors sorted by alphabet?2022-01-13T07:04:16ZKlaus IllmayerAre contributors/authors sorted by alphabet?It seems to me that frontend orders actors in the detail page by alphabet. Take as example on the development frontend `/publication/y5hzLA`. In the API call `/api/publications/y5hzLA` and also at the source you see that `Yalemisew M. Ab...It seems to me that frontend orders actors in the detail page by alphabet. Take as example on the development frontend `/publication/y5hzLA`. In the API call `/api/publications/y5hzLA` and also at the source you see that `Yalemisew M. Abgaz` should be the first one (due to the surname) but due to a sorting algorithm on frontend the author becomes the last one. As especially for publications the sort order is important, I think the order should stay the way how it comes from the backend.
Asking @lbarbot @edward.gray if they disagreeStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/59autosuggest crashes when suggestion includes line break2021-08-05T14:42:41ZStefan Probstautosuggest crashes when suggestion includes line breakcurrently, some items have line breaks in their `label` (see https://gitlab.gwdg.de/sshoc/data-ingestion/-/issues/57), which is also returned from the autocomplete endpoint.
the combobox popup currently crashes in that case, because we ...currently, some items have line breaks in their `label` (see https://gitlab.gwdg.de/sshoc/data-ingestion/-/issues/57), which is also returned from the autocomplete endpoint.
the combobox popup currently crashes in that case, because we cannot use the `label` value as valid `data-key` attributehttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/2Basic detail view client-side2019-12-05T12:31:22ZMatej DurcoBasic detail view client-sideImplement a generic minimal detail view for items, comprising Title and a key-value table of properties.
No special requirements on design, but it needs to exhibit the functionality of being able to jump to related items. (e.g. Tool -> ...Implement a generic minimal detail view for items, comprising Title and a key-value table of properties.
No special requirements on design, but it needs to exhibit the functionality of being able to jump to related items. (e.g. Tool -> Tutorial)
Using the corresponding API-endpoint (for development no need to wait for the actual API-implementation sshoc-marketplace-backend#1, can rely on serving sample data from mock/test server)
Minimal viable productStefan ProbstStefan Probst2019-10-17https://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/1Basic search client side2019-12-04T19:41:04ZMatej DurcoBasic search client sideA minimal view with
* search bar
* rendering of the result set
* at least activity-type facet
Using the corresponding API-endpoint (serving sample data from mock/test server, independent of the server implementation)
Should show-cas...A minimal view with
* search bar
* rendering of the result set
* at least activity-type facet
Using the corresponding API-endpoint (serving sample data from mock/test server, independent of the server implementation)
Should show-case combination of full-text search with facet-filtering
No special requirements on the design, this will be applied once available.Minimal viable productStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/26Block search engines in robots.txt2021-05-20T13:59:27ZKlaus IllmayerBlock search engines in robots.txtAs it is alpha release we don't like to have the SSHOC MP showing up in search engines. Therefore a robots.txt should be put into the production frontend that disallows every bot. Blocking will be lifted likely with Beta release.As it is alpha release we don't like to have the SSHOC MP showing up in search engines. Therefore a robots.txt should be put into the production frontend that disallows every bot. Blocking will be lifted likely with Beta release.Stefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/127Browse keywords uses case-sensitive index2022-10-28T06:26:17ZKlaus IllmayerBrowse keywords uses case-sensitive indexWhen going to [browse keywords](https://marketplace.sshopencloud.eu/browse/keyword) there are due case-sensitiveness for some letters two indexes, e.g. there is `l` and a `L`. But the layout makes it that you don't see the difference in ...When going to [browse keywords](https://marketplace.sshopencloud.eu/browse/keyword) there are due case-sensitiveness for some letters two indexes, e.g. there is `l` and a `L`. But the layout makes it that you don't see the difference in the subheading, it looks always like upper-letter. In general, the feeling would be, that for creating the letter indexes, the case should be ignored, so that there is only one `L` with both the lower `l` and the upper `L` combined and sorted case-insensitive.
How do others feel? @lbarbot @stefan.probst (and I think this is not coming from backend, as `/api/item-search` don't give an option to order the delivered keywords, thus frontend does it by its own, right?)https://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/115bug - cms access2022-07-18T08:56:54ZLaure Barbotbug - cms accessafter login in with Gitlab via marketplace.sshopencloud.eu/admin#/ I end up with the following error:
![image](/uploads/c4d0e590bb32a43201c8077ac64f3c42/image.png)
Is it something that can be fixed soon, so that I can prepare the chang...after login in with Gitlab via marketplace.sshopencloud.eu/admin#/ I end up with the following error:
![image](/uploads/c4d0e590bb32a43201c8077ac64f3c42/image.png)
Is it something that can be fixed soon, so that I can prepare the changes/update of the static pages before the end of the month?
notify also @klaus.illmayerStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/116bug - my draft items - sorting by last modification2022-07-22T14:16:49ZLaure Barbotbug - my draft items - sorting by last modificationSorting by last modification doesn't seem to work well in the "my draft items" section. Items should be sorted the other way around!
![image](/uploads/35ec131b6ed661dfc6af642764829cf6/image.png)
(but ok on the "my contributed items" p...Sorting by last modification doesn't seem to work well in the "my draft items" section. Items should be sorted the other way around!
![image](/uploads/35ec131b6ed661dfc6af642764829cf6/image.png)
(but ok on the "my contributed items" page)Stefan ProbstStefan Probst