sshoc-marketplace-frontend issueshttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues2022-12-05T17:02:45Zhttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/136Saving a draft with externalId as a draft gives 5002022-12-05T17:02:45ZKlaus IllmayerSaving a draft with externalId as a draft gives 500# π Bug Report
Creating a draft item having an externalId and then again saving it as a draft gives a 500 error, when doing this in the frontend.
## π€ Expected Behavior
No 500 error, item should be saved again as a draft.
## π― Curren...# π Bug Report
Creating a draft item having an externalId and then again saving it as a draft gives a 500 error, when doing this in the frontend.
## π€ Expected Behavior
No 500 error, item should be saved again as a draft.
## π― Current Behavior
It gives a 500 error ```could not execute statement; SQL [n/a]; constraint [item_external_ids_identifier_service_code_identifier_item_i_key]; nested exception is org.hibernate.exception.ConstraintViolationException: could not execute statement```.
## π§ How to reproduce
(does only create a 500 when doing this on GUI)
1. Login
2. Create a new item, e.g. a tool
3. Enter a title, a description and an externalId, e.g. `Id service` "Wikidata" and `Identifier` "1234"
4. Save as draft
5. You will get a green successfully saved message and you stay in the edit form, now again "Save as draft" (you do not need to change anything)
6. You will get a "500 - Internal Server Error"
## Observations
It seems, that we have an issue here that concerns frontend as well as backend. If trying to reproduce the issue without frontend and using only API calls, it works as expected and don't give a 500. Therefore I looked into the calls that frontend creates and I see a difference, that also leads in the API calls to an error: When saving it the second time as a draft, I would call in the API (assuming `fNCigV` as the persistentId) `PUT /api/tools-services/fNCigV?draft=true` (that's the way that does not inflicts a 500 error) but the frontend calls `PUT /api/tools-services/fNCigV?persistentId=fNCigV&draft=true` and this prodcues a 500 error. I don't know, why frontend adds the parameter `persistentId=fNCigV` and I don't know, what backend does with this additional parameter (it is not documented in Swagger, I can only assume, that it tries to do something like a merge, as the mentioned error in the current behavior section is connected to the sql-error
```
DETAIL: Key (identifier_service_code, identifier, item_id)=(Wikidata, 1234, 48697) already exists.
STATEMENT: insert into item_external_ids (identifier, identifier_service_code, item_id, id) values ($1, $2, $3, $4)
```
Adding @stefan.probst for frontend, @tparkola for backend (what do you think, does it also sound like a backend error and should we create a dedicated issue?) and @lbarbot for reporting the error.
---Stefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/128vanishing values in concept-based fields2022-11-18T14:50:30ZLaure Barbotvanishing values in concept-based fieldswhile creating or enriching an exiting item via the edit form, there is a bug with some of the fields. It seems restricted to the concept-based fields.
I've managed to reproduce at least one case encountered today during the sprint, but...while creating or enriching an exiting item via the edit form, there is a bug with some of the fields. It seems restricted to the concept-based fields.
I've managed to reproduce at least one case encountered today during the sprint, but it might be that there are other cases I did not identify.
If a concept is chosen for a concept-based field (ex: "public" for intended audience), and some of the property lines above intended audience in the form are then deleted, the concept "public" disappears/vanishes from the field. Nevertheless it is still present and it doesn't prevent users to submit/save the item. Even when trying to select "public again, the concept continues to vanish if clicking somewhere else on the page.
looks very similar to https://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/83
notify also @klaus.illmayer @edward.grayStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/122Updating an External ID does create a new entry2022-11-18T14:45:06ZKlaus IllmayerUpdating an External ID does create a new entry# π Bug Report
I spot a wrong `External ID` of an entry. I go into the edit form and replace the wrong `Identifier` with the correct one. When publishing it, it will not replace the wrong identifier but instead create a new `External ID...# π Bug Report
I spot a wrong `External ID` of an entry. I go into the edit form and replace the wrong `Identifier` with the correct one. When publishing it, it will not replace the wrong identifier but instead create a new `External ID`.
## π€ Expected Behavior
When I replace the wrong `Identifier` of the `External ID` in the edit form and `Publish` it, I expect that only the `Identifier` of this `External ID` is changed.
## π― Current Behavior
Instead of changing the `Identifier` of the `External ID` it will create a new `External ID` with the changed `Identifier` and the wrong `External ID` stays untouched.
## π§ How to reproduce
1. Create as Moderator a new item (tool-or-service).
2. Add as `External ID` an entry with `ID Service` `GitHub` and with the `Identifier` `https://github.com/test` and `Publish`
3. Edit this new created item, look for the `External ID` created in 2 and change only the `Identifier` to `test`, finally `Publish`
4. You will see in the view form of the item that there are now two `External IDs`, one with `Identifier` `https://github.com/test` and one with `Identifier` `test`
Notify @lbarbot
---Stefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/83edit form - vanishing fields2022-11-16T18:54:04ZLaure Barbotedit form - vanishing fieldsspotted during the curation sprint:
while editing items - example /tool-or-service/yxZvbH on stage - some already existing fields appear empty even if they are not. A value can be selected but would vanish if clicking somewhere on the p...spotted during the curation sprint:
while editing items - example /tool-or-service/yxZvbH on stage - some already existing fields appear empty even if they are not. A value can be selected but would vanish if clicking somewhere on the page. This would not prevent the contributor to submit the form.
This bug has been noticed at least for Actors Name and Related Items.
It looks like this closed issue https://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/56
(notify also @edward.gray @buddenbohm @matej.durco @klaus.illmayer )Final ReleaseStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/127Browse keywords uses case-sensitive index2022-10-28T06:26:17ZKlaus IllmayerBrowse keywords uses case-sensitive indexWhen going to [browse keywords](https://marketplace.sshopencloud.eu/browse/keyword) there are due case-sensitiveness for some letters two indexes, e.g. there is `l` and a `L`. But the layout makes it that you don't see the difference in ...When going to [browse keywords](https://marketplace.sshopencloud.eu/browse/keyword) there are due case-sensitiveness for some letters two indexes, e.g. there is `l` and a `L`. But the layout makes it that you don't see the difference in the subheading, it looks always like upper-letter. In general, the feeling would be, that for creating the letter indexes, the case should be ignored, so that there is only one `L` with both the lower `l` and the upper `L` combined and sorted case-insensitive.
How do others feel? @lbarbot @stefan.probst (and I think this is not coming from backend, as `/api/item-search` don't give an option to order the delivered keywords, thus frontend does it by its own, right?)https://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/121Deleting of External ID does not work2022-10-25T10:00:32ZKlaus IllmayerDeleting of External ID does not work# π Bug Report
When trying to delete an `External ID` it does not work.
## π€ Expected Behavior
Deleting an `External ID` by clicking on `X Delete` in the edit view of an item and publishing it as a moderator should delete this `Extern...# π Bug Report
When trying to delete an `External ID` it does not work.
## π€ Expected Behavior
Deleting an `External ID` by clicking on `X Delete` in the edit view of an item and publishing it as a moderator should delete this `External ID`.
## π― Current Behavior
`External ID` is not deleted.
There is no error visible.
## π§ How to reproduce
1. Edit this tool as a moderator: https://marketplace.sshopencloud.eu/tool-or-service/ex6SOR/edit
2. Delete the `External ID` `GitHub https://github.com/craws/OpenAtlas` and `GitHub /craws/OpenAtlas` and `Publish` the item
3. It says "Successfully updated Tool or service" but the both deleted GitHub External IDs are still visible.
adding @lbarbot for confirmation of this bug
---Stefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/118Item giving 500 on Smartphone but not on PC2022-09-15T11:31:19ZKlaus IllmayerItem giving 500 on Smartphone but not on PC# π Bug Report
Go on startpage of marketplace (production), search for `helpdesk`, click in autocomplete on the `DARIAH-DE Helpdesk (CLARIAH-DE, Text+)` entry. This entry now shows up in the search results list. Click on it to see the d...# π Bug Report
Go on startpage of marketplace (production), search for `helpdesk`, click in autocomplete on the `DARIAH-DE Helpdesk (CLARIAH-DE, Text+)` entry. This entry now shows up in the search results list. Click on it to see the details. If you do this on a PC (I use the one at work, a Desktop PC, Linux, Firefox browser) you will see the detail page. If you do the same on a Smartphone (I have Android 10 and use the Firefox browser) you will not see the detail page but instead the screen is showing `500 - ref is not defined`.
## π€ Expected Behavior
Not only PC but also Smartphone should show the detail page.
## π― Current Behavior
PC does show the detail page but Smartphone not.
## π§ How to reproduce
See Bug Report description.
This bug was reported to us and I can reproduce it.
In the logfiles I see a warning coming most probably from Solr saying `Original query false: DARIAH-DE Helpdesk (CLARIAH-DE, Text+)
@stefan.probst Can you have a look if this is an issue by frontend? If not, we move it to backend.
---Stefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/28Mechanism to update content of static pages2022-07-28T14:43:12ZMatej DurcoMechanism to update content of static pagesSince we have no CMS, content is directly part of the code.
Should be made updateable by moderators.
We propose:
* Imprint: fetch template from https://shared.acdh.oeaw.ac.at/acdh-common-assets/api/data/ and inject specific content from...Since we have no CMS, content is directly part of the code.
Should be made updateable by moderators.
We propose:
* Imprint: fetch template from https://shared.acdh.oeaw.ac.at/acdh-common-assets/api/data/ and inject specific content from some config-file from sshoc-mp-frontend-repo
* everything else About, Contact, etc.: config-files (md, yaml, whatever) in sshoc-mp-frontend-repoBeta release (M24)Stefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/115bug - cms access2022-07-18T08:56:54ZLaure Barbotbug - cms accessafter login in with Gitlab via marketplace.sshopencloud.eu/admin#/ I end up with the following error:
![image](/uploads/c4d0e590bb32a43201c8077ac64f3c42/image.png)
Is it something that can be fixed soon, so that I can prepare the chang...after login in with Gitlab via marketplace.sshopencloud.eu/admin#/ I end up with the following error:
![image](/uploads/c4d0e590bb32a43201c8077ac64f3c42/image.png)
Is it something that can be fixed soon, so that I can prepare the changes/update of the static pages before the end of the month?
notify also @klaus.illmayerStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/109video display - bug?2022-06-17T14:40:56ZLaure Barbotvideo display - bug?I've tried several options with the links to be added to display video coming from Youtube, but it seems that the embed link is not working - see here: https://marketplace.sshopencloud.eu/training-material/uwJTCy
@stefan.probst , any r...I've tried several options with the links to be added to display video coming from Youtube, but it seems that the embed link is not working - see here: https://marketplace.sshopencloud.eu/training-material/uwJTCy
@stefan.probst , any recommendations on the url format to add while adding media coming from Youtube?Stefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/110links are not rendered in search results2022-06-16T19:23:55ZAlexander KΓΆniglinks are not rendered in search resultsAs can be seen in this screenshot, while links are rendered perfectly fine in the item view, they look weird in the search result view.
![image](/uploads/ceda800cfd9790db8465e29047221e81/image.png)As can be seen in this screenshot, while links are rendered perfectly fine in the item view, they look weird in the search result view.
![image](/uploads/ceda800cfd9790db8465e29047221e81/image.png)https://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/108OpenGraph metadata of landing pages should be item specific2022-04-30T19:30:38ZCarsten ThielOpenGraph metadata of landing pages should be item specificThe metadata in the `<meta>` properties `og:title` and `og:description` should match the regular `title` and `description`.
These are used by e.g. Slack previews (https://medium.com/slack-developer-blog/everything-you-ever-wanted-to-kno...The metadata in the `<meta>` properties `og:title` and `og:description` should match the regular `title` and `description`.
These are used by e.g. Slack previews (https://medium.com/slack-developer-blog/everything-you-ever-wanted-to-know-about-unfurling-but-were-afraid-to-ask-or-how-to-make-your-e64b4bb9254). ![Screenshot_2022-04-28_at_10.11.14](/uploads/b5b8e5f3e08d9711f1a4fc11aba962bf/Screenshot_2022-04-28_at_10.11.14.png)https://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/107little bug on displaying number of items per source2022-04-27T10:11:44ZLaure Barbotlittle bug on displaying number of items per sourceon the search screen, when extending the source list, the number of items for Language Resource Switchboard (51) and SSHopencloud service catalogue (18) is rendered in a weird way, on two lines.
![grafik](/uploads/8cb2d7558b4fa730e51d61...on the search screen, when extending the source list, the number of items for Language Resource Switchboard (51) and SSHopencloud service catalogue (18) is rendered in a weird way, on two lines.
![grafik](/uploads/8cb2d7558b4fa730e51d617959d5cd0c/grafik.png)
is it something that can easily be fixed @stefan.probst ?Stefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/99403 error for contributors on "my draft items" screen2022-04-20T06:47:00ZStefan Probst403 error for contributors on "my draft items" screenwhen submitting a draft item, we need to call `/commit` in addition to the PUT-request-with-request-body, so the stale draft version will be correctly cleaned up by the frontend.when submitting a draft item, we need to call `/commit` in addition to the PUT-request-with-request-body, so the stale draft version will be correctly cleaned up by the frontend.Now or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/106edit steps of workflows saved as draft2022-04-13T07:07:36ZLaure Barbotedit steps of workflows saved as draft# π Bug Report
when creating a workflow and its steps, and saving as draft the whole thing, there is a problem to re-access and edit the steps.
## π€ Expected Behavior
If I access a workflow from "my draft items" and want to edit step...# π Bug Report
when creating a workflow and its steps, and saving as draft the whole thing, there is a problem to re-access and edit the steps.
## π€ Expected Behavior
If I access a workflow from "my draft items" and want to edit steps before submitting the workflow to moderation or publishing it, the "edit" button is not clickable
## π― Current Behavior
the edit button on the screen below doesn't "answer"
![image](/uploads/9652bb381e14088d0845d716072912e9/image.png)
## π§ How to reproduce
<!--- Please provide directions how the issue can be reproduced. -->
1. create a workflow
2. create a step
3. save as draft
4. access the workflow from "my draft items"
5. go to workflow steps page
6. click on "edit" step
---
notify @klaus.illmayer @edward.gray @matej.durcoNow or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/58Multi-select values in dynamic properties2022-04-08T06:41:25ZMatej DurcoMulti-select values in dynamic propertiesmockups propose a multi-select for defining multiple concepts per dynamic property.
Example: if I want to enter 10 "activity" concepts, I have to add 10 new properties and select activity for each one of them.
(notify: @klaus.illmayer,...mockups propose a multi-select for defining multiple concepts per dynamic property.
Example: if I want to enter 10 "activity" concepts, I have to add 10 new properties and select activity for each one of them.
(notify: @klaus.illmayer, @lbarbot )Now or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/105signing in banner - stage instance tests2022-04-08T06:38:05ZLaure Barbotsigning in banner - stage instance tests# π Bug Report
The "sign in" banner doesn't disappear and masks the access to the menu.
## π€ Expected Behavior
Once successfully logged in, the banner should disappear.
## π― Current Behavior
![image](/uploads/2e3e3c3d0485d7a0b129830...# π Bug Report
The "sign in" banner doesn't disappear and masks the access to the menu.
## π€ Expected Behavior
Once successfully logged in, the banner should disappear.
## π― Current Behavior
![image](/uploads/2e3e3c3d0485d7a0b129830b2d6f831c/image.png)
---Now or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/103sync client state between browser tabs2022-03-30T15:23:43ZStefan Probstsync client state between browser tabscurrently, client state is not synced between browser tabs. that means that e.g. with a "moderate items" screen in one tab, and a review form in another, approving an item in one tab will *not* remove it from the items-to-moderate list i...currently, client state is not synced between browser tabs. that means that e.g. with a "moderate items" screen in one tab, and a review form in another, approving an item in one tab will *not* remove it from the items-to-moderate list in the other tab, which is confusing. consider using `BroadcastChannel` to sync.https://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/101small changes in the footer2022-03-30T15:21:14ZLaure Barbotsmall changes in the footerTo prepare the post-project phase, would it be possible to make some changes in the footer section currently displaying the EU flag and the following statement: "The SSH Open Marketplace is developed as part of the "Social Sciences and H...To prepare the post-project phase, would it be possible to make some changes in the footer section currently displaying the EU flag and the following statement: "The SSH Open Marketplace is developed as part of the "Social Sciences and Humanities Open Cloud' SSHOC project, European Union"s Horizon 2020 project call H2020-INFRAEOSC-04-2018, grant agreement #823782."?
We would need to add three logos: DARIAH, CLARIN and CESSDA (probably on the right side). And to slightly modify the sentence: "The SSH Open Marketplace has been developed as part of the "Social Sciences and Humanities Open Cloud' SSHOC project, European Union"s Horizon 2020 project call H2020-INFRAEOSC-04-2018, grant agreement #823782. It is maintained and will be further developed by three European Research Infrastructures - DARIAH, CLARIN and CESSDA - and their national partners."
@edward.gray @matej.durco @klaus.illmayer - any comments or alternative suggestions?Now or neverStefan ProbstStefan Probsthttps://gitlab.gwdg.de/sshoc/sshoc-marketplace-frontend/-/issues/100remove "deprecated" checkbox on the items-to-moderate screen2022-03-30T14:52:23ZStefan Probstremove "deprecated" checkbox on the items-to-moderate screenremove "deprecated" checkbox on the items-to-moderate screen, because depreacted items are actually removed from the solr-index, which is used for `d.status=` queries.remove "deprecated" checkbox on the items-to-moderate screen, because depreacted items are actually removed from the solr-index, which is used for `d.status=` queries.