Commit fbceafab authored by dindigala's avatar dindigala
Browse files

refactor: renaming and addressing the review comments

parent 8d35274a
Pipeline #209795 passed with stages
in 5 minutes and 38 seconds
...@@ -284,7 +284,7 @@ As a rule of thumb, each key with a boolean value (e.g. *true* or *false*) defau ...@@ -284,7 +284,7 @@ As a rule of thumb, each key with a boolean value (e.g. *true* or *false*) defau
"rtl": false, "rtl": false,
"lang": "en-us", "lang": "en-us",
"standalone": true, "standalone": true,
"projectheader": { "breadcrumbNavigation": {
"search": "https://subugoe.pages.gwdg.de/ahiqar/website/search.html", "search": "https://subugoe.pages.gwdg.de/ahiqar/website/search.html",
"show": true, "show": true,
"title_homePage_key": "title_homePage", "title_homePage_key": "title_homePage",
...@@ -422,7 +422,7 @@ As a rule of thumb, each key with a boolean value (e.g. *true* or *false*) defau ...@@ -422,7 +422,7 @@ As a rule of thumb, each key with a boolean value (e.g. *true* or *false*) defau
Defaults to `true` Defaults to `true`
- **projectheader** - **breadcrumbNavigation**
- **search** - **search**
......
...@@ -16,7 +16,6 @@ ...@@ -16,7 +16,6 @@
:panels="panels" :panels="panels"
:projectcolors="config.colors" :projectcolors="config.colors"
:standalone="config.standalone" :standalone="config.standalone"
:projectheader="config.projectheader"
/> />
<q-page-container class="root"> <q-page-container class="root">
......
<template> <template>
<div <div
class="projectheader q-py-xs" class="q-py-xs"
:class="$q.dark.isActive ? 'bg-white text-black' : 'bg-accent'"
> >
<div class="content"> <div class="content">
<q-breadcrumbs <q-breadcrumbs
...@@ -19,11 +18,11 @@ ...@@ -19,11 +18,11 @@
:icon="fasHome" :icon="fasHome"
> >
<a <a
:href="`${projectheader.website}`" :href="`${config.breadcrumbNavigation.website}`"
:class="$q.dark.isActive ? 'text-black' : 'text-white'" :class="$q.dark.isActive ? 'text-black' : 'text-white'"
class="header-links" class="header-links"
> >
{{ $t(`${projectheader.title_homePage_key}`) }} {{ $t(`${config.breadcrumbNavigation.title_homePage_key}`) }}
</a> </a>
</q-breadcrumbs-el> </q-breadcrumbs-el>
...@@ -32,7 +31,7 @@ ...@@ -32,7 +31,7 @@
:icon="fasSearch" :icon="fasSearch"
> >
<a <a
:href="`${projectheader.search}`" :href="`${config.breadcrumbNavigation.search}`"
:class="$q.dark.isActive ? 'text-black' : 'text-white'" :class="$q.dark.isActive ? 'text-black' : 'text-white'"
class="header-links" class="header-links"
> >
...@@ -42,7 +41,7 @@ ...@@ -42,7 +41,7 @@
<q-breadcrumbs-el <q-breadcrumbs-el
:class="$q.dark.isActive ? 'text-black' : 'text-white'" :class="$q.dark.isActive ? 'text-black' : 'text-white'"
:label="$t(`${projectheader.title_viewer_key}`)" :label="$t(`${config.breadcrumbNavigation.title_viewer_key}`)"
:icon="fasFileAlt" :icon="fasFileAlt"
/> />
</q-breadcrumbs> </q-breadcrumbs>
...@@ -59,9 +58,9 @@ import { ...@@ -59,9 +58,9 @@ import {
} from '@quasar/extras/fontawesome-v5'; } from '@quasar/extras/fontawesome-v5';
export default { export default {
name: 'ProjectHeader', name: 'BreadcrumbNavigation',
props: { props: {
projectheader: { config: {
type: Object, type: Object,
required: true, required: true,
}, },
...@@ -87,13 +86,6 @@ export default { ...@@ -87,13 +86,6 @@ export default {
text-decoration: none; text-decoration: none;
} }
.projectheader {
@media (prefers-color-scheme: dark) {
background-color: var(--q-color-white);
color: var(--q-color-dark);
}
}
.q-breadcrumbs__el-icon { .q-breadcrumbs__el-icon {
font-size: 100% !important; font-size: 100% !important;
} }
......
<template> <template>
<q-header :class="$q.dark.isActive ? 'bg-dark' : 'bg-secondary text-primary'"> <q-header :class="$q.dark.isActive ? 'bg-dark' : 'bg-secondary text-primary'">
<ProjectHeader <div
v-if="config.projectheader.show" v-if="config.breadcrumbNavigation.show"
:projectheader="projectheader" :class="$q.dark.isActive ? 'bg-white text-black' : 'bg-accent'"
>
<BreadCrumbNavigation
:config="config"
/> />
</div>
<div class="header__wrap"> <div class="header__wrap">
<q-toolbar v-if="config['header_section'].titles"> <q-toolbar v-if="config['header_section'].titles">
<TitleBar <TitleBar
...@@ -55,7 +59,7 @@ ...@@ -55,7 +59,7 @@
<script> <script>
import Navbar from '@/components/navbar.vue'; import Navbar from '@/components/navbar.vue';
import ProjectHeader from '@/components/projectheader.vue'; import BreadCrumbNavigation from '@/components/breadcrumbnavigation.vue';
import TitleBar from '@/components/titlebar.vue'; import TitleBar from '@/components/titlebar.vue';
import TogglePanels from '@/components/togglebar/togglePanels.vue'; import TogglePanels from '@/components/togglebar/togglePanels.vue';
import Tools from '@/components/tools.vue'; import Tools from '@/components/tools.vue';
...@@ -66,7 +70,7 @@ export default { ...@@ -66,7 +70,7 @@ export default {
Navbar, Navbar,
TitleBar, TitleBar,
TogglePanels, TogglePanels,
ProjectHeader, BreadCrumbNavigation,
Tools, Tools,
}, },
props: { props: {
...@@ -108,10 +112,6 @@ export default { ...@@ -108,10 +112,6 @@ export default {
default: () => {}, default: () => {},
}, },
standalone: Boolean, standalone: Boolean,
projectheader: {
type: Object,
default: () => {},
},
}, },
}; };
</script> </script>
......
...@@ -117,7 +117,7 @@ ...@@ -117,7 +117,7 @@
"rtl": false, "rtl": false,
"lang": "en-us", "lang": "en-us",
"standalone": true, "standalone": true,
"projectheader": { "breadcrumbNavigation": {
"search": "https://subugoe.pages.gwdg.de/ahiqar/website/search.html", "search": "https://subugoe.pages.gwdg.de/ahiqar/website/search.html",
"show": true, "show": true,
"title_homePage_key": "title_homePage", "title_homePage_key": "title_homePage",
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment