Skip to content
Snippets Groups Projects

Tweaks to export system that simplify usage in user-defined types

Merged Philip Bittihn requested to merge exporttweaks into dev
All threads resolved!

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Philip Bittihn added 1 commit

    added 1 commit

    • 4b9b639b - Fix inconsistent generic definitions of deserialize

    Compare with previous version

  • Philip Bittihn added 1 commit

    added 1 commit

    • 802613ee - Define export system constants early, so they can be used everywhere

    Compare with previous version

  • Philip Bittihn added 1 commit

    added 1 commit

    • 3877e6aa - first versions of serializetodict and deserializefromdict

    Compare with previous version

  • Philip Bittihn added 1 commit

    added 1 commit

    • ff7d1f01 - deserialize: forgot to commit removal of superfluous definition

    Compare with previous version

  • Philip Bittihn added 1 commit

    added 1 commit

    • c0678653 - @exportrecursive: Use new dict serialization functions

    Compare with previous version

  • Philip Bittihn added 1 commit

    added 1 commit

    • ed75cde3 - Remove outdated genexport warning from docs

    Compare with previous version

    • Resolved by Philip Bittihn

      In principle, after we merge this and tag a new InPartS version, we could change the custom distribution serialization in all the particle parameters to @exportrecursive. @lhupe Where do we want to include the legacy loading, the only difference being that the type is saved in dict["distributionType"] instead of dict["_type"]? We could define a special case for deserializefromdict for <:Distribution in legacy.jl or (perhaps better) directly in ColonyGrowthModels, so it doesn't pollute our generic code. Or do you envision a different solution?

  • Philip Bittihn added 1 commit

    added 1 commit

    • 7da82f7e - Remove references to "params" from serialization docs (scalar export can be any type).

    Compare with previous version

  • Philip Bittihn added 1 commit

    added 1 commit

    • 87ff06d0 - further serialization docs tweaking

    Compare with previous version

  • Philip Bittihn resolved all threads

    resolved all threads

  • Philip Bittihn marked this merge request as ready

    marked this merge request as ready

  • Lukas Hupe approved this merge request

    approved this merge request

  • Lukas Hupe mentioned in commit 609a4035

    mentioned in commit 609a4035

  • merged

  • Please register or sign in to reply
    Loading