Skip to content
Snippets Groups Projects
Commit c59321df authored by Simon Sendler's avatar Simon Sendler :turtle: Committed by Ubbo Veentjer
Browse files

Apply 3 suggestion(s) to 1 file(s)

parent 862766e5
No related branches found
No related tags found
1 merge request!77Resolve "Code Quality"
Pipeline #297597 passed
......@@ -15,14 +15,14 @@ needed for the MR to pass review.
1. An issue should be existing, briefly stating what is missing or should be changed.
2. If a developer decides to work on this issue, the "Create merge request" button at the issue view can be used.
This creates a branch with a meaningful name related to the issue and a merge request (MR). The MR has draft status
This creates a branch with a meaningful name related to the issue, and a merge request (MR). The MR has draft status
by default. (This step matches the GitLab Flow.)
3. The branch can be checked out locally, changes can be commited there. After some time the feature
3. The branch can be checked out locally, changes can be commited there. After some time, the feature
(e.g. a new chapter or text change) is finished and should be merged into the main branch.
4. Now the draft status of the MR is removed and everybody who should review the text is requested to do so.
GitLab-CE allows to assign one person for reviewing the MR. This means that this
person has to approve the MR, otherwise the merge cannot commence. Other people relevant for the MR
can be "mentioned" in a comment, so they are notified by email of this MR. The developer should notify the `MUST`
can be "mentioned" in a comment, so they are notified of this MR by email. The developer should notify the `MUST`
assignee personally (in case they don't notice the notification by GitLab).
5. The `MUST` assignee reviews the changes regarding style, understandability, grammar and spelling, etc.
If everything is to their liking, they approve the MR. The people mentionened in the comments are free to review
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment