Skip to content
Snippets Groups Projects
  • robinwilliam.hundt's avatar
    8ea40eca
    Fixed randomly failing subscription test · 8ea40eca
    robinwilliam.hundt authored
    The issue was that
    ```python
    	 response = client.post(
                f'/api/feedback/', {
                    "score": 23,
                    "of_submission": response.data['submission']['pk'],
                    "feedback_lines": {
                        2: {"text": "< some string >"},
                        3: {"text": "< some string >"}
                    }
                }
            )
            self.assertEqual(status.HTTP_201_CREATED, response.status_code)
    ```
    would sometimes get the one submission that only had 2 lines (since submission distribution hasn't been randomized for long, this issue didn't come up earlier) and thus fail as it should.
    I changed the commented line to 1 and 2 in the POST. This should fix the issue.
    8ea40eca
    History
    Fixed randomly failing subscription test
    robinwilliam.hundt authored
    The issue was that
    ```python
    	 response = client.post(
                f'/api/feedback/', {
                    "score": 23,
                    "of_submission": response.data['submission']['pk'],
                    "feedback_lines": {
                        2: {"text": "< some string >"},
                        3: {"text": "< some string >"}
                    }
                }
            )
            self.assertEqual(status.HTTP_201_CREATED, response.status_code)
    ```
    would sometimes get the one submission that only had 2 lines (since submission distribution hasn't been randomized for long, this issue didn't come up earlier) and thus fail as it should.
    I changed the commented line to 1 and 2 in the POST. This should fix the issue.