robinwilliam.hundt authored 5 years ago and Dominik Seeger committed 5 years ago

Also in the Feedbackhistory it is now possible to filter by excluding labels.
This way, a user can filter for all Submissions did not compile but were not empty

Also removed a bunch of unnecessary code and extracted the test runner into https://gitlab.gwdg.de/grady-corp/grady-test-runner

blub

Removed unused frontend dependency

Dominik Seeger authored 6 years ago and robinwilliam.hundt committed 6 years ago

added instance export e2e test

Swapped Logout button and slot postion

Logout is now always a the far left

e2e tests are now using one browser instance per TestClass

Statistics endpoint now checks if there are submissiontypes available

Fixed race cond. in e2e test and bug in stats endpoint

Added function_tests to flake8 check

Added id "logout" to logout button

Using --cache-from in build step

Increased implicit wait for e2e test

# The first commit's message is:
Added tests for Frontpages

# The 2nd commit message will be skipped:

#	Added tests for Frontpages

# The 3rd commit message will be skipped:

#	Fixed tests failing in ci
#
#	Possibly due to weak password, since CI tests use live settings

* Set the STOP_ON_PASS setting in the grady/settings/instance.py
* Currently uses signals and does not check if the feedback is final
  or not.
* Feedback is validated until the end
* Minor fixes in the importer

Also changed the length restriction of the StudentInfo.matrikel_no to 30

* Also restructured the converter script so it handles
  mixed (gap and source code) export files as well
* Added a sad hack that enables using a base url

* Added more tests for feedback view

* Now each view is included in one file that are held in the
  package views instead of using one big file

* Did the same this for serializers

* Now using ListSerializer to implement the custom behaviour

* Also refactored the feedback serializers and models and
  removed the FeedbackLine model

* The serializers are simpler now

* Renamed 'is_final' on FeedbackComment to 'visible_to_student'

Fixed reverse query bug in Subscription model
Fixed bug in subscription view resulting in uncaught exception
Creating a subscription with a query/key/stage combination for which no assignments were available would result in an uncaught SubscriptionEnded exception and a 500 response to the client. Instead an error message with the status code 410_GONE is now sent.

Fixed reverse query bug in Subscription model

chnaged
type_query_mapper = {
	...
        SUBMISSION_TYPE_QUERY: 'type__title',
    }

to
type_query_mapper = {
        SUBMISSION_TYPE_QUERY: 'type__name',
    }

Refactored serializer id fields and camelCase names

To provide a uniform api and to save us from further work i've refactored the existing fields that used
camelCase names to use the names specified in the models (which are kebab-case).
Also everywhere where id's (whether normal or uuid ones) have been included in the serializers, the field names have been changed to 'pk' or '<model>_pk'. Pk will always link to the primary key of the model and will save us great pain should we decide to convert the pk's of more models to uuid's. Also we won't have to remebre a bunch of different ways of referring to the id for the frontend, it's always pk.
I also included the pk field in all modelserializers since this will be necessary for the frontend state management.

Frontend now expects pk fields and snake_case

Solution is highlighted / Desc. HTML is rendered

Frontend test is only manually run

Added vue-notification library

Inactivity detection preperly implementd

Client inactivity is now properly detected. A vuex plugin is used to store the time of the last commited mutation. This roughly equals the last user interaction.
If the users session is expired he will be redirected to the login page. Before that a dialog is displayed notifieng the user that they are about to be logged out.

Added created / of_tutor info to feedback comment

* Tests can now be executed from the importer
* All jobs run fine and produce correct results

Feedback model no longer contains fields text, of_tutor, modified since this information is stored inside the FeedbackComments
The serializer, views and tests dependant on these fields have been adjusted

* Fixed errors that arose from merging errors
* Added feedback to mock data so student page works
* Student serializer now only send necessary submission info on initial load

robinwilliam.hundt authored 7 years ago and Jan Maximilian Michal committed 7 years ago

 * Defnied more APIendpoints for feedback and subscriptions
 * Added the feedback spec to the docs folder
 * Removed tutor and reviewer model. Closes #43 and #68

* The mechanism proposed should work as follows:
  * Tutors can subscribe to certain submission categries (currently
    this includes exam, student or type specific submissions).
    If the set of submissions to corrent is small (student) all
    submissions of that category are reserved for that tutor.
  * A reviewer should also be able to subscribe other users (delegation)
  * A subscription contains assignments or creates them:
    * Only one assignment per user may be active.
    * No new assignments can be added to a subscription after it was
      created while another assignment is present for that subscription.
    * An assignment delegates a submission to a tutor.
    * An active assignment indicates that the tutor is working on that
      assignment
    * After an assignment was finished it is deleted (or archived).
* Upgraded to Django 2.0
* Closes #66, #53.

* The mechanism remains partially incomplete as the progress in
  !67-create-new-model-feedbackline-and-integrate-it is blocking
  progress. Several tests for the API endpoint need to be written
  including. More validation and constraints might have to be added.

Restructured front end code into components and pages
Components should be as dumb and generic as possible. Pages should dispatch actions, pass props to components etc,
Student page now gets submission and submissiontyp from api and displays those to the student
Added information which submissions have been viewed

All the methods in core.tests.data_factories have been deleted and the tests using those are now using the improved make_test_data method from util.factories.
Curiously the tests are running considerably faster on my machine now

Closes #29.