* All views (except the feedback view) do not have a N+1 issue
* Some serializer method fields are now precomputed in annotations
* TODO: Automate the performance tests to ensure performance stays high
* Ran isort

* Set the STOP_ON_PASS setting in the grady/settings/instance.py
* Currently uses signals and does not check if the feedback is final
  or not.
* Feedback is validated until the end
* Minor fixes in the importer

Also changed the length restriction of the StudentInfo.matrikel_no to 30

* Reviewer feedback cannot be edited by tutors (despite assignments)
* Tutors can always edit feedback for which they have an assignment
* Reviewer is allowed to change anything anytime

Changed jwt auth endpoints

`/api-token-auth/` to `/api/get-token/`
`/api-token-refresh/` to `/api/refresh-token/`

Added student list page

Added submission serializer for student list view

Bare student list view is now implemented for the reviewer
He is able to view a searchable and sortable list of all students in the left pane of the window and their submissions on the right side

Fixed /?#/ bug on login page

Added `feedback_created`/`feedback_validated` counts to TutorSerializer

Added basic tutor overview

Added student overview help card

When going to the student overview page, a help card is shown on the right side which is replaced when viewing a submission

* 'submission_pk' -> 'submission' on AssignmentSerializer
* subscription now uniformly use the private key of a model
  that they want to receive submissions from
* introduced remaining and available fields on subscription
* query key and type are now checked

* It is now possible to 'deactivate subscriptions via the delete
  http verb
* This is not exactly what was specified in #92 but should achieve
  the same result. Instead of introducing a depleted field,
  subscriptions can distinguish if they are fully depleted or just
  temporarily. The method does not involve any overhead.
* Refactorings in the subscription model to increase readability
* Creating a subscription does not have side effects (creates no
  assignment)

Other minor changes

* Assignments are now implicitly checked if feedback is created
* using the assignment endpoint to create subscriptions instead of
  subscription endpoint

Closes #93 and #92.

* Added more tests for feedback view

* Now each view is included in one file that are held in the
  package views instead of using one big file

* Did the same this for serializers

* Now using ListSerializer to implement the custom behaviour

* Also refactored the feedback serializers and models and
  removed the FeedbackLine model

* The serializers are simpler now

* Renamed 'is_final' on FeedbackComment to 'visible_to_student'

See #90 for Problem with ExamType subscriptions

Fixed reverse query bug in Subscription model
Fixed bug in subscription view resulting in uncaught exception
Creating a subscription with a query/key/stage combination for which no assignments were available would result in an uncaught SubscriptionEnded exception and a 500 response to the client. Instead an error message with the status code 410_GONE is now sent.

Fixed reverse query bug in Subscription model

chnaged
type_query_mapper = {
	...
        SUBMISSION_TYPE_QUERY: 'type__title',
    }

to
type_query_mapper = {
        SUBMISSION_TYPE_QUERY: 'type__name',
    }

Refactored serializer id fields and camelCase names

To provide a uniform api and to save us from further work i've refactored the existing fields that used
camelCase names to use the names specified in the models (which are kebab-case).
Also everywhere where id's (whether normal or uuid ones) have been included in the serializers, the field names have been changed to 'pk' or '<model>_pk'. Pk will always link to the primary key of the model and will save us great pain should we decide to convert the pk's of more models to uuid's. Also we won't have to remebre a bunch of different ways of referring to the id for the frontend, it's always pk.
I also included the pk field in all modelserializers since this will be necessary for the frontend state management.

Frontend now expects pk fields and snake_case

Solution is highlighted / Desc. HTML is rendered

Frontend test is only manually run

Added vue-notification library

Inactivity detection preperly implementd

Client inactivity is now properly detected. A vuex plugin is used to store the time of the last commited mutation. This roughly equals the last user interaction.
If the users session is expired he will be redirected to the login page. Before that a dialog is displayed notifieng the user that they are about to be logged out.

Added created / of_tutor info to feedback comment

Feedback model no longer contains fields text, of_tutor, modified since this information is stored inside the FeedbackComments
The serializer, views and tests dependant on these fields have been adjusted

* Added stages to the subscription mechanism, meaning that
  a subscription is distingushed between feedback-creation,
  -validation and -conflict resolution
* Minor refactoring to the Feedback ViewSet and serializer
* Added a larger integration test

* Feedback consists of lines which can hold up to three comments
* The Feedback model contains almost no logic since all has been
  migrated to the assignemnt mechanism

robinwilliam.hundt authored 7 years ago and Jan Maximilian Michal committed 7 years ago

 * Defnied more APIendpoints for feedback and subscriptions
 * Added the feedback spec to the docs folder
 * Removed tutor and reviewer model. Closes #43 and #68

* The mechanism proposed should work as follows:
  * Tutors can subscribe to certain submission categries (currently
    this includes exam, student or type specific submissions).
    If the set of submissions to corrent is small (student) all
    submissions of that category are reserved for that tutor.
  * A reviewer should also be able to subscribe other users (delegation)
  * A subscription contains assignments or creates them:
    * Only one assignment per user may be active.
    * No new assignments can be added to a subscription after it was
      created while another assignment is present for that subscription.
    * An assignment delegates a submission to a tutor.
    * An active assignment indicates that the tutor is working on that
      assignment
    * After an assignment was finished it is deleted (or archived).
* Upgraded to Django 2.0
* Closes #66, #53.

* The mechanism remains partially incomplete as the progress in
  !67-create-new-model-feedbackline-and-integrate-it is blocking
  progress. Several tests for the API endpoint need to be written
  including. More validation and constraints might have to be added.

* removing prospector as it is not compatible with latest version of flake8
* introducting a new CI job that runs flake8 and actually fails if there are any errors

* IT waS A FUCKIng tyPO
* ran isort and flake8 and fixed reported issues

* no url configuration needed simply register viewset with router
* now using DefaultRouter, meaning api root is now browsable
* merged some views
* makes it easier to include api schema later
* Ran isort and updated docstring

to User model

- It is now possible to run tests in the frontend.
- The backend authentication uses AbstractUser instead of
AbsstractBaseuser

- ran isort to properly sort imports
- reformatter some classes

Added has_perm() and has_module_perm() to UserAccount model. Both return is_superuser . This allows superusers to access AdminPanel.

AdminPanel now displays usernames in User ListView.