Thilo Wischmeyer authored 4 years ago and Dominik Seeger committed 4 years ago

- The dialog now has an absolute max-width in order to make it readable on
  smaller screens.
- The dialog has a fixed height, which makes the transition from the GDPR
  screen to the registration form less jarring.
- Buttons have more consistent styling.

also fixed bug with auto logout

Also UserAccounts can now be added to groups and assignments can be filtered based on groups

Tutors and reviewers can now add comments to individual lines of the provided solution. The comments are short polled.

... also bumped minimum importer version to 3.0.0

robinwilliam.hundt authored 5 years ago and Dominik Seeger committed 5 years ago

Also in the Feedbackhistory it is now possible to filter by excluding labels.
This way, a user can filter for all Submissions did not compile but were not empty

blub

* All views (except the feedback view) do not have a N+1 issue
* Some serializer method fields are now precomputed in annotations
* TODO: Automate the performance tests to ensure performance stays high
* Ran isort

* Set the STOP_ON_PASS setting in the grady/settings/instance.py
* Currently uses signals and does not check if the feedback is final
  or not.
* Feedback is validated until the end
* Minor fixes in the importer

Also changed the length restriction of the StudentInfo.matrikel_no to 30

* 'submission_pk' -> 'submission' on AssignmentSerializer
* subscription now uniformly use the private key of a model
  that they want to receive submissions from
* introduced remaining and available fields on subscription
* query key and type are now checked

* It is now possible to 'deactivate subscriptions via the delete
  http verb
* This is not exactly what was specified in #92 but should achieve
  the same result. Instead of introducing a depleted field,
  subscriptions can distinguish if they are fully depleted or just
  temporarily. The method does not involve any overhead.
* Refactorings in the subscription model to increase readability
* Creating a subscription does not have side effects (creates no
  assignment)

Other minor changes

* Assignments are now implicitly checked if feedback is created
* using the assignment endpoint to create subscriptions instead of
  subscription endpoint

Closes #93 and #92.

* Added more tests for feedback view

* Now each view is included in one file that are held in the
  package views instead of using one big file

* Did the same this for serializers

* Now using ListSerializer to implement the custom behaviour

* Also refactored the feedback serializers and models and
  removed the FeedbackLine model

* The serializers are simpler now

* Renamed 'is_final' on FeedbackComment to 'visible_to_student'

* Tests can now be executed from the importer
* All jobs run fine and produce correct results

Feedback model no longer contains fields text, of_tutor, modified since this information is stored inside the FeedbackComments
The serializer, views and tests dependant on these fields have been adjusted

* Added stages to the subscription mechanism, meaning that
  a subscription is distingushed between feedback-creation,
  -validation and -conflict resolution
* Minor refactoring to the Feedback ViewSet and serializer
* Added a larger integration test

* Feedback consists of lines which can hold up to three comments
* The Feedback model contains almost no logic since all has been
  migrated to the assignemnt mechanism

robinwilliam.hundt authored 7 years ago and Jan Maximilian Michal committed 7 years ago

 * Defnied more APIendpoints for feedback and subscriptions
 * Added the feedback spec to the docs folder
 * Removed tutor and reviewer model. Closes #43 and #68

* The mechanism proposed should work as follows:
  * Tutors can subscribe to certain submission categries (currently
    this includes exam, student or type specific submissions).
    If the set of submissions to corrent is small (student) all
    submissions of that category are reserved for that tutor.
  * A reviewer should also be able to subscribe other users (delegation)
  * A subscription contains assignments or creates them:
    * Only one assignment per user may be active.
    * No new assignments can be added to a subscription after it was
      created while another assignment is present for that subscription.
    * An assignment delegates a submission to a tutor.
    * An active assignment indicates that the tutor is working on that
      assignment
    * After an assignment was finished it is deleted (or archived).
* Upgraded to Django 2.0
* Closes #66, #53.

* The mechanism remains partially incomplete as the progress in
  !67-create-new-model-feedbackline-and-integrate-it is blocking
  progress. Several tests for the API endpoint need to be written
  including. More validation and constraints might have to be added.

The project has been refactored so far as the current state of master has been placed under backend/ .
Some changes to the .gitignore and Makefile have been made to accomodate this refactor.

and closes #23. Other minor changes.