robinwilliam.hundt authored 5 years ago and Dominik Seeger committed 5 years ago

Also removed path endpoint for this model since it wasnt used

Removed unused frontend dependency

* All views (except the feedback view) do not have a N+1 issue
* Some serializer method fields are now precomputed in annotations
* TODO: Automate the performance tests to ensure performance stays high
* Ran isort

The reviewer has the option to activate and deactivate all students access via the web interface in the student overview. The corresponding endpoints are additional list routes on the student viewset. Tests are in test_reviewer_viewset.py

Only Comments that are `visible_to_student=True` will be serialized. For some weird reason i had to resort to a little hack in the serializer, see the comment inside the `get_feedback_lines()` method of the serializer for context.
I choose to not remove Feedback that is not final from the response of the student submissions endpoint (as outlined in #91) and will instead show a message in the frontend. This is easier to implement and potentially better for debugging in the frontend.

Fixed subscription deletion

Added welcome Jumbotron with some nice info/links

Some work on start page

Added feedback_stage_for_user to feedback serializer

This field will contain the feedback stage of the subscription for which the requesting user has created this feedback. This is needed to correctly give the choice to set the final attribute in the frontend.

Fix final checkbox frontend

Fix disappearing names in feedback list

Student names in Subscription list for reviewer

Short polling on orig Feedback

Refresh button student list

FeedbackComment visiblity indication

SubscriptionEnded page

Right side of student overview is sticky

Statistics overview

Implemented Feedback History Table incl. search

Side Note: When searching the table, should the resulting filtered arr be <= than size 10 all those submissions will be prefetched if not already present and the user is able to instantanously view the submission. NICE!

Added Tests and sticky beahvior for feedback hist

Inactive subscriptions are shown

Added subscription refresh button

Fixed jwt refresh and auto logout

Added feedback link

Visual cue of final status in student overview

Correct Student for reviewer

* Reviewer feedback cannot be edited by tutors (despite assignments)
* Tutors can always edit feedback for which they have an assignment
* Reviewer is allowed to change anything anytime

* Also made minor modifications to assignment endpoint

* 'submission_pk' -> 'submission' on AssignmentSerializer
* subscription now uniformly use the private key of a model
  that they want to receive submissions from
* introduced remaining and available fields on subscription
* query key and type are now checked

* It is now possible to 'deactivate subscriptions via the delete
  http verb
* This is not exactly what was specified in #92 but should achieve
  the same result. Instead of introducing a depleted field,
  subscriptions can distinguish if they are fully depleted or just
  temporarily. The method does not involve any overhead.
* Refactorings in the subscription model to increase readability
* Creating a subscription does not have side effects (creates no
  assignment)

Other minor changes

* Assignments are now implicitly checked if feedback is created
* using the assignment endpoint to create subscriptions instead of
  subscription endpoint

Closes #93 and #92.

* Added more tests for feedback view

* Now each view is included in one file that are held in the
  package views instead of using one big file

* Did the same this for serializers

* Now using ListSerializer to implement the custom behaviour

* Also refactored the feedback serializers and models and
  removed the FeedbackLine model

* The serializers are simpler now

* Renamed 'is_final' on FeedbackComment to 'visible_to_student'