robinwilliam.hundt authored 5 years ago and Dominik Seeger committed 5 years ago

Also removed path endpoint for this model since it wasnt used

also some quality of life ui improvements

* All views (except the feedback view) do not have a N+1 issue
* Some serializer method fields are now precomputed in annotations
* TODO: Automate the performance tests to ensure performance stays high
* Ran isort

* This means a 2x - 10x performace boost especially for the student
  and the feedback endpoint

Implemented Feedback History Table incl. search

Side Note: When searching the table, should the resulting filtered arr be <= than size 10 all those submissions will be prefetched if not already present and the user is able to instantanously view the submission. NICE!

Added Tests and sticky beahvior for feedback hist

Inactive subscriptions are shown

Added subscription refresh button

Fixed jwt refresh and auto logout

Added feedback link

Visual cue of final status in student overview

Correct Student for reviewer

* Reviewer feedback cannot be edited by tutors (despite assignments)
* Tutors can always edit feedback for which they have an assignment
* Reviewer is allowed to change anything anytime

* 'submission_pk' -> 'submission' on AssignmentSerializer
* subscription now uniformly use the private key of a model
  that they want to receive submissions from
* introduced remaining and available fields on subscription
* query key and type are now checked

* It is now possible to 'deactivate subscriptions via the delete
  http verb
* This is not exactly what was specified in #92 but should achieve
  the same result. Instead of introducing a depleted field,
  subscriptions can distinguish if they are fully depleted or just
  temporarily. The method does not involve any overhead.
* Refactorings in the subscription model to increase readability
* Creating a subscription does not have side effects (creates no
  assignment)

Other minor changes

* Assignments are now implicitly checked if feedback is created
* using the assignment endpoint to create subscriptions instead of
  subscription endpoint

Closes #93 and #92.

* Added more tests for feedback view

* Now each view is included in one file that are held in the
  package views instead of using one big file

* Did the same this for serializers

* Now using ListSerializer to implement the custom behaviour

* Also refactored the feedback serializers and models and
  removed the FeedbackLine model

* The serializers are simpler now

* Renamed 'is_final' on FeedbackComment to 'visible_to_student'

The project has been refactored so far as the current state of master has been placed under backend/ .
Some changes to the .gitignore and Makefile have been made to accomodate this refactor.