robinwilliam.hundt authored 5 years ago and Dominik Seeger committed 5 years ago

Also in the Feedbackhistory it is now possible to filter by excluding labels.
This way, a user can filter for all Submissions did not compile but were not empty

robinwilliam.hundt authored 5 years ago and Dominik Seeger committed 5 years ago

Also removed path endpoint for this model since it wasnt used

also some quality of life ui improvements

blub

Removed unused frontend dependency

Dominik Seeger authored 6 years ago and robinwilliam.hundt committed 6 years ago

added tests for new instance export

The former student data endpoint /export/csv/ has been replaces by /export/json/ .
This new endpoint exports the data as normal json. It also allows the client to send setPasswords: true as an option which will results in random passwords beign generated for all students and included in the export data.

Solution is no longer displayed on student page because it may contain grading information which has been changed during the grading process and would thus confuse the student

Made another mistake with  the tests, this commit should fix it.

Endpoint offers detail endpoint /change_password/
Endpoint offers list endpoint /me/

* All views (except the feedback view) do not have a N+1 issue
* Some serializer method fields are now precomputed in annotations
* TODO: Automate the performance tests to ensure performance stays high
* Ran isort

* Set the STOP_ON_PASS setting in the grady/settings/instance.py
* Currently uses signals and does not check if the feedback is final
  or not.
* Feedback is validated until the end
* Minor fixes in the importer

Also changed the length restriction of the StudentInfo.matrikel_no to 30

The reviewer has the option to activate and deactivate all students access via the web interface in the student overview. The corresponding endpoints are additional list routes on the student viewset. Tests are in test_reviewer_viewset.py

Only Comments that are `visible_to_student=True` will be serialized. For some weird reason i had to resort to a little hack in the serializer, see the comment inside the `get_feedback_lines()` method of the serializer for context.
I choose to not remove Feedback that is not final from the response of the student submissions endpoint (as outlined in #91) and will instead show a message in the frontend. This is easier to implement and potentially better for debugging in the frontend.

The issue was that
```python
	 response = client.post(
            f'/api/feedback/', {
                "score": 23,
                "of_submission": response.data['submission']['pk'],
                "feedback_lines": {
                    2: {"text": "< some string >"},
                    3: {"text": "< some string >"}
                }
            }
        )
        self.assertEqual(status.HTTP_201_CREATED, response.status_code)
```
would sometimes get the one submission that only had 2 lines (since submission distribution hasn't been randomized for long, this issue didn't come up earlier) and thus fail as it should.
I changed the commented line to 1 and 2 in the POST. This should fix the issue.

Implemented Feedback History Table incl. search

Side Note: When searching the table, should the resulting filtered arr be <= than size 10 all those submissions will be prefetched if not already present and the user is able to instantanously view the submission. NICE!

Added Tests and sticky beahvior for feedback hist

Inactive subscriptions are shown

Added subscription refresh button

Fixed jwt refresh and auto logout

Added feedback link

Visual cue of final status in student overview

Correct Student for reviewer

* Reviewer feedback cannot be edited by tutors (despite assignments)
* Tutors can always edit feedback for which they have an assignment
* Reviewer is allowed to change anything anytime