Skip to content
Snippets Groups Projects
  1. Feb 18, 2018
  2. Feb 17, 2018
  3. Feb 16, 2018
  4. Feb 15, 2018
  5. Feb 11, 2018
  6. Feb 10, 2018
    • Jan Maximilian Michal's avatar
      Fixed the update method in FeedbackSerializer · 2b7d27d3
      Jan Maximilian Michal authored
      * Also made minor modifications to assignment endpoint
      2b7d27d3
    • Jan Maximilian Michal's avatar
      Migrated everything to UUID fields for primary keys · d62e564c
      Jan Maximilian Michal authored
      * 'submission_pk' -> 'submission' on AssignmentSerializer
      * subscription now uniformly use the private key of a model
        that they want to receive submissions from
      * introduced remaining and available fields on subscription
      * query key and type are now checked
      d62e564c
    • Jan Maximilian Michal's avatar
      Subscription enhancements · d1cf3af2
      Jan Maximilian Michal authored
      * It is now possible to 'deactivate subscriptions via the delete
        http verb
      * This is not exactly what was specified in #92 but should achieve
        the same result. Instead of introducing a depleted field,
        subscriptions can distinguish if they are fully depleted or just
        temporarily. The method does not involve any overhead.
      * Refactorings in the subscription model to increase readability
      * Creating a subscription does not have side effects (creates no
        assignment)
      
      Other minor changes
      
      * Assignments are now implicitly checked if feedback is created
      * using the assignment endpoint to create subscriptions instead of
        subscription endpoint
      
      Closes #93 and #92.
      d1cf3af2
  7. Feb 08, 2018
  8. Feb 07, 2018
    • robinwilliam.hundt's avatar
      subscription Sidebar component / Routing rework · d53deb54
      robinwilliam.hundt authored
      Routing is ow dynmacilly handled by selector components. E.g. the LayoutSelector will render as the correct Layout depending on the logged in users role. This allows to simply route to e.g. '/home/ and the StartPageSelector will determine if StudentPage or TutorStartPage should be displayed.
      d53deb54
    • Jan Maximilian Michal's avatar
      Refactores views and serializers added patch methods · 00ea2ff6
      Jan Maximilian Michal authored
      * Added more tests for feedback view
      
      * Now each view is included in one file that are held in the
        package views instead of using one big file
      
      * Did the same this for serializers
      
      * Now using ListSerializer to implement the custom behaviour
      
      * Also refactored the feedback serializers and models and
        removed the FeedbackLine model
      
      * The serializers are simpler now
      
      * Renamed 'is_final' on FeedbackComment to 'visible_to_student'
      00ea2ff6
  9. Feb 06, 2018
  10. Feb 05, 2018
  11. Feb 04, 2018
    • robinwilliam.hundt's avatar
      Student page is fixed. Subscription & Feedback creation partially working · 32dd9a3f
      robinwilliam.hundt authored
      Fixed reverse query bug in Subscription model
      Fixed bug in subscription view resulting in uncaught exception
      Creating a subscription with a query/key/stage combination for which no assignments were available would result in an uncaught SubscriptionEnded exception and a 500 response to the client. Instead an error message with the status code 410_GONE is now sent.
      
      Fixed reverse query bug in Subscription model
      
      chnaged
      type_query_mapper = {
      	...
              SUBMISSION_TYPE_QUERY: 'type__title',
          }
      
      to
      type_query_mapper = {
              SUBMISSION_TYPE_QUERY: 'type__name',
          }
      
      Refactored serializer id fields and camelCase names
      
      To provide a uniform api and to save us from further work i've refactored the existing fields that used
      camelCase names to use the names specified in the models (which are kebab-case).
      Also everywhere where id's (whether normal or uuid ones) have been included in the serializers, the field names have been changed to 'pk' or '<model>_pk'. Pk will always link to the primary key of the model and will save us great pain should we decide to convert the pk's of more models to uuid's. Also we won't have to remebre a bunch of different ways of referring to the id for the frontend, it's always pk.
      I also included the pk field in all modelserializers since this will be necessary for the frontend state management.
      
      Frontend now expects pk fields and snake_case
      
      Solution is highlighted / Desc. HTML is rendered
      
      Frontend test is only manually run
      
      Added vue-notification library
      
      Inactivity detection preperly implementd
      
      Client inactivity is now properly detected. A vuex plugin is used to store the time of the last commited mutation. This roughly equals the last user interaction.
      If the users session is expired he will be redirected to the login page. Before that a dialog is displayed notifieng the user that they are about to be logged out.
      
      Added created / of_tutor info to feedback comment
      32dd9a3f
  12. Jan 26, 2018
  13. Jan 14, 2018
    • robinwilliam.hundt's avatar
      Cleaned up Feedback Model · a105465d
      robinwilliam.hundt authored
      Feedback model no longer contains fields text, of_tutor, modified since this information is stored inside the FeedbackComments
      The serializer, views and tests dependant on these fields have been adjusted
      a105465d
  14. Jan 10, 2018
  15. Jan 05, 2018
    • Jan Maximilian Michal's avatar
      Delete delbert.py · 4eb7b424
      Jan Maximilian Michal authored
      4eb7b424
    • Jan Maximilian Michal's avatar
    • robinwilliam.hundt's avatar
      Added first integration tests (of many to follow) · ce91bfda
      robinwilliam.hundt authored and Jan Maximilian Michal's avatar Jan Maximilian Michal committed
       * Defnied more APIendpoints for feedback and subscriptions
       * Added the feedback spec to the docs folder
       * Removed tutor and reviewer model. Closes #43 and #68
      ce91bfda
    • Jan Maximilian Michal's avatar
      Started with a new mechanism to assign work to tutors · a32636f9
      Jan Maximilian Michal authored
      * The mechanism proposed should work as follows:
        * Tutors can subscribe to certain submission categries (currently
          this includes exam, student or type specific submissions).
          If the set of submissions to corrent is small (student) all
          submissions of that category are reserved for that tutor.
        * A reviewer should also be able to subscribe other users (delegation)
        * A subscription contains assignments or creates them:
          * Only one assignment per user may be active.
          * No new assignments can be added to a subscription after it was
            created while another assignment is present for that subscription.
          * An assignment delegates a submission to a tutor.
          * An active assignment indicates that the tutor is working on that
            assignment
          * After an assignment was finished it is deleted (or archived).
      * Upgraded to Django 2.0
      * Closes #66, #53.
      
      * The mechanism remains partially incomplete as the progress in
        !67-create-new-model-feedbackline-and-integrate-it is blocking
        progress. Several tests for the API endpoint need to be written
        including. More validation and constraints might have to be added.
      a32636f9
Loading