Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
grady
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Jan Maximilian Michal
grady
Merge requests
!176
Resolve "Sort updated comments chronoligically"
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Resolve "Sort updated comments chronoligically"
167-sort-updated-comments-chronoligically
into
master
Overview
0
Commits
4
Pipelines
6
Changes
1
Merged
Dominik Seeger
requested to merge
167-sort-updated-comments-chronoligically
into
master
5 years ago
Overview
0
Commits
4
Pipelines
6
Changes
1
Expand
Closes
#167 (closed)
Edited
5 years ago
by
robinwilliam.hundt
0
0
Merge request reports
Viewing commit
d3bc9db6
Prev
Next
Show latest version
1 file
+
4
−
5
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
d3bc9db6
wip on tests
· d3bc9db6
Dominik Seeger
authored
5 years ago
functional_tests/test_feedback_creation.py
+
4
−
5
Options
@@ -227,8 +227,7 @@ class UntestedParent:
self
.
_login
()
go_to_subscription
(
self
)
score_input
=
self
.
browser
.
find_element_by_id
(
'
score-input
'
)
score_input
.
send_keys
(
self
.
sub_type
.
full_score
)
self
.
browser
.
find_element_by_id
(
'
score-full
'
).
click
()
# give feedback on first line
self
.
write_comments_on_lines
([(
1
,
'
first ever comment
'
)])
@@ -249,6 +248,7 @@ class UntestedParent:
go_to_subscription
(
self
,
stage
=
'
validate
'
)
self
.
write_comments_on_lines
([(
1
,
'
the second comment
'
)])
self
.
browser
.
find_element_by_id
(
'
score-full
'
).
click
()
self
.
browser
.
find_element_by_class_name
(
'
final-checkbox
'
).
click
()
self
.
browser
.
find_element_by_id
(
'
submit-feedback
'
).
click
()
sub_url
=
'
subscription/
'
+
str
(
self
.
sub_type
.
pk
)
+
'
/ended
'
@@ -258,9 +258,8 @@ class UntestedParent:
self
.
_login
()
# goto history
score_input
=
self
.
browser
.
find_element_by_id
(
'
score-input
'
)
score_input
.
send_keys
(
self
.
sub_type
.
full_score
)
self
.
browser
.
find_element_by_link_text
(
'
Feedback History
'
).
click
()
self
.
browser
.
find_element_by_class_name
(
'
feedback_row
'
).
click
()
# validate that second comment is under the first comment
Loading