Skip to content
Snippets Groups Projects

WIP: Submission notes

Closed Jan Maximilian Michal requested to merge submission-notes into master
All threads resolved!

Closes #44 (closed)

Edited by robinwilliam.hundt

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jan Maximilian Michal
  • I understand that we might need all that font crap, but can't we install that stuff with node instead of spamming our repo?

  • Since only you are working on this branch you might be able to either commit a merge request from master or rebase. We will just reset out branches to the origin version.

  • Ja, sehr fett! This provides one of the core mechanisms of Grady, a great enhancement over the legacy version and proves that the refactor/rewrite was worth the effort.

  • I understand that we might need all that font crap, but can't we install that stuff with node instead of spamming our repo?

    The Readme pages of those dependencys didn't mention a way to install via npm/yarn so i didn't think about it. However I looke now and they're available at google-code-prettify and font-awesome. I'll be able to change it probably on Sunday/Monday.

    Since only you are working on this branch you might be able to either commit a merge request from master or rebase. We will just reset out branches to the origin version.

    I'm not sure what exactly you mean by that, but maybe you can explain it to me tomorrow :smile:

  • Will do! Sorry for being cryptic.

  • added 2 commits

    • 87e99e9d - Added /public/ to backend/.gitignore
    • b9c3a0d8 - Changed from static files to node dependencys

    Compare with previous version

  • added 1 commit

    • a38a6e88 - Created new vuex store module for submission-notes

    Compare with previous version

  • added 1 commit

    • 1595dd48 - Added static folder because it broke build

    Compare with previous version

  • added 1 commit

    • bcb1db4f - Submitted feedback is now stored inside the store

    Compare with previous version

  • mentioned in issue #63 (closed)

  • Jan Maximilian Michal resolved all discussions

    resolved all discussions

  • robinwilliam.hundt changed the description

    changed the description

  • Already merged into the branch associated with #22 (closed).

  • Jan Maximilian Michal mentioned in merge request !22 (closed)

    mentioned in merge request !22 (closed)

  • Jan Maximilian Michal mentioned in merge request !23 (merged)

    mentioned in merge request !23 (merged)

  • Please register or sign in to reply
    Loading