Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
grady
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Jan Maximilian Michal
grady
Merge requests
!232
Resolve "Filtering FeedbackHistory not working correctly"
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Resolve "Filtering FeedbackHistory not working correctly"
226-filtering-feedbackhistory-not-working-correctly
into
master
Overview
0
Commits
1
Pipelines
2
Changes
1
Merged
Dominik Seeger
requested to merge
226-filtering-feedbackhistory-not-working-correctly
into
master
4 years ago
Overview
0
Commits
1
Pipelines
2
Changes
1
Expand
Closes
#226 (closed)
Edited
4 years ago
by
Dominik Seeger
0
0
Merge request reports
Compare
master
master (base)
and
latest version
latest version
a8c3e49a
1 commit,
4 years ago
1 file
+
2
−
1
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
frontend/src/store/modules/feedback_list/feedback-table.ts
+
2
−
1
Options
@@ -41,7 +41,8 @@ function SET_FEEDBACK_HISTORY (state: FeedbackTableState, val: Array<Feedback>)
state
.
feedbackHist
=
objectifyArray
(
feedbackList
,
'
ofSubmission
'
)
}
function
ADD_ASSIGNMENTS_INFO
(
state
:
FeedbackTableState
,
assignments
:
Array
<
Assignment
>
)
{
for
(
const
assignment
of
assignments
)
{
const
doneAssignments
=
assignments
.
filter
(
assignment
=>
assignment
.
isDone
)
for
(
const
assignment
of
doneAssignments
)
{
if
(
!
assignment
.
submission
||
!
assignment
.
stage
)
{
throw
Error
()
}
Loading