Skip to content

ENH: Add filter form for rules

spreckelsen4 requested to merge f-checklist into master

Summary

Add advanced filtering options to the webinterface.

Focus

A new script for filtering, filter_rules.py has been added and the submission form has been added to compass.js.

Test Environment

Check out local-texting-checklist for local testing or check out num.umg.eu where I checked out this branch for testing. If you test it locally, you have to execute grant_anonymous_permissions.sh once for the anonymous user to be allowed to execute the filtering script.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Merge request reports