Skip to content
Snippets Groups Projects
Commit a329bef1 authored by Ashwin Kumar Karnad's avatar Ashwin Kumar Karnad
Browse files

Merge branch 'improve-git-branch-test' into 'force-checking-of-error-code'

improvements to test

See merge request mpsd-cs/mpsd-software-environments!16
parents ba04c14e 1e5dac30
No related branches found
No related tags found
3 merge requests!19Move linux-debian11 into main,!16improvements to test,!9force `subprocess.run` to check return code is 0
Pipeline #368551 passed
This commit is part of merge request !9. Comments created here will be created in the context of that merge request.
...@@ -89,17 +89,18 @@ def test_prepare_environment(tmp_path): ...@@ -89,17 +89,18 @@ def test_prepare_environment(tmp_path):
assert release_base_dir.exists() assert release_base_dir.exists()
# check for spack-environments directory # check for spack-environments directory
assert spack_environments in os.listdir(release_base_dir) assert spack_environments in os.listdir(release_base_dir)
# check if the git branch is correctly checked out
assert ( # check if the git branch is correctly checked out. We expect output such as
subprocess.run( # git_branch_stdout = '* dev-23a\n develop\n'
f"cd {str(release_base_dir/spack_environments)} && git branch", # The entry with the '* ' prefix is the active branch.
shell=True, git_branch_output_raw = subprocess.run(
capture_output=True, f"cd {str(release_base_dir/spack_environments)} && git branch",
) shell=True,
.stdout.decode("utf-8") capture_output=True,
.split("\n")[0]
== f"* {mpsd_release_to_test}"
) )
git_branch_stdout = git_branch_output_raw.stdout.decode("utf-8")
assert f"* {mpsd_release_to_test}" in git_branch_stdout
# check that result is a list and contains atleast ['global','foss2021a-mpi'] # check that result is a list and contains atleast ['global','foss2021a-mpi']
assert isinstance(result, list) assert isinstance(result, list)
assert "global" in result assert "global" in result
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment