Restructure log location
Resolves #7 (closed)
Merge request reports
Activity
added 2 commits
added 14 commits
- a0a87584...73fae389 - 4 earlier commits
- 88714209 - remove unwanted files and ignore such in the future
- a2d7e8e8 - remove duplicate imports
- 0fa58b72 - Correction from Ashwin
- 405c8592 - Apply 1 suggestion(s) to 1 file(s)
- 5c40dc36 - remove duplicate logs
- ba0b6a21 - change log file names
- 0b53b0ec - move the logfile creation into main
- 4de5d82c - add cmd to logfile name
- 5f65a780 - create create_log_file_names function
- dfc10e5c - add test_create_log_file_names
Toggle commit listadded 13 commits
-
0293e998...43ff41f0 - 7 commits from branch
main
- bc5e2781 - change log file names
- 91d270e2 - move the logfile creation into main
- dc6d0275 - add cmd to logfile name
- d00a2826 - create create_log_file_names function
- f940a41a - add test_create_log_file_names
- d99dbd72 - firest attempt at relocation of variables
Toggle commit list-
0293e998...43ff41f0 - 7 commits from branch
mentioned in merge request !33 (closed)
requested review from @hans.fangohr
added 10 commits
-
4bf382d0...abfe87c3 - 9 commits from branch
main
- 2bdf0df3 - Merge remote-tracking branch 'origin/main' into restructure-log-location
-
4bf382d0...abfe87c3 - 9 commits from branch
added 1 commit
- cf0f8dd6 - swap path check and command check while deciding the inst_log name
added 1 commit
- fd0bee45 - update the date to ensure two log files are created when testing
added 1 commit
- 451ef739 - refactor the installer log filename generation into a seperate function
added 2 commits
Thanks! Perhaps best discussed together. Reminder for myself for discussions:
- "Incorrect action or toolchain name" can be issued in appropriately
- perhaps split
create_log_file_names
into one function for theinstaller_log
and one forbuild_log
(to be discussed) - if the top-level command is fast, two entries in
logs
have the same time and the order is 'in the wrong way'. Example
dev-23a_cascadelake_2023-06-07T17:25:02_global_generic_install.log dev-23a_cascadelake_2023-06-07T17:25:02_install.log
Perhaps we can rename the toplevel command to always show first. (Didn't find a good solution.) Or just introduce a second delay? Ah, here is an option: Use a capital letter, for example insert CMD:
dev-23a_cascadelake_2023-06-07T17:37:51_CMD_install.log dev-23a_cascadelake_2023-06-07T17:37:51_foss2021a-serial_install.log dev-23a_cascadelake_2023-06-07T17:37:51_global_generic_install.log
- to distinguish between a
file.txt
and its full path/home/.../file.txt
, we can use filename and path (or filepath) in our description and variable/function names.
Not introduced here, but perhaps good to review at this time:
-
setup_log_cmd
is a misleading name. Should we call itrecord_top_level_command
or similar? - the time tag (2023-06-07T16:51:11) works fine, but for autocompletion, we need to escape the colons. That's annoying, in particular if you need to pick a particular time while doing tab-completion. Move to a time format with dashes instead of colons?
2023-06-07T16-51-11
? or2023-06-07T165111
?
Need to look into:
- log message output is confused (probably from earlier)- top level log file (
install.log
) should point to script-log file indev-23a/logs
Edited by Hans Fangohradded 17 commits
- a359f15a...8a7371af - 7 earlier commits
- 5834398c - clarify that get_installer_log_file gets name
- 1b53a4ff - fix tests
- f0fb27ac - fix filename in set_up_logging
- b0cb4728 - fix typo it should be get_installer_log_file_path
- 74694e62 - fix typo : get_installer_log_file_path
- 499b03f3 - update doc string
- 7d09f26c - fix build_log_path in install_environment
- cebc78aa - fix tests
- efe82331 - Merge branch 'rename-log-variables' into 'rename-log-files'
- 704eb33a - Merge branch 'rename-log-files' into 'restructure-log-location'
Toggle commit listadded 9 commits
- 4c752b1e - restructure create_log_file_names
- 7e8f39a3 - update usage of the function
- 790ea004 - return none for wrong action
- 5145b063 - fix typo and tests
- c4609953 - black
- 9d5fdffa - fix typo
- c3b62aab - expand the returns to included the case for None
- 5d1f51af - simplify create_log_file_names using fsrings
- f98e85ce - Merge branch 'split-logfile-templates' into 'restructure-log-location'
Toggle commit listmentioned in commit 9b922eb1
mentioned in merge request !52 (merged)
Please register or sign in to reply