if MPSD_MICROARCH is not defined, use archspec to determine
1 unresolved thread
1 unresolved thread
What does the MR provide?
- If MPSD_MICROARCH is not defined as a environment variable, then use archspec to determine it.
- if archspec is not available, ask user to provide it via error message and stop.
Where does this matter?
- script creates a folder for the microarchitecture.
- Found in Docker container that this would be
dev-23a/UNKNOWN_MICROARCH/ - the same will happen on other user machines (unless they are the Linux laptops provided by MPSD; but we know several people who prefer to run their own distribution, or even non-linux system (i.e. Mac).
Edited by Hans Fangohr
Merge request reports
Activity
added 18 commits
-
56f9b1d4...efef6a6a - 17 commits from branch
main - 82b2f791 - Merge branch 'main' into more-robust-micro-architecture-detection
-
56f9b1d4...efef6a6a - 17 commits from branch
requested review from @akarnad
517 572 # Set required variables 518 573 release_base_dir = script_dir / mpsd_release 519 574 os.environ.get("MPSD_OS", "UNKNOWN_OS") 520 mpsd_microarch = os.environ.get("MPSD_MICROARCH", "UNKNOWN_MICROARCH") 521 toolchain_dir = release_base_dir / mpsd_microarch 575 microarch = get_native_microarchitecture() 576 toolchain_dir = release_base_dir / microarch 522 577 toolchain_dir.mkdir(parents=True, exist_ok=True) - Comment on lines -520 to 522
can we remove these changes, In the implementation of #7 (closed) I am checking
mpsd_microarchinmainand not here, so it might add to the unwanted merge conflict? If we merge just the function, I can make sure to use this in my other MR. Otherwise, this MR looks good to me so ill approve it.
added 1 commit
- e4927b09 - undo changes in calling the function to prepare for other MR
enabled an automatic merge when the pipeline for e4927b09 succeeds
mentioned in commit 449f2251
Please register or sign in to reply