Skip to content
Snippets Groups Projects

Add pre-commit hooks

Merged Ashwin Kumar Karnad requested to merge add-pre-commit-hook into main

Merge request reports

Pipeline #373171 passed

Pipeline passed for 490c853b on add-pre-commit-hook

Approved by

Merged by Hans FangohrHans Fangohr 1 year ago (Jun 22, 2023 3:15pm UTC)

Merge details

  • Changes merged into main with b322f8f3.
  • Deleted the source branch.

Pipeline #373294 passed

Pipeline passed for b322f8f3 on main

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
development.rst 0 → 100644
1 Developers Setup
  • This is an RST file (not markdown).

  • I didnt want to add an md file when the readme is in rst. Is there a reason why you chose to work on rst ( given that it has a strange syntax for a markup language)

  • RST is different from markdown, and you have learned markdown first, so perhaps that is why you consider it strange ;-). I agree the links are more intuitive in markdown.

    RST is more powerful, and the language used in sphinx and (often?) python docstrings.

    One feature I like in particular for README.rst files is that you can have a table of content created (which is not supported by markdown).

    I am all in favour of sticking to RST. I think I have fixed most of this file already?

  • Please register or sign in to reply
  • Hans Fangohr
  • Looks fine to me; apart from requested changes.

    It is an extra step to set up the repo for devolpment. So it is good this is documented. Should check that every possible developer is familiar with this (in Python).

  • added 1 commit

    • 5bf66265 - Apply changes from Hanss changes

    Compare with previous version

  • added 1 commit

    • 9c609105 - remove unused file checks in precommit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading