Remove cmd

TODO: Remove method should also write a build log. ( after !115 (merged) )

added 117 commits

• cb319aa9...30a9c4b7 - 114 commits from branch main
• 7493a95c - ask for the prompt only if force not present
• be99d8de - update tests
• 1eb99e7b - add comments in remove_environment

Compare with previous version

added 3 commits

• 14bc5045 - update remove routine
• 7f4b00bb - add remove_spack_environment
• 834b21e6 - add remove_spack_package

Compare with previous version

added 3 commits

• 1b7e2e2a - update exit codes
• 33305d5b - switch to rm -rf
• 120c3429 - add tests for remove command

Compare with previous version

added 1 commit

• f798d117 - put back test_environment_status

Compare with previous version

added 1 commit

• dab2d516 - use . instead of source to be POSIX compliant

Compare with previous version

marked this merge request as ready

added 2 commits

• 7d03aaab - add comments and docs to remove_spack_environment
• 62d27b56 - add doc string to remove_spack_package

Compare with previous version

added 1 commit

• 247743d1 - add steps to remove from global packages

Compare with previous version

added 3 commits

• 7668cce3 - fix typo
• ca3e7005 - fix POSIX compliant sourcing
• 019c7cf1 - add test_remove_global_package_sets

Compare with previous version

added 30 commits

• 019c7cf1...587eb9cb - 13 commits from branch main
• 587eb9cb...4307884f - 7 earlier commits
• ef0d7742 - switch to rm -rf
• c2a6f04d - add tests for remove command
• 79fcc02b - put back test_environment_status
• f10e95db - use . instead of source to be POSIX compliant
• ee8d8578 - add comments and docs to remove_spack_environment
• 795802bf - add doc string to remove_spack_package
• 2657119c - add steps to remove from global packages
• 0bcc1296 - fix typo
• 99b2b5a8 - fix POSIX compliant sourcing
• 6013d566 - add test_remove_global_package_sets

Compare with previous version

added 5 commits

• f9972bc9 - fix typo
• 870207d6 - document exit codes
• fd5a417a - document exit codes
• 85d0ddd3 - log removal of package sets
• 56343803 - update tests

Compare with previous version

added 4 commits

• 6149434e - use subshell to ensure the redirect happens for all command
• 697387f5 - test remove_build_log and its contents
• 81648694 - use tee in append mode
• 95820236 - test remove_build_log when uninstalling global packages

Compare with previous version

Can we turn this into Draft mode until the tests pass?

marked this merge request as draft

The tests pass on my machine but not on the container. Debugging the strict POSIX standards of dash!

added 1 commit

• 091e3853 - Set SPACK_ROOT instead of SPACK_DIR

Compare with previous version

marked this merge request as ready

requested review from @hans.fangohr

Very impressive. I like all the tests.

I am running the tests and will play with the tool interactively a little, but make the review so far available already so you can get going on the feedback.