Skip to content
Snippets Groups Projects
Unverified Commit 1fb4c28e authored by Giovanni Cimolin da Silva's avatar Giovanni Cimolin da Silva
Browse files

Update deprecated test methods

parent 4a2f014a
No related branches found
No related tags found
No related merge requests found
...@@ -137,7 +137,7 @@ class TestLti1p3Consumer(TestCase): ...@@ -137,7 +137,7 @@ class TestLti1p3Consumer(TestCase):
Check that user roles are correctly translated to LTI 1.3 compliant rolenames. Check that user roles are correctly translated to LTI 1.3 compliant rolenames.
""" """
roles = self.lti_consumer._get_user_roles(role) # pylint: disable=protected-access roles = self.lti_consumer._get_user_roles(role) # pylint: disable=protected-access
self.assertItemsEqual(roles, expected_output) self.assertCountEqual(roles, expected_output)
def test_get_user_roles_invalid(self): def test_get_user_roles_invalid(self):
""" """
...@@ -158,7 +158,7 @@ class TestLti1p3Consumer(TestCase): ...@@ -158,7 +158,7 @@ class TestLti1p3Consumer(TestCase):
# Extract and check parameters from OIDC launch request url # Extract and check parameters from OIDC launch request url
parameters = parse_qs(urlparse(preflight_request_data['oidc_url']).query) parameters = parse_qs(urlparse(preflight_request_data['oidc_url']).query)
self.assertItemsEqual( self.assertCountEqual(
parameters.keys(), parameters.keys(),
[ [
'iss', 'iss',
...@@ -290,7 +290,7 @@ class TestLti1p3Consumer(TestCase): ...@@ -290,7 +290,7 @@ class TestLti1p3Consumer(TestCase):
self.assertEqual(mock_time.call_count, 2) self.assertEqual(mock_time.call_count, 2)
# Check launch request contents # Check launch request contents
self.assertItemsEqual(launch_request.keys(), ['state', 'id_token']) self.assertCountEqual(launch_request.keys(), ['state', 'id_token'])
self.assertEqual(launch_request['state'], 'state') self.assertEqual(launch_request['state'], 'state')
# TODO: Decode and check token # TODO: Decode and check token
......
...@@ -964,7 +964,10 @@ class TestLtiConsumer1p3XBlock(TestCase): ...@@ -964,7 +964,10 @@ class TestLtiConsumer1p3XBlock(TestCase):
self.assertEqual(response.status_code, 200) self.assertEqual(response.status_code, 200)
# Check if tool OIDC url is on page # Check if tool OIDC url is on page
self.assertIn(self.xblock_attributes['lti_1p3_oidc_url'], response.body) self.assertIn(
self.xblock_attributes['lti_1p3_oidc_url'],
response.body.decode('utf-8')
)
# pylint: disable=unused-argument # pylint: disable=unused-argument
@patch('lti_consumer.utils.get_lms_base', return_value="https://example.com") @patch('lti_consumer.utils.get_lms_base', return_value="https://example.com")
...@@ -985,8 +988,10 @@ class TestLtiConsumer1p3XBlock(TestCase): ...@@ -985,8 +988,10 @@ class TestLtiConsumer1p3XBlock(TestCase):
# Check response and assert that state was inserted # Check response and assert that state was inserted
self.assertEqual(response.status_code, 200) self.assertEqual(response.status_code, 200)
self.assertIn("state", response.body)
self.assertIn("state_test_123", response.body) response_body = response.body.decode('utf-8')
self.assertIn("state", response_body)
self.assertIn("state_test_123", response_body)
def test_launch_callback_endpoint_when_using_lti_1p1(self): def test_launch_callback_endpoint_when_using_lti_1p1(self):
""" """
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment