Skip to content
Snippets Groups Projects
Commit dcf80007 authored by michaelroytman's avatar michaelroytman
Browse files

fix: inappropriate instructions for inline PII sharing consent dialog

This commit fixes inappropriate instructions displayed when collecting PII sharing consent before an inline LTI launch. Previously, the instructions said, "Click OK to have your [username (and) e-mail address] sent to a 3rd party application. Click Cancel to return to this page without sending your information." The latter sentence does not make sense in the context of an inline launch, because there is no cancel button. This commit modifies the inline PII sharing consent dialog to say, "Click OK to have your [username (and) e-mail address] sent to a 3rd party application.""
parent 3088b610
No related branches found
No related tags found
No related merge requests found
...@@ -16,6 +16,11 @@ Please See the [releases tab](https://github.com/openedx/xblock-lti-consumer/rel ...@@ -16,6 +16,11 @@ Please See the [releases tab](https://github.com/openedx/xblock-lti-consumer/rel
Unreleased Unreleased
~~~~~~~~~~ ~~~~~~~~~~
8.0.1 - 2023-02-03
------------------
* This releases fixes the PII sharing consent dialog for inline launches to no longer refer to a nonexistent
"Cancel" button.
8.0.0 - 2023-01-31 8.0.0 - 2023-01-31
------------------ ------------------
* Update to work with bleachk>=6.0.0 and make that an explicit requirement in * Update to work with bleachk>=6.0.0 and make that an explicit requirement in
......
...@@ -4,4 +4,4 @@ Runtime will load the XBlock class from here. ...@@ -4,4 +4,4 @@ Runtime will load the XBlock class from here.
from .apps import LTIConsumerApp from .apps import LTIConsumerApp
from .lti_xblock import LtiConsumerXBlock from .lti_xblock import LtiConsumerXBlock
__version__ = '8.0.0' __version__ = '8.0.1'
...@@ -154,15 +154,21 @@ function LtiConsumerXBlock(runtime, element) { ...@@ -154,15 +154,21 @@ function LtiConsumerXBlock(runtime, element) {
function renderPIIConsentPromptIfRequired(onSuccess, showCancelButton=true) { function renderPIIConsentPromptIfRequired(onSuccess, showCancelButton=true) {
if (askToSendUsername && askToSendEmail) { if (askToSendUsername && askToSendEmail) {
msg = gettext("Click OK to have your username and e-mail address sent to a 3rd party application.\n\nClick Cancel to return to this page without sending your information."); msg = "Click OK to have your username and e-mail address sent to a 3rd party application.";
} else if (askToSendUsername) { } else if (askToSendUsername) {
msg = gettext("Click OK to have your username sent to a 3rd party application.\n\nClick Cancel to return to this page without sending your information."); msg = "Click OK to have your username sent to a 3rd party application.";
} else if (askToSendEmail) { } else if (askToSendEmail) {
msg = gettext("Click OK to have your e-mail address sent to a 3rd party application.\n\nClick Cancel to return to this page without sending your information."); msg = "Click OK to have your e-mail address sent to a 3rd party application.";
} else { } else {
onSuccess("OK"); onSuccess("OK");
return; return;
} }
if (showCancelButton) {
msg += "\n\nClick Cancel to return to this page without sending your information.";
}
msg = gettext(msg);
$.when(confirmDialog(msg, $(this), showCancelButton)).then(onSuccess); $.when(confirmDialog(msg, $(this), showCancelButton)).then(onSuccess);
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment