Skip to content
Snippets Groups Projects
  1. Jul 27, 2022
  2. Jul 22, 2022
    • Michael Roytman's avatar
      Merge pull request #268 from openedx/mroytman/MST-1540-debugging-logs · d6069241
      Michael Roytman authored
      test: add debugging log statements for user_id LtiError
      d6069241
    • michaelroytman's avatar
      test: add debugging log statements for user_id LtiError · 617d8781
      michaelroytman authored
      This commit adds supplemental logging to diagnose the bug reported in MST-1540: https://2u-internal.atlassian.net/browse/MST-1540. The bug is that learners are encountering the LtiError when trying to do an LTI launch. The learners appear to be authenticated, so this error should not occur. The bug is not easily reproducible in production or development, so this supplemental logging is added to help understand the user's state when the error is raised.
      
      The current hypothesis is that user is temporarily represented by the AnonymousUser in the request that is made when doing the LTI launch, despite the user otherwise being authenticated. Logging in Splunk suggests that this is the case, because logs are of the following form, "2022-07-22 15:10:14,214 ERROR 5067 [django.request] [user None] [ip <ip>] log.py:224 - Internal Server Error: /courses/<course_key>/xblock/<usage_key>/handler/lti_launch_handler", where the "user" is "None". This logging should prove or disprove this hypothesis and provide direction about where else to look.
      
      This logging should be removed once MST-1540 is resolved.
      617d8781
    • Michael Roytman's avatar
      Merge pull request #266 from openedx/mroytman/MST-1467-fix-edit-menu-bugs · dcd5135c
      Michael Roytman authored
      fix: hidden lti_version and 1.3 fields in edit view and incorrect menu behavior in Javascript
      dcd5135c
    • michaelroytman's avatar
      fix: hidden lti_version and 1.3 fields in edit view and incorrect menu behavior in Javascript · 34003401
      michaelroytman authored
      This commit fixes three bugs.
      
      1. The first bug is that the lti_version field is inappropriately hidden in the Studio author view edit menu when the selected config_type is database.
      
      2. The second bug is that the editable_fields property of the LtiConsumerXBlock is inappropriately excluding LTI 1.3 fields when the config_type is database. The editable_fields property should include LTI 1.3 fields even when the config_type is database, because the Javascript defined in xblock_studio_view.js may want to show these fields if the user selects a different config_type in the menu. We want to support a dynamic edit menu, so these fields must be considered editable by the XBlock in order for the Javascript to be able to manipulate them.
      
      3. The third bug is in inconsistent rendering of the Studio author view edit menu. Depending on the order in which a user selects lti_version, config_type, or lti_1p3_tool_key_mode, different sets of fields are displayed, due to the overlapping sets of rules that govern what fields should be hidden or shown for a given field selection. This commit corrects this inconsistent rendering by first showing all fields and then gradually hiding fields depending on the sets of rules, for each change to the fields.
      34003401
  3. Jul 18, 2022
    • Michael Roytman's avatar
      Merge pull request #260 from openedx/mroytman/MST-1467-lti-django-configuration · 5a823654
      Michael Roytman authored
      feat: Add core LTI 1.3  and LTI Advantage configuration to LTIConfiguration model and support xBlock using the database
      5a823654
    • michaelroytman's avatar
      feat: Add core LTI 1.3 and Advantage configuration to LTIConfiguration model · d5e98141
      michaelroytman authored
      This commit adds additional core LTI 1.3 and LTI Advantage variables to the LTIConfiguration model. The additional core LTI 1.3 variables are lti_1p3_oidc_url, lti_1p3_launch_url, lti_1p3_tool_public_key, and lti_1p3_tool_keyset_url. The additional LTI Advantage variables are lti_advantage_enable_nrps, lti_advantage_deep_linking_enabled, lti_advantage_deep_linking_launch_url, and lti_advantage_ags_mode.
      
      This commit also adds a configuration type to the LtiConsumerXBlock to support the storage of these LTI variables on the LTIConfiguration model (i.e. the database) instead of the xBlock itself.
      
      Changes that allow the use of this configuration option are behind the lti_consumer.enable_database_config CourseWaffleFlag.
      d5e98141
  4. Jul 11, 2022
  5. Jul 05, 2022
  6. Jun 27, 2022
  7. Jun 22, 2022
  8. Jun 09, 2022
  9. Jun 08, 2022
  10. Jun 02, 2022
  11. May 23, 2022
  12. May 11, 2022
  13. May 09, 2022
  14. May 02, 2022
  15. Apr 25, 2022
  16. Apr 06, 2022
  17. Apr 05, 2022
  18. Mar 31, 2022
  19. Mar 21, 2022
  20. Mar 18, 2022
  21. Mar 17, 2022
  22. Mar 04, 2022
  23. Mar 03, 2022
  24. Feb 24, 2022
Loading