item submission - bugs
While creating a test "workflow" item (but I think this is valid for all items type) on the stage instance, as contributor, I've noticed the following bugs:
-
I first open the edit form to create a workflow, created 1 step and "save as a draft" the whole workflow. In "my draft items" I can see the workflow and the step as two separate elements. I don't see the added-value to see the steps in the list of draft items, so I'd be in favour of removing steps from the "my draft items" list.
-
I come back to the workflow to continue the editing, add new steps and submit the workflow. I end up with 2 suggested workflows in my "suggested items". Why? I expect only one there. It seems that the initial draft was submitted alongside the updated/most recent draft. On the contrary while editing a draft, I expect to "overwrite" the draft version previously saved.
- Once submitted, as contributor, I still want to introduce a change. I go to "my suggested items" pick one of the two workflow versions (the most recent) and make a change (= step order) but I can't submit my change, only save it. I think we agree on this (no changes on suggested item can be introduced while approved is pending, correct?). I think we should change the banner for this specific case and add something like "failed to submit because....". Furthermore, for workflows, I couldn't see the list of versions at the bottom of the edit form.
It still possible to save it as draft, I do it and I end up with 3 entries in the "my draft items": 1 workflows and 2 steps
-- Then, when signed in as "moderator", in the list of items to review, I see the same two suggested items.
I reject version 40453, but the only thing that changes is that I see the following message on the item detail preview "You are currently viewing a disapproved version". Even once rejected, the item still appears on the list of item to moderate, with a "suggested" status.
To sum up, I see 4 things we need to fix based on this example:
- "My draft items" list should not include steps but only workflows
- When re-opening, editing and submitting a draft version, it should only push the latest draft version to suggested. The former draft version should (in my opinion) be deleted/erased
- Once an item is in the moderation queue (=status suggested), a contributor should be better warned that they won't be able to submit again.
- Can someone explain to me how the rejection is supposed to work? Is there a distinction between rejected and deprecated? If yes, we need to add "rejected" in the status facets on "items to moderate". This last point probably deserves a separate issue.
notify also @edward.gray @klaus.illmayer @tparkola