Skip to content

Feature/#160 set xhtml dir rtl in serialization root node

Feature

Summary

With this MR the result of the HTML serialization receives an @dir="rtl". As a consequence, all text and icons are interpreted in rtl so that the annotation icons are displayed on the correct spot.

Compliance to “Definition of Done”

  • Unit tests passed
  • Code reviewed
  • Product Owner accepts the User Story

Documentation

  • I updated the README (if applicable)
  • I provided my functions with appropriate documentation
  • I updated existing documentation

Tests

Are we able to test this new feature?

  • Yes, everything can be done via unit tests.
  • Yes, you can test by following these steps: …
  1. build and start the current branch of TIDO with the annotations in it. To do this, clone https://gitlab.gwdg.de/subugoe/emo/Qviewer/ and build the current develop branch with npm i
  2. set https://ahikar-test.sub.uni-goettingen.de/api/textapi/ahikar/syriac/collection.json as entry point in src/index.template.html and run the viewer with npm run dev. You have to be logged in to VPN so see the data.
  3. see the desired output as described in #160 (closed) in your local viewer

Changelog

  • I added a statement to the CHANGELOG.

Version number

  • I bumped the version number in build.properties.

Closes

Closes #160 (closed)

/cc Mathias Göbel, Frank Schneider, Michelle Weidling

Edited by Michelle Weidling

Merge request reports

Loading