Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • backend backend
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare revisions
  • Issues 14
    • Issues 14
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • subugoesubugoe
  • ahiqarahiqar
  • backendbackend
  • Merge requests
  • !146

Feature/#164 annotations html implementation of simple motifs

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Michelle Weidling requested to merge feature/#164-annotations-html-implementation-of-simple-motifs into develop May 07, 2021
  • Overview 3
  • Commits 13
  • Pipelines 0
  • Changes 10

Feature

Summary

This MR introduces an in-memory intermediate format for simple motifs(*) which is produces by the motifs-expansion.xqm module. It detects motifs (encoded as oXygen comment/processing instruction) and converts them to tei:span. A simply motif spanning several lines is transformed to several tei:span elements which are connected via an ID and the @next attribute.

This intermediate format is then used to create an xhtml:span when creating the HTML pages in tei2html.xqm module, making the motifs findable by the annotation panel.

(*) simple motifs are text passages in which only one motif is present, i.e. a piece of text doesn't have more than one motif. For the complex case cf. #165 (closed).

Compliance to “Definition of Done”

  • Unit tests passed
  • Code reviewed
  • Product Owner accepts the User Story

Documentation

  • I updated the README (if applicable)
  • I provided my functions with appropriate documentation
  • I updated existing documentation

Tests

Are we able to test this new feature?

  • Yes, everything can be done via unit tests.

Changelog

  • I added a statement to the CHANGELOG.

Version number

  • I bumped the version number in build.properties.

Closes

Closes #164 (closed)

Logs and Screenshots

How the motifs look like in HTML

Screenshot_2021-05-07_12-32-46

AnnotationAPI now considers multi-line motifs in ID creation

image

/cc Mathias Göbel, Frank Schneider, Michelle Weidling

Edited May 07, 2021 by Michelle Weidling
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/#164-annotations-html-implementation-of-simple-motifs