Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • backend backend
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare revisions
  • Issues 12
    • Issues 12
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • subugoesubugoe
  • ahiqarahiqar
  • backendbackend
  • Merge requests
  • !154

feat: remove `total` and `startIndex`

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Michelle Weidling requested to merge feature/#172-remove-total-and-startIndex into develop Jun 08, 2021
  • Overview 5
  • Commits 4
  • Pipelines 3
  • Changes 9

Feature

Summary

This MR removes the fields total and startIndex from the AnnotationAPI. The reasons for this decision are:

  • Both keys are not mandatory according to the W3C Data Annotation Model
  • They aren't used in any of our application
  • Depending on the size of the collection they are quite costly to compute

Although we now this might result in some drawbacks when using the annotations in another application outside the SUB (there is no use case for this scenario yet), we decided to opt for a better performance.

Compliance to “Definition of Done”

  • Unit tests passed
  • Code reviewed
  • Product Owner accepts the User Story

Documentation

  • I updated the README (if applicable)
  • I provided my functions with appropriate documentation
  • I updated existing documentation

Tests

Are we able to test this new feature?

  • Yes, everything can be done via unit tests.

Changelog

  • I added a statement to the CHANGELOG.

Version number

  • I bumped the version number in build.properties.

Closes

Closes #172 (closed).

/cc Mathias Göbel, Frank Schneider, Michelle Weidling

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/#172-remove-total-and-startIndex