Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • backend backend
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare revisions
  • Issues 12
    • Issues 12
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • subugoesubugoe
  • ahiqarahiqar
  • backendbackend
  • Merge requests
  • !226

Resolve "API token check true when no token is set/given"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mathias Goebel requested to merge 258-api-token-check-true-when-no-token-is-set-given into develop Jan 13, 2023
  • Overview 4
  • Commits 6
  • Pipelines 22
  • Changes 13

this MR makes the architecture more fail-safe by always setting a default token on input and so it closes #258 (closed).

in addition it contains a minor change in the docker setup required for fixing an server-side issue with an "ambiguous network name": "test_default". as this is a name easily taken by a different project, i decided to include the fix immediately.

we now set an env var COMPOSE_PROJECT_NAME with an appropriate name. the standard way now would be to set a top-level name property, but this is not supported by the olde version installed server-side.

ALSO dind now includes docker-compose so our ci-docker image is obsolete and should be removed from registry and repo (Dockerfile) → #260 (closed).

Edited Jan 13, 2023 by Mathias Goebel
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 258-api-token-check-true-when-no-token-is-set-given