Skip to content

fix: patch the entrypoint for the Ahikar demo / dev branch

schneider210 requested to merge bugfix/set-ci-entrypoint into develop

Bug fix

Summary

Apart from what is mentioned in the main ticket you are going to close with this MR, tell us what you have done to achieve this goal.

add a shell script (set_entrypoint_ci.sh)

to patch the entrypoint

reason: if an entrypoint is provided, it will be compiled and integrated into the build.

the build takes precedence and prevents the according config option to take effect (in index.html)

on the the other hand, the entrypoint is needed for the Ahikar demo page to show any data

Ahikar Demo actually not working without entrypoint

hence the script has to be run once everytime a merge into dev is done and therefore it has to be integrated into .gitlab-ci.yml

this assures to keep the demo page running / showing the Ahikar collection data on the one hand side and to avoid further config conflicts on the other.

Does the result of the MR comply to our "definition of done"?

  • Unit tests passed
  • Code reviewed
  • Acceptance criteria met
  • Functional tests passed
  • Non-Functional requirements met
  • Product Owner accepts the User Story

Related

Closes

Changelog

  • I added a statement to the CHANGELOG. No.

Documentation

  • I updated the README (if applicable)
  • I provided my functions with appropriate documentation

/cc Mathias Göbel, Frank Schneider, Michelle Weidling

Edited by schneider210

Merge request reports

Loading