Skip to content

feature/#172: Created a new keys button and modal to display text style labels

Manikanth Dindigala requested to merge feature/#172-text-style-labels into develop

Feature

Summary

This MR provides…

  • Transfer intranet text styling specification info to key modal.

Note: Keys button is placed next to increase/decrease buttons inside Text Panel, since there is an existing issue related to responsive heights.

Note: Closing this MR to fix panels height bug first and open a new one with requested changes.

Does the result of the MR comply to our "definition of done"?

  • Unit tests passed
  • Code reviewed
  • Acceptance criteria met
  • Functional tests passed
  • Non-Functional requirements met
  • Product Owner accepts the User Story

Documentation

  • I updated the README (if applicable)
  • I provided my functions with appropriate documentation
  • I adjusted other parts of the documentation (if applicable)

Tests

Are we able to test this new feature?

  • Yes, everything can be done via unit tests.
  • Yes, you can test by following these steps: A new button is created next to increase and decrease button inside text panel. When you click on it, a modal is opened and you can view the labels of related text styles explained. since most of the keys in text panel are handled from annotation panel, the display of keys button appears only when there are any specific keys to display. ex: Karshuni Collection: https://ahikar-dev.sub.uni-goettingen.de/api/textapi/ahikar/arabic-karshuni/collection.json Borg. Arab. 201 - sheet 199a, 200a or. 1292. The Arabic Text in Leiden. - sheet 194. Cod. Sach. 339 - Sheet p.1, p.2, p.3, p.4, p.5...

Syriac Collection: https://ahikar-dev.sub.uni-goettingen.de/api/textapi/ahikar/syriac/collection.json

MSS_611 - sheet 1v

  • No, it is not possible.

Changelog

  • I added a statement to the CHANGELOG.

Related Tickets

Add all related issues and especially those to be closed.

Related

Closes

Logs and Screenshots

/cc Mathias Göbel, Frank Schneider, Michelle Weidling

Edited by Manikanth Dindigala

Merge request reports

Loading